From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F9CC27C55 for ; Fri, 7 Jun 2024 09:28:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A0576B00A9; Fri, 7 Jun 2024 05:28:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 528196B00AD; Fri, 7 Jun 2024 05:28:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3542D6B00B9; Fri, 7 Jun 2024 05:28:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1332D6B00A9 for ; Fri, 7 Jun 2024 05:28:06 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BC78A40338 for ; Fri, 7 Jun 2024 09:28:05 +0000 (UTC) X-FDA: 82203566130.13.3EFA4DC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 1D57140003 for ; Fri, 7 Jun 2024 09:28:02 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0+rVBF1x; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="+A8Jb/NG"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ejn6EkIL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=yWxFcLSw; dmarc=none; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717752483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9zzzgmlwIaLnzeie/GLqlqvPmYP7Zl/QG1EFV+Urcpg=; b=jP6YZn/7YjAXSodZ+34fgMJjRKvtk8lEpm1YW+Xh9i34RKQbfab3p6aJ8fF2lfXd+a1gxE nR8Qkl3xKaXUKHnRHCeypWz0/VmlXIdMeLHa5e/PoJes3CGh+4pNGOvhyZzlCbfnq5qntj 25+pNJyt8BWcB1m80RidFLwImACHj5g= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0+rVBF1x; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="+A8Jb/NG"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ejn6EkIL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=yWxFcLSw; dmarc=none; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717752483; a=rsa-sha256; cv=none; b=ykjQE2/RzSGPWpUVGUXMKu9XCcRRzor21f70n9pKDsTxQDuYQ3L69j7CTR9JUVX3DZJV9v a2uUFgW/lmGHCFUXB07vWCjEkO4bXkqSssnfxKMk7R6eR00r4PXTEGWnRadXv65MAWR6Id Zl3lUJbhuFXJYLoWYFMP1UyLhhRSQGk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1BB8421B4D; Fri, 7 Jun 2024 09:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717752481; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9zzzgmlwIaLnzeie/GLqlqvPmYP7Zl/QG1EFV+Urcpg=; b=0+rVBF1x/VK2HojqvTuYl5cq5IDLFWU3pDbAvrWYFrDIYDPeXRMFjWS31CwZkK5T1XFdmN 8WrYCgBI1Zc62TdeGNgOEA7nm8ZJQl6A8Tem1eJBjs2tc3loN19I2SkvEGu0p/QQJNqsNx 6Ro5P83C8H8Enid+pr7XSPUAT9pkVME= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717752481; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9zzzgmlwIaLnzeie/GLqlqvPmYP7Zl/QG1EFV+Urcpg=; b=+A8Jb/NGCsxDvVLqG2doIGa8fEILGhEbdOioFglSWJoC5jt1W8yyw1Lm6arsEvh0FiDi3l b8bQNd3GKIj68mAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717752480; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9zzzgmlwIaLnzeie/GLqlqvPmYP7Zl/QG1EFV+Urcpg=; b=ejn6EkILhc36nPUUCvF4Qx3exiLcvKtMu8i/UvvAcKNyOqJu/RcL+dyDsCESkL4P+1MEEs 2lvn8MScnrCRu3qPwFXu2uVnporiP9lqmsNsoPH5Mj22LcDG1YJktwYdjYdfwVqPlOGmrA TBL/jBQAHAPrgWGEAuIkGq1XH0IZXwg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717752480; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9zzzgmlwIaLnzeie/GLqlqvPmYP7Zl/QG1EFV+Urcpg=; b=yWxFcLSwDJFcw7RFctnJFZLp+wmeB1ylyLzcjgtIv1UbhlLoqUofMBdNGD9w5I67BV1DPf yT0EvBHthSpNhjAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 02D3313A42; Fri, 7 Jun 2024 09:28:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id csIvAKDSYmb8IAAAD6G6ig (envelope-from ); Fri, 07 Jun 2024 09:28:00 +0000 Message-ID: <44ffe587-38fd-4a3e-8c90-45037a76e30a@suse.cz> Date: Fri, 7 Jun 2024 11:27:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] slab: fix and cleanup of slub_debug Content-Language: en-US To: Chengming Zhou , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com References: <20240607-b4-slab-debug-v3-0-bb2a326c4ceb@linux.dev> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240607-b4-slab-debug-v3-0-bb2a326c4ceb@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 1D57140003 X-Stat-Signature: 83ixxib1ezo8snipnhexts9e5g19sec9 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717752482-361832 X-HE-Meta: U2FsdGVkX19d8CYxlSyNzhjHKKNKWtmykOBZ05kKGuzWmhlrnY1138DLf5EW2M1rSAZPLZzkv+uSDTNljopYgDKcpYGATh1hEAYT1XXeeojrgws/gnQ2cU5pnZe+cQgi7KJ4dW2a9K7XoHRvA+zcnmdK4VD1PYOC1Bi+uDhUek6ZDCLmK07Gue2iPl0Oo0OcjL7b/IRw7DKLCuIl2XsecYJcmtia9Re2zdYghkEzhSLVP0+GEQkKdCeShm1cSvLQe1U8Q/84hBzP2aypMu2Sv/3M/wMr6kw1/aoHcl4KSMKiDt5dL7TxTqLBLWRer+tMZAHdrJbKMo6BbGDGHsfmv/V8ORBFD1vnsgo2FA1f0OQt4dNCSWOnu6wMJzkzPZq/XD17FVZjrLKVhD0VmFk8RP2ewYEISUaL6/L9IHKNpPbBe9eBpjnbbzdOti5T1dkSjjfh+/kFlS3CM59KjZuxRO6M2RUN8oGz1hkP04yoTIU4cjpZJytrzu9Y5xDIfeyVnW0n+sNw7CIttTqp552qkPMndNkfzHu8fdrk7yqTcar2L6yGqBBlJeun6L1RDPHG6d4hIJpc8fxiuQf/awxVOyFEf4Oh1gbpvZV/73xR0oWtbq6eDvHvainERyO8i8M+uWL0LCk1iKCXXGgEMKn3fMTqSiumKCnwsiNghgNCdBROPM/yNTa8Db+bAiF61qF9sNDQDnoHH9VFyW5zruS3wMhCDtdgpGVT0IhkE9DRY4E8zJs2q9CltfD13J5ebZ26W4XEsL3uIsxs3CnISotsEPLoNaZfMqc+ndOs0UtUj9EaRbekaVK4DyCMhCaz6J/p5K40DqcTB6kDmBWTOniVptSGFyKXMNeg0C3TX7g5ohHBcKnjKuyl+L2QxA49C8yzgWDBQZdPpeEQt4cJBT1WmxaEGrNqpB/0WLXSnNZF1w6HxMBt/tR4lYddpkvPOe40YwBbtJL080fYxW6z7qm SjohzbLP Ld4egnGDCNPAoaEsZdiBh6kFM9biWPGEeNi5jfR3YyYPg99ymcwCqA21QrL5QDdCvFXbYPzB8fbw4PIqZPX2POdsAExG+kz1QQqCeWMEifL4BQhBlN7pbGDo5GqymTPPuRtRTc1c+UE+BSJFgLQTd+HHybjNbGd22paoEFY6wyjA3mKxfJx1oiMaj/4oSxMAZC9dQdmZi1mYNuoDBCs+HTX6ktFIlHfjctQiESjUYMNui5yVJ3FcYzgT44PAni2T7a6pOuzygfQ9gQsB5VQi6FfAnxxVleICdzzcMwMz7eA3odJF1inO3eQciMer21RY0KLO6QEkUyDMUpqLh/xJAK2c7K5kCDR03Wnzi/N725yl2L4qSvoCi1t1Ap2+H9TzpNEWPXZeCUg9JhIecTeOPvb8DkeO/RM9C8b6d01Et2h8ttBRVADQq/T3hNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/7/24 10:40 AM, Chengming Zhou wrote: > Changes in v3: > - Fix slub_kunit tests failures by using new introduced > slab_in_kunit_test(), which doesn't increase slab_errors. > - Fix the condition of whether to check free pointer and > set "ret" correctly. > - Collect Reviewed-by tags from Vlastimil Babka. > - Link to v2: https://lore.kernel.org/r/20240605-b4-slab-debug-v2-0-c535b9cd361c@linux.dev > > Changes in v2: > - Change check_object() to do all the checks without skipping, report > their specific error findings in check_bytes_and_report() but not > print_trailer(). Once all checks were done, if any found an error, > print the trailer once from check_object(), suggested by Vlastimil. > - Consolidate the two cases with flags & SLAB_RED_ZONE and make the > complex conditional expressions a little prettier and add comments > about extending right redzone, per Vlastimil. > - Add Reviewed-by from Feng Tang. > - Link to v1: https://lore.kernel.org/r/20240528-b4-slab-debug-v1-0-8694ef4802df@linux.dev > > Hello, > > This series includes minor fix and cleanup of slub_debug, please see > the commits for details. > > Signed-off-by: Chengming Zhou applied to slab/for-next, thanks > --- > Chengming Zhou (3): > slab: make check_object() more consistent > slab: don't put freepointer outside of object if only orig_size > slab: delete useless RED_INACTIVE and RED_ACTIVE > > include/linux/poison.h | 7 ++-- > mm/slub.c | 77 ++++++++++++++++++++++++++++---------------- > tools/include/linux/poison.h | 7 ++-- > 3 files changed, 53 insertions(+), 38 deletions(-) > --- > base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0 > change-id: 20240528-b4-slab-debug-1d8179fc996a > > Best regards,