linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Chengming Zhou <chengming.zhou@linux.dev>,
	Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Hyeonggon Yoo <42.hyeyoo@gmail.com>,
	Feng Tang <feng.tang@intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	zhouchengming@bytedance.com
Subject: Re: [PATCH v3 0/3] slab: fix and cleanup of slub_debug
Date: Fri, 7 Jun 2024 11:27:59 +0200	[thread overview]
Message-ID: <44ffe587-38fd-4a3e-8c90-45037a76e30a@suse.cz> (raw)
In-Reply-To: <20240607-b4-slab-debug-v3-0-bb2a326c4ceb@linux.dev>

On 6/7/24 10:40 AM, Chengming Zhou wrote:
> Changes in v3:
> - Fix slub_kunit tests failures by using new introduced
>   slab_in_kunit_test(), which doesn't increase slab_errors.
> - Fix the condition of whether to check free pointer and
>   set "ret" correctly.
> - Collect Reviewed-by tags from Vlastimil Babka.
> - Link to v2: https://lore.kernel.org/r/20240605-b4-slab-debug-v2-0-c535b9cd361c@linux.dev
> 
> Changes in v2:
> - Change check_object() to do all the checks without skipping, report
>   their specific error findings in check_bytes_and_report() but not
>   print_trailer(). Once all checks were done, if any found an error,
>   print the trailer once from check_object(), suggested by Vlastimil.
> - Consolidate the two cases with flags & SLAB_RED_ZONE and make the
>   complex conditional expressions a little prettier and add comments
>   about extending right redzone, per Vlastimil.
> - Add Reviewed-by from Feng Tang.
> - Link to v1: https://lore.kernel.org/r/20240528-b4-slab-debug-v1-0-8694ef4802df@linux.dev
> 
> Hello,
> 
> This series includes minor fix and cleanup of slub_debug, please see
> the commits for details.
> 
> Signed-off-by: Chengming Zhou <chengming.zhou@linux.dev>

applied to slab/for-next, thanks

> ---
> Chengming Zhou (3):
>       slab: make check_object() more consistent
>       slab: don't put freepointer outside of object if only orig_size
>       slab: delete useless RED_INACTIVE and RED_ACTIVE
> 
>  include/linux/poison.h       |  7 ++--
>  mm/slub.c                    | 77 ++++++++++++++++++++++++++++----------------
>  tools/include/linux/poison.h |  7 ++--
>  3 files changed, 53 insertions(+), 38 deletions(-)
> ---
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
> change-id: 20240528-b4-slab-debug-1d8179fc996a
> 
> Best regards,



      parent reply	other threads:[~2024-06-07  9:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07  8:40 Chengming Zhou
2024-06-07  8:40 ` [PATCH v3 1/3] slab: make check_object() more consistent Chengming Zhou
2024-06-07  8:58   ` Vlastimil Babka
2024-06-10 17:07   ` Christoph Lameter (Ampere)
2024-06-10 20:54     ` Vlastimil Babka
2024-06-10 21:37       ` Kees Cook
     [not found]       ` <e93fc5a6-434f-376c-a819-353124da053d@linux.com>
2024-06-12 18:39         ` Kees Cook
2024-06-14  2:40         ` Chengming Zhou
2024-06-17  9:51           ` Vlastimil Babka
2024-06-17 10:29             ` Chengming Zhou
2024-06-17 11:08               ` Vlastimil Babka
2024-06-07  8:40 ` [PATCH v3 2/3] slab: don't put freepointer outside of object if only orig_size Chengming Zhou
2024-06-07  8:40 ` [PATCH v3 3/3] slab: delete useless RED_INACTIVE and RED_ACTIVE Chengming Zhou
2024-06-07  9:27 ` Vlastimil Babka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44ffe587-38fd-4a3e-8c90-45037a76e30a@suse.cz \
    --to=vbabka@suse.cz \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chengming.zhou@linux.dev \
    --cc=cl@linux.com \
    --cc=feng.tang@intel.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=zhouchengming@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox