From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC65DC4332F for ; Thu, 13 Oct 2022 17:10:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7596D6B0071; Thu, 13 Oct 2022 13:10:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70A776B0073; Thu, 13 Oct 2022 13:10:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D3B96B0074; Thu, 13 Oct 2022 13:10:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4B2D76B0071 for ; Thu, 13 Oct 2022 13:10:23 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E774FC147F for ; Thu, 13 Oct 2022 17:10:22 +0000 (UTC) X-FDA: 80016564684.29.71A83FE Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf14.hostedemail.com (Postfix) with ESMTP id 4B72A100027 for ; Thu, 13 Oct 2022 17:10:22 +0000 (UTC) Received: by mail-il1-f178.google.com with SMTP id q11so1275199ilj.10 for ; Thu, 13 Oct 2022 10:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1ut3IJn5YguVAJiDT/xFMzy3gQTlor63h4VFTKLUbEM=; b=gMylnowM8qSEF/HMJHGiCE+pUDilZbKsRldVwVMAOh0snrqdIFzSsmneMfCnMM1Uzv QzdixvWh9sFxoNJ95cf6VKuGAxUSDNhR3W5EA9wh6F8M6RaKOqPe5td8XLnmkI/nh4RU hxYPgKdlliwKs1tqrgshhehCVPguLCJQZ6X/A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1ut3IJn5YguVAJiDT/xFMzy3gQTlor63h4VFTKLUbEM=; b=d2hWLmAorhqsedS/oM1j3WW21DvK55PBMo/cwj3eQ8Z/99u9qp/1EYFsqOcMf2847Q //FdOHB8os+OvAnpEknUlp21r3HSR+R6B8PBGVNnV/CeO3/UB4VbX/kmFu7th+aS7eWX TAQlmXzH40FTLEyaWrkyVxDKVqscfzD0oh5w2NyoBaW5p8NGXAM6CKqPKgvvMuL9N6TG K5B8vD0D8YKgPhTZjtmP9VNy/aTcG947I6R7ACB+ZA1hUX0GwOM6m9sVJ6F5Md8SocRc WMZ5e0OZGyRUgpCcpcrkABtu0AyQ7uiCzZq1Wbz0CDO1UcK0JhUP0RWDAqMPKf1O2p85 qYHg== X-Gm-Message-State: ACrzQf3zteipjoGnkb0Gv6OhmKVQVO3VEa8ST5UN1ldTFmjKChoXiA6M o7Wvuu0TkdkabiPNCxbwcrQ7Vw== X-Google-Smtp-Source: AMsMyM4shy0V/vvJOp5C+M3fzvgjfTV95CCS8UuwUOggKtwayh2zIvYOI8000Mw4vcCZnbtj9mByHA== X-Received: by 2002:a05:6e02:1c87:b0:2fa:d3d7:8a29 with SMTP id w7-20020a056e021c8700b002fad3d78a29mr481628ill.179.1665681021505; Thu, 13 Oct 2022 10:10:21 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id z19-20020a056638241300b0035a578870a4sm157756jat.129.2022.10.13.10.10.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Oct 2022 10:10:20 -0700 (PDT) Message-ID: <44fcecda-31a4-7288-1848-63003dfe0a7d@linuxfoundation.org> Date: Thu, 13 Oct 2022 11:10:20 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: hmm_test issues with latest mainline Content-Language: en-US To: David Hildenbrand , Vlastimil Babka , Alex Sierra , Alistair Popple Cc: Jason Gunthorpe , Ralph Campbell , Felix Kuehling , Christoph Hellwig , Jerome Glisse , "linux-mm@kvack.org" , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan , Shuah Khan References: <26017fe3-5ad7-6946-57db-e5ec48063ceb@suse.cz> <7e2e6679-3205-3540-f522-9eaed2940559@redhat.com> From: Shuah Khan In-Reply-To: <7e2e6679-3205-3540-f522-9eaed2940559@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665681022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1ut3IJn5YguVAJiDT/xFMzy3gQTlor63h4VFTKLUbEM=; b=0ZOmefVd7t1CvTtXHUn94iNeVKtTNR68dvIvrwcVwlYGgTr7Lh/m26mDM4ERr3v4e34+XV KilFTCLMnGE7vnCoYbwzg1mNigQ+L0Vu3NwykhBlKntTQma9yT+bbrk7xCTUBxdtSHhbU3 Aviz1dNd/uTf2ifDk9RvAYIjQpDzUjM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=gMylnowM; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf14.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.178 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665681022; a=rsa-sha256; cv=none; b=UHtF9ZqbmbebcX259z8mHM1hMXnBiI+9gEWbQOk0xTnh2OBlSV75pDuAm2c/SaBwrO7Deh xprLfgDZBIr96zMFe1lwn22L1bgznnzgRq8OaswpHgf1vLUgYoQzdRCzschhSiITGQ7o91 g9bsVn7+VmmVUssdp6ceRDBozscx2f0= X-Stat-Signature: ubyhngmksjaidk5eu7wnpys1ecqrm66c X-Rspamd-Queue-Id: 4B72A100027 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=gMylnowM; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf14.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.178 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1665681022-644133 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/13/22 11:01, David Hildenbrand wrote: > On 13.10.22 18:54, Vlastimil Babka wrote: >> Hi, >> >> I've been trying the hmm_tests as of today's commit: >> >> a185a0995518 ("Merge tag 'linux-kselftest-kunit-6.1-rc1-2' ...) >> >> and run into several issues that seemed worth reporting. >> >> First, it seems the FIXTURE_TEARDOWN(hmm) in >> tools/testing/selftests/vm/hmm-tests.c >> using ASSERT_EQ(ret, 0); can run into an infinite loop of reporting the >> assertion failure. Dunno if it's a kselftests issue or it's a bug to >> use asserts in teardown. I hacked it up like this locally to proceed: >> >> --- a/tools/testing/selftests/vm/hmm-tests.c >> +++ b/tools/testing/selftests/vm/hmm-tests.c >> @@ -154,6 +154,11 @@ FIXTURE_TEARDOWN(hmm) >>   { >>       int ret = close(self->fd); >> +    if (ret != 0) { >> +        fprintf(stderr, "close returned (%d) fd is (%d)\n", ret,self->fd); >> +        exit(1); >> +    } >> + >>       ASSERT_EQ(ret, 0); >>       self->fd = -1; >>   } >> >> Next, there are some tests that fail (and thus also trigger the issue above) >> >> #  RUN           hmm.hmm_device_private.exclusive ... >> # hmm-tests.c:1702:exclusive:Expected ret (-16) == 0 (0) >> close returned (-1) fd is (3) >> # exclusive: Test failed at step #1 >> #          FAIL  hmm.hmm_device_private.exclusive >> not ok 20 hmm.hmm_device_private.exclusive >> #  RUN           hmm.hmm_device_private.exclusive_mprotect ... >> # hmm-tests.c:1756:exclusive_mprotect:Expected ret (-16) == 0 (0) >> close returned (-1) fd is (3) >> # exclusive_mprotect: Test failed at step #1 >> #          FAIL  hmm.hmm_device_private.exclusive_mprotect >> not ok 21 hmm.hmm_device_private.exclusive_mprotect >> #  RUN           hmm.hmm_device_private.exclusive_cow ... >> # hmm-tests.c:1809:exclusive_cow:Expected ret (-16) == 0 (0) >> close returned (-1) fd is (3) >> # exclusive_cow: Test failed at step #1 >> #          FAIL  hmm.hmm_device_private.exclusive_cow >> not ok 22 hmm.hmm_device_private.exclusive_cow >> >> > > When did that test start failing? Was it still ok for 6.0? > commit 4fe89d07dcc2804c8b562f6c7896a45643d34b2f (tag: v6.0, linux/master) # FAILED: 25 / 50 tests passed. # Totals: pass:25 fail:25 xfail:0 xpass:0 skip:0 error:0 Looks good to me. Possible change in 6.1 and we have to time fix them all. :) thanks, -- Shuah