From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E40BC433DB for ; Mon, 8 Mar 2021 10:36:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EA1AD651A5 for ; Mon, 8 Mar 2021 10:36:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA1AD651A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 62B088D001A; Mon, 8 Mar 2021 05:36:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DB148D000F; Mon, 8 Mar 2021 05:36:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A33A8D001A; Mon, 8 Mar 2021 05:36:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 2B9B18D000F for ; Mon, 8 Mar 2021 05:36:54 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DDCE88249980 for ; Mon, 8 Mar 2021 10:36:53 +0000 (UTC) X-FDA: 77896353906.15.7C2F6CC Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf17.hostedemail.com (Postfix) with ESMTP id 4357140001DE for ; Mon, 8 Mar 2021 10:36:52 +0000 (UTC) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DvF8l4L3HzrSV0; Mon, 8 Mar 2021 18:35:03 +0800 (CST) Received: from [10.174.179.232] (10.174.179.232) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Mon, 8 Mar 2021 18:36:46 +0800 Subject: Re: [PATCH] mm/huge_memory.c: Remove unnecessary local variable ret2 To: CC: , References: <20210210072409.60587-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <44fad17d-7f40-3b82-0015-37a951ecb0f9@huawei.com> Date: Mon, 8 Mar 2021 18:36:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210210072409.60587-1-linmiaohe@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.232] X-CFilter-Loop: Reflected X-Stat-Signature: of1q9y45pfisnkjugsjm5igfkduj4nfm X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4357140001DE Received-SPF: none (huawei.com>: No applicable sender policy available) receiver=imf17; identity=mailfrom; envelope-from=""; helo=szxga05-in.huawei.com; client-ip=45.249.212.191 X-HE-DKIM-Result: none/none X-HE-Tag: 1615199812-327390 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi: On 2021/2/10 15:24, Miaohe Lin wrote: > There is no need to use a new local variable ret2 to get the return value > of handle_userfault(). Use ret directly to make code more succinct. > > Signed-off-by: Miaohe Lin friendly ping in case it's forgotten. :) > --- > mm/huge_memory.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 395c75111d33..caf552834dbb 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -624,14 +624,12 @@ static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf, > > /* Deliver the page fault to userland */ > if (userfaultfd_missing(vma)) { > - vm_fault_t ret2; > - > spin_unlock(vmf->ptl); > put_page(page); > pte_free(vma->vm_mm, pgtable); > - ret2 = handle_userfault(vmf, VM_UFFD_MISSING); > - VM_BUG_ON(ret2 & VM_FAULT_FALLBACK); > - return ret2; > + ret = handle_userfault(vmf, VM_UFFD_MISSING); > + VM_BUG_ON(ret & VM_FAULT_FALLBACK); > + return ret; > } > > entry = mk_huge_pmd(page, vma->vm_page_prot); >