From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D26C77B78 for ; Wed, 26 Apr 2023 15:04:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44D8E6B00E5; Wed, 26 Apr 2023 11:04:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FBCA6B00E6; Wed, 26 Apr 2023 11:04:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29CE56B00E7; Wed, 26 Apr 2023 11:04:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 17DB46B00E5 for ; Wed, 26 Apr 2023 11:04:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CC9511A02FD for ; Wed, 26 Apr 2023 15:04:54 +0000 (UTC) X-FDA: 80723864508.12.73259D3 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf26.hostedemail.com (Postfix) with ESMTP id 20CCE14002B for ; Wed, 26 Apr 2023 15:04:51 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gfD6s8wJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JZP2tJxj; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682521492; a=rsa-sha256; cv=none; b=DrGrtlK3XWYo3XlZrtqIqNUzT2t7Jn3J5kdoJ34WAOE+vubcM+QtXNGh/iMSBBmjGhsRTX jWa0rk1lU5nZmmKIzVObE+b54bHsHg4wT9w21HNz0YdxJujc0J9UIdCcE1M0MeeaApqZUK Ik8eCghZ71tbvvxKBKsB2B7Vt4eftXY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gfD6s8wJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=JZP2tJxj; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682521492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ran8tF+5YdxHQWbx/a5kNj8I7fUsKN7ujlcec/eb9Uc=; b=cuG4AME1kFpPRQFFmaO1sUoGT5R0/jYjNQN2AGsu2Wa+Shrs8ljqWvPr/b7pd9SWtolb/q dwBISvTGMOh1VodgIC+lRPfVHFgwO5be1TIhuXCHeKpxc1UcomKg8ozrh+lhLm5fN3gwL2 exiyYoay7Oa9Zm1PPW9AXWLnL3wuj0w= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 621041FDD2; Wed, 26 Apr 2023 15:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1682521490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ran8tF+5YdxHQWbx/a5kNj8I7fUsKN7ujlcec/eb9Uc=; b=gfD6s8wJu7G73s2FAfefxkP92wl2/oRlyHOxoMDqBACvRHxPVXHKVvv2eBnYh+rY+4OmvX jAmcRLpVXC40ohDY9gXZdN+5XqeXsaOJngbF4CHeA9cYs6yC/o0/7srhzbEP2xV4q7cttb Q4CVDkVvYI2z58pqwc8MPoonyxQnFkI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1682521490; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ran8tF+5YdxHQWbx/a5kNj8I7fUsKN7ujlcec/eb9Uc=; b=JZP2tJxjFXOmgTvjg3n8TpZHbTiIIECcpSIqGXfMnK1Wtrv+okh+V8bX93K0g488LXKYLg MyU9jbtj3czKC3Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3268513421; Wed, 26 Apr 2023 15:04:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5a1qC5I9SWRSdgAAMHmgww (envelope-from ); Wed, 26 Apr 2023 15:04:50 +0000 Message-ID: <44f2df1a-ace4-0c44-166f-4f2fef49e0c1@suse.cz> Date: Wed, 26 Apr 2023 17:04:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v7 00/13] fold per-CPU vmstats remotely To: Marcelo Tosatti , Michal Hocko Cc: Frederic Weisbecker , Andrew Morton , Christoph Lameter , Aaron Tomlin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Russell King , Huacai Chen , Heiko Carstens , x86@kernel.org References: <20230320180332.102837832@redhat.com> <20230418150200.027528c155853fea8e4f58b2@linux-foundation.org> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 20CCE14002B X-Rspamd-Server: rspam01 X-Stat-Signature: 79sf58pbfbdnuq46eeqio57ipdca5psa X-HE-Tag: 1682521491-462620 X-HE-Meta: U2FsdGVkX1+FvSHC9ZFUcva7k6GtQHbtXbvJJzaD+pwjW7tJv3UHxANoSvjzOU2peNKFFexZKiDPsd7FPCENYER2o8ffvZCwLtQfmqshdga7Tnj+VjrtOlBFZuLFlR4Qo4guSKXLepzFDVlPa+1Jh9+yBVn4TYyEWN/irquIqzvlw7cNyWG4QmeKA3H2TM9zjcyDzWC1js5HxkAqoLYSPwRQsKVZck9Aw6Ro3Phu0jRONq01hUfjwCsuT8sMi5SQKL7Up+OTq/Z3kWa0JVyJcHBYQT5gCrFNIHh4w1CFk/bW6pfGIsGZGbHKInS17jNPgOncrFJUGONIIbL4g9yuIKuZRzlFRGssE01WKx6N9xaenVGAfm++Kri9ul9jdKm0Ug8FAD5CEspsHCMLqL3lhYwcAEJBakVQ/zk1Nzj+TY5xCghuRXzLRBaUaPQM4tuvwc/aAEs/R8ILxK8LmLnkZ9V24W5EcCSWVZRy2U7BSYmf6BGeECBQZ2RAgY0tV1T4xcNXymPsatAhBjeT6Nb9jEb/aHPIo5YvS0TrO0+Y1q93ibg59Z5VVu0wra7rbRYNvp8dCzHKygeBbyRp/BFXXcVQKoCBk8lVWtn7cu02MiBWuD3CELNq6SdocKY9odcMruRyIkqF2HuUlegwt30x1FMwr+xmWIepjjOy8QcWJ5cfS7wSod0QkNixZq451mDQZoXpA9Jny6+efwJelGKdIcIx6WnQv0CC5rfS073Fmy4ofZCgIRj2B5AV21EmXdXYNq1SjId1GvuhMrGmwJ2xU2CcVkpMgF9Dq5G5GuwrJcbeRCwjS55n9oHCIrUuHxzWQVP2Mvft0e8CFLSHkhkcWkwmVF9y/RBL1xbwuoouG7pn1iGMxc4Wo2gQhl0L136xPEKadz6WCt+dD46XP9kHniPS1QLIrZm3cMPfMP/PzzwQwwHWlTH4lFjCJ5rGDs9pKxDm7mVzmmOqGHWxmpS LywIPhzp jMCzZnCvuXVRT4p+LZhFi/3bcw1g1RrYHvFujypot3lmsCXES44+pbRaNQ5KvGhIdSVc4D7EJnICj+NKkTSc+zQGW9MlqzZ4BYYPkNh0zrjV9wX7iyY7YnI5dtnoU1p/46makPTUeRazou6caolHXa5r222P7tJeScv5zKclO+qbDfuBxSk8ARWl9dr8WntwwRg5tc1mEosy7R/0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/20/23 15:45, Marcelo Tosatti wrote: > Perhaps the complexity should be judged for individual cases > of interruptions, and if a given interruption-free conversion > is seen as too complex, then a "disable feature which makes use of per-CPU > caches" style solution can be made (and then userspace has to > explicitly request for that per-CPU feature to be disabled). > > But i don't see that this patchset introduces unmanageable complexity, > neither: > > 01b44456a7aa7c3b24fa9db7d1714b208b8ef3d8 mm/page_alloc: replace local_lock with normal spinlock > 4b23a68f953628eb4e4b7fe1294ebf93d4b8ceee mm/page_alloc: protect PCP lists with a spinlock Well that one is a bit different, as there was one kind of lock replaced with other kind of lock, the lock is uncontended unless there's remote flushes happening so it's not causing extra overhead for the fast paths, and later even the irq disabling was removed, which should even improve things. But this patchset is turning all vmstat counter increments a cmpxchg.