From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1E8C83013 for ; Wed, 2 Jul 2025 09:11:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B46C6B008A; Wed, 2 Jul 2025 05:11:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 469C36B0099; Wed, 2 Jul 2025 05:11:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32C296B00DC; Wed, 2 Jul 2025 05:11:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1EAA06B008A for ; Wed, 2 Jul 2025 05:11:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E5BD5C05F0 for ; Wed, 2 Jul 2025 09:11:58 +0000 (UTC) X-FDA: 83618757516.13.39AB9A6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 8CEB84000B for ; Wed, 2 Jul 2025 09:11:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jH+rua4f; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751447516; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=62Zzpb2RUsi5oBTd+24Itzeqz/d4TrBiY7iQswDRQGE=; b=8OKKOgczFRqIDa9QD9XI5ekxs8g29MfvdoB6PkT35yebSowZWcFdic0UKNEALmHfg8utzJ aBH6K9emeeqMqHziduBsrGSzqK764cVkUBOgGFDsEJmnfqhSqz//1RR+ooxhm31uuVhQs7 DdCW6/g05cqh1IgoWmzA14futwfXMYg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jH+rua4f; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751447516; a=rsa-sha256; cv=none; b=6pFJ1JuhyhBy7PnwWVvbBBzuxy7/zp+wW4E+cnpj6I5KbgtxKmQ7/L+18GkNnjCQ7Iwux7 zJLqqbbySiTY6ccRYnzFWSR8oBNCUGEKkFq6/yEuToyqy+xMWr1Cl2eaj7m0vJfAQc6/Dy RSr6PywpvQQ+DSBBYohTBLxUaTZxyVc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751447515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=62Zzpb2RUsi5oBTd+24Itzeqz/d4TrBiY7iQswDRQGE=; b=jH+rua4fV4JM4K9ydT9xH6vQDTQaSWuwNWBKmSRGxUoOJ+afE/JPENBgpG298Cl3yC1Jmn S1jCS2v4QTYytk57MI5F3V8GZqvkpcFpfrqGPINB7UZv+uQ9fgaDle2Y6AJJkv9bHqq/JO u9DeYoGHoi9CbYbMXnDR1LBvjRZx7TQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-AkDDzlw-PEmDtcE-yA1JEg-1; Wed, 02 Jul 2025 05:11:54 -0400 X-MC-Unique: AkDDzlw-PEmDtcE-yA1JEg-1 X-Mimecast-MFC-AGG-ID: AkDDzlw-PEmDtcE-yA1JEg_1751447514 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450eaae2934so30429705e9.2 for ; Wed, 02 Jul 2025 02:11:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751447513; x=1752052313; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=62Zzpb2RUsi5oBTd+24Itzeqz/d4TrBiY7iQswDRQGE=; b=s5pBAKkOCyYs82hWTCraZDxgkFSZnHJb26rroInHlaUFuzpGk/iiT0nWvlF6C8D0Wb 3lYFrn35pkTwCoCIk6/AIxH4fHOwXYu89h9ldstUb7VVMfdu4BrTC5DvXBNw/wcbl34O in4PnqwXnHQlvlt7cOLH0a4CE9g9kjMAj+nvYg8so9eNJKJz/+9arCgVlM3xALKk5+zZ RPVrHqFsCfq3IDhWbDltBt7FlBbp7Zo0oQoIDzFUtzwdpmxLBPZ0tRomOuukHn49EnMv 7ywIoLwY1eVDdvvEJmr8s7s4h+VeWQGhxzPVXmBGZv2ady98lgA7ed5DrSkGC3z1IwrZ wBaw== X-Forwarded-Encrypted: i=1; AJvYcCW4vlEJK7zugeWVBGvji7mwsxIREDG86psY9WlPAsDpkZ82bm/MYJcKViYImAFKUNwLZrl91bbGGw==@kvack.org X-Gm-Message-State: AOJu0Yyg1GUtmC5z7y2aD9vKTwTFQJqYFT3lbz449x8j4+9EuEklmHLa QIwtWVVrY8cOJ4gvYGAGoeTYMbmzqbe8NDG2/cmlh37dQNrrycIAQHQfsukaL6YOC+8+i7zIuYc n2g0/shSh/TZZEw/f593/N1P3n9LI2oS9VrhvNukmfW7Sru4+jOI0 X-Gm-Gg: ASbGncvKLvCrNWtlM07oHw4zZraZtJTCODMo68nR00Yi7ve6JoAADB913iJcTfoIQnY SR00vYvMF+zkV2qEIaJS6ojb2V1/Xs+pMt4vliWFKQOK+i99aG2YBGr5hD1XCiKi3dGJXUewO6k VF+gOJd844cZNMIgGGz1YbsYY8A+iiotoqv4iGWhurzEwqdfQozY2euaE22zJAw/xgCLrzV95Dt 6r+MryIY//mytRGbWVClpsct9KURsO0pwJV0Lvz4tgWd1AiyQUuNslon079LBZIbHQdxReXoNlv Bsco1KW0wmA0aI1fi86PTKra6T+quzPIlP3ZOC7iWW2+WqDRf3CGBho= X-Received: by 2002:a05:600c:8412:b0:441:d437:e3b8 with SMTP id 5b1f17b1804b1-454a3725754mr21091895e9.23.1751447513573; Wed, 02 Jul 2025 02:11:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzP2JHnRi6kN5iGc6AiXQdQMlXdPAAul3ZbqMJrF9Yf88smOIZtQVd53BzFQnxqXkkHBfhCQ== X-Received: by 2002:a05:600c:8412:b0:441:d437:e3b8 with SMTP id 5b1f17b1804b1-454a3725754mr21091655e9.23.1751447513151; Wed, 02 Jul 2025 02:11:53 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538233c05csm222619535e9.5.2025.07.02.02.11.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 02:11:52 -0700 (PDT) Message-ID: <44ecd672-2a74-4efa-a829-37768b75d401@redhat.com> Date: Wed, 2 Jul 2025 11:11:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] mm: split folio_pte_batch() into folio_pte_batch() and folio_pte_batch_ext() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-4-david@redhat.com> <17777b93-41f0-4943-963f-0330489b01bc@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6vw25ZJgQKJx_1Kw8Pj3CRTtrEJLp9zA0PNl6YvB-MM_1751447514 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8CEB84000B X-Stat-Signature: tudinmxjgptgaa3zakkruodkubp4p7hp X-HE-Tag: 1751447516-44127 X-HE-Meta: U2FsdGVkX19NUWKHuybtUxgMh7ZjiDtIn+kd44KCWl1YAUYoF3IrINmGZ3rWND81fHGfiI8koab3mj144Y9TjAJHP2eZpIee0iDYY739ZMCRxszBeeygvQ/unxrmtvspfwvbTnGyyHTxajF9NHk5lSLrzOIxvkqY+aVVRB90xjeOYp4lsQ2czGKSGpwpc7CcbDe9X5uPuKNnQfRIbnJqPJ0UyFkZlgb2XHP5TQK1rcF7PrKz3eMgvbbz1xRu6ag6yBLADUqG8WWlc2Po6qcJvZL1NPPGxrD1L/5S6iVvLKFUwbvgSI1UWcFtdCtzwt6Xmfv59cbNaehtAcjwVP6AK7Zer2tgFouxeXhzYZsiReJ3MD4+NZw9ABBcPZ9+NnxteLMr72QXz0SIM7PzimoqBXOEE6NRrdJS0Sjvqlayr54FYiU9+02y9yLYZTwxVn8F6hS3+NZ2QTvTv8qh0O+B3veMUJnztnTnwTcw1LeDhUK5CGzfhAn6lig8maxPvhz8gvIoV4Rnj8HU2vTU1QtFS0QiPcpgKWifPvkOb1i48VefjarEdZFchWz++PSV8+C+TH4H86Dbl4bJh7oonnGCcJwhA0K1nGvnf8rW/NyLOuDnlazdgsTT88uO8Fy7iD1dEWkbq86k7f26EWVV1fZME2/S25kZPesYxjEEr1IUTge1KqyvYN6p3+Q8L1TCeStp60hyrB2zZhHwuo/dehsBsSljmBPNQ6Y0ZxVLh2S7ZLpV40qbDxmsIXyctqJuETyXCUz/4rZfOcHJ9KmFHnTKC9O/KppuWFS57Ps3GiqLc5R1Gny50pbK38ueY/Vt6TVevhzvHfRT2nmEYnWp5WvhX1dpXzMtMRKj9nMJTrllMeK5moUCKgBt/RYfBa7UUy3qZKGdy5rwtLAcLH5z6wtOrWf4BhXKS3NWKzp4MkQzOzo1eiiRiRG1vfiAcP0pHB4zxilz42tvYCwW4DIGMaA vjkX8q0t GKDCzHKiOFgyTPecEQpJmmAjv/V2AZl8xEYXo0S7LewHtAoGXhF4/yWlHV07N3MwvEAaPlBFtc1I6rAqBAkcXw3nMmRSieDp2KRueO0fbS95iQLkgZzYHfsGbBI7iC/wfJ9Xa3qsbkXMElcekdbzlhrljSWyVHmcBAybxJ/c3SUMtFyNHrrX5AMbpOYdRt9KTedATDfYfTYB1KUnCn1uylcDNa3UHkN1gPq0CQXK1+j5iKijdFuYvSQeDuOsxJGu4I9YCICYc/tAD/+M33YX3T+x0jaTz7uHi/bsYIsL2o0tPRfMVGTUNov22TS/hcq4/MSFRNiLMJF+CH1vPLGNtpZSRYmPR+tmo4EqhLwu0DGPb18y+v2w02k5xXSxszOUlSteKd7BoUUkz4rvjsPvwSQGO6eiVDt+jxFvzGdnokE/cBEVy4qHsHvu0uK8TPmcJINHNI2cPkH/vBWiADzhGqyygT30Bv/FBXJgE90NLSnQ0K3zCqU9PL9afwVqzRGVEDLuBCgTwR3DiWxPmjkWe2hZKPazVvILFzDrVjEGPvCtdkDw/dEGc+kk3fg3AYbjR/yBCjNdh4vpW5O8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 11:07, Oscar Salvador wrote: > On Wed, Jul 02, 2025 at 11:05:17AM +0200, David Hildenbrand wrote: >> Not necessarily inlined into the body (there might still be a function call, >> depending on what the compiler decides), but inlined into the object file >> and optimized by propagating constants. > > I see. > >>> With this change, a single function, folio_pte_batch(), identical to folio_pte_batch_ext >>> but without the runtime checks for those arguments will be created (folio_pte_batch()), >>> and so the users of it won't have it inlined in their body ? >> >> Right. We have a single folio_pte_batch() that is optimized by propagating >> all constants. Instead of having one per object file, we have a single >> shared one. > > Alright, clear to me now, thanks for claryfing ;-)! Will clarify that in the patch description, thanks! -- Cheers, David / dhildenb