From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3C7C25B7C for ; Tue, 28 May 2024 15:14:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 869E56B00A7; Tue, 28 May 2024 11:14:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81A116B00A8; Tue, 28 May 2024 11:14:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BA996B00A9; Tue, 28 May 2024 11:14:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4BE7F6B00A7 for ; Tue, 28 May 2024 11:14:49 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E224CA060D for ; Tue, 28 May 2024 15:14:48 +0000 (UTC) X-FDA: 82168151856.17.3483750 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf17.hostedemail.com (Postfix) with ESMTP id E6CA440007 for ; Tue, 28 May 2024 15:14:45 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=e9hGPDfe; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716909286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FCjVMHRXb8BezxbTo5yeQ6t2ZNUwpkQLZ3J8zSlmIgU=; b=lCzAP8c97h5eCMr+v49rNrmqizYHGcP1CykhvN1k3MFTrI5gw0+l5cxOxkIWdNdhGGyMm7 KcFMOciIwyfqBuHDMbBkLKM2dcZLSnAUSQ50Vm35iuo9xDLTv3SVAWH2Q8Nfav3Szs60s/ KzQKfrH/qSND5CfufSdMAdLqL86S4Ps= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=e9hGPDfe; spf=pass (imf17.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716909286; a=rsa-sha256; cv=none; b=VS2acdoad1QrOaGpp6JpBxGmE8bpR0elwhMBQfUDkEl7gCmEHKbnMyM26SFrA+CtWgIJTI WHLDADWTQcg8bSK/axHXjKU8g3aHKCS0Ssu7d6uC30uY1aa1luPmSz5O7QdMebhYINJ3/p v2d4qWtZ3+/e36MnyDSvneO0x2FP0WY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716909287; x=1748445287; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Bxs4SPAtnH5tl5Wkqd1BAJet+5qrsAR5q00v/b5luXE=; b=e9hGPDfeqXjWlS4ELChdKMNt1aplYQVGAixtVbQ616dbnhYfzbdAbcs5 U4ag+nDhtKTQxMre6sJ2C30gJFKulJVSN3fUE1VzYRBmZLcPUron1m2Uc +I7bLnaEYJUh9P9NuVmD9uWsVIUgxMP0WOXvAhNexuwEhkSMJFTMs1NQu IlMk4NhckU0au53C2lmLKUUAEdGrMaFiazPHuK17LW3j0dd9VqnO0CSwa J+MlU9sm+xDQAjUWE30dUlWFY+Wttia2ydIZzPrsYun+MZn2nipyG3goh O6v6pwoqh+PBLb2hbyNFabj/sii0vF4+h/q7sPI0uWMQETefu3jyYDkVP g==; X-CSE-ConnectionGUID: Mofk+DBVQjymqPG8aBqU6g== X-CSE-MsgGUID: Bg2xxCrfSA6or6NU+sA+bw== X-IronPort-AV: E=McAfee;i="6600,9927,11085"; a="13110075" X-IronPort-AV: E=Sophos;i="6.08,195,1712646000"; d="scan'208";a="13110075" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2024 08:14:45 -0700 X-CSE-ConnectionGUID: 8XJi24R7RTW7+BOyHYuJIg== X-CSE-MsgGUID: MexkEbFMTqyUkQD74gGgRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,195,1712646000"; d="scan'208";a="65948911" Received: from ldmartin-desk2.corp.intel.com (HELO [10.125.110.248]) ([10.125.110.248]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2024 08:14:43 -0700 Message-ID: <44e4f2fd-e76e-445d-b618-17a6ec692812@intel.com> Date: Tue, 28 May 2024 08:14:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 00/12] LUF(Lazy Unmap Flush) reducing tlb numbers over 90% To: "Huang, Ying" , Byungchul Park Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com References: <20240510065206.76078-1-byungchul@sk.com> <982317c0-7faa-45f0-82a1-29978c3c9f4d@intel.com> <20240527015732.GA61604@system.software.com> <8734q46jc8.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <8734q46jc8.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E6CA440007 X-Stat-Signature: ouyqmf5f85r9mjy4bbaa733b5cj7eaas X-HE-Tag: 1716909285-425423 X-HE-Meta: U2FsdGVkX1+dwFQRZxJgt+9pyEdpJUtZEnu+87+x0ZQLliDwSWSq4L4cZkEJyCcg4h90l15+dW4e76JBS1+0J5l1YvXL+HTZKAupk+EkYzLlk5KdGLNO5kBOCJY2FydEaMvEvAmt09i006IqHnB4O1UifzWpt7PKugQCMeVBa0c0KkvCbmfV7QNdm4rsl+MOtxiPmihDdIoxfRge4Io238wuNyRVYZWcjWItNTC8/dvE9NU1iqTZDeu95R/9YveIVcceNXsRb0cUB14R0Uoi2S08jHk987oiT/xvDTCKcuH326xdnClN4RK1TMuq7sONDgWA6I8pIwXG8ecLWaUjDxxeOpR6RU4JjqRorXdzctHRxcuaruFd8wCvQyMD1eFfiaONqJFLd18iSMRUfj3DCn9HDHsbDVwDkaFJg8HU9/m8sbmAQJfOc4KaH62GbV69o36zawvPvlDk+/EBiLodWHfyViTChifAF6kkKrmmYQvI22S5DCj5OYFM//0Y7vxaMwNrCa91U32lmRcmP1g50WeAs53rwhse97AT5SJuG3+DCse2HzwyEXQsaUiXMbRcmPt9UjVtxcQAVq4j5BYGie30hAyF7sQ06DAkyntrvwOSnFO1yrhpPOab2MC0YPrPaArSa5Y+F9h2l6deeiw1sQoFCkVJptvlQuvBVvtntt58km/ImjCF4cT5Wa5cU85ewlsexL3F3uhcljK2XUWeBtB5xRnnP3aPYF9yYfIptnWA4Yov5D5d1ncIp+RZ5HInEPa/bojQMNTXcnrRDxLEd6AIwucv3IUNUJ52c9UbULwbnLkbHXfnZCxpe4PR1oj9YyjaL+ddlfKSuoVuL93W2ZU6XXskS2sz1nhXICCL26cj9HjBPkPZPUTmNoEVle+xvhyJ8xRb0w0Gqsfb3FRQWq9LSuRWalYI8Pynosj4M+MsRSbXR9j3zU7tVvhNjD2YMHtmeVwRMao3J/Gf6x5 DeUwHhSa uSzSbbOehvR+x0jkrPGaZHTviUtdJRRKZT4gyyEvrXdq5gI615gAt+sPiKpOlyJNSgqkjivIWGCWaBl4fimUyg5tAizPT2wqStkFnDJt0y00uNirXzVE/GuKJY5iomQxUiUfU93U53mygTsXAFhUV1B5EjguFtnyo4S5JIlAfjH//Sv1K5dD60Kp69w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/26/24 20:10, Huang, Ying wrote: >> Thank you for the pointing out. I will fix it too by introducing a new >> flag in inode or something to make LUF aware if updating the file has >> been tried so that LUF can give up and flush right away in the case. >> >> Plus, I will add another give-up at code changing the permission of vma >> to writable. > I guess that you need a framework similar as > "flush_tlb_batched_pending()" to deal with interaction with other TLB > related operations. Where "other TLB related operations" includes both things that traditionally invalidate TLBs (like going Present 1=>0) and things like fault-in that go Present 0=>1 that can result in TLB population. It's actually a really crummy problem to solve. We don't have _any_ machinery to say, "Hey, you know that PTE you wanted to install? There was something there before you and we haven't flushed it yet. Can you be a doll and do a flush before _populating_ that PTE?" To solve it generically, I suspect you'll need some kind of special non-present PTE to say: There _was_ a PTE here that wasn't flushed. Sure, you can add gunk to the VMA to track when this happens. But that'll penalize anyone populating a PTE anywhere in the VMA at least once. If there were other threads faulting in pages to the same VMA, they'll just end up doing the flush that LUF tried to avoid in the first place.