From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDBAC83F05 for ; Fri, 4 Jul 2025 10:42:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7D4656B018B; Fri, 4 Jul 2025 06:42:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7839F6B018C; Fri, 4 Jul 2025 06:42:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64BB46B018D; Fri, 4 Jul 2025 06:42:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4E7386B018B for ; Fri, 4 Jul 2025 06:42:28 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0796358660 for ; Fri, 4 Jul 2025 10:42:28 +0000 (UTC) X-FDA: 83626243176.20.6DEDED9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 658531C0015 for ; Fri, 4 Jul 2025 10:42:25 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=evKhg9eY; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751625745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pDYDx7CpjYf5Q8KMXZMdVSh7J69mEM1VNNLfTxrJ8A0=; b=TJWJpYjQA43rva0y0/s59lsAW3Rog8j1dEjufYByjzhqql2hHIpN02QoEO6gdL9zTLxkdy kPHB5dZ3nRjx+wyypp09Z3YsAuLNWAuhebcNAIpSM3Jn8NTC3gCppeOE9aJ3ZHRPH013b0 sCPDrHakgLrYkikDLoD9OWGntI/9PGY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=evKhg9eY; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751625745; a=rsa-sha256; cv=none; b=XjSDzAd0q7gqPaeWYO1Jzp4qRHTbR9TAre9DmUJAaWuJ7ZlBH32aPNFq9nBZrOMdIIU9AP 8RIEZOPfYt1O2TMTR6Kzvh2xS1n6tWrRkKgfE8h5tkiX7H74bRDHi9wgk7fkzNbYpfFc4y W6rm53e+M6Qb2OQ5lo9QPSX4P8jQm74= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751625744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pDYDx7CpjYf5Q8KMXZMdVSh7J69mEM1VNNLfTxrJ8A0=; b=evKhg9eYzlg8S/BZdfieix33+G2OgTLheJdbCxof3/9Jw1mEVD17lmgm+AUCbRBEiQ1cmx n3A2anhS3xM37dDzZcbz5Fe5fGaedSPoH5OvXOKa/S8Tsj0a7FNAN6z5+D+iFpFSAE1/Ox 33rha/zQiac5FqjNs2A1XX1APPMAobY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-8NYSCcSINPKKdfOkq6kqmg-1; Fri, 04 Jul 2025 06:42:23 -0400 X-MC-Unique: 8NYSCcSINPKKdfOkq6kqmg-1 X-Mimecast-MFC-AGG-ID: 8NYSCcSINPKKdfOkq6kqmg_1751625740 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a4fabcafecso388496f8f.0 for ; Fri, 04 Jul 2025 03:42:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751625740; x=1752230540; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pDYDx7CpjYf5Q8KMXZMdVSh7J69mEM1VNNLfTxrJ8A0=; b=mwZ0REUT2IzBh8VwarqBH6XyN4svfo5iaNSRrV8rU0b/J10FrS1ST8cJQ8bgX4QgYF L2Z5XD1I8JEKXZPrv8zQbHNBQNw+vnY5RiALn3dCqzJsm/ADNVRR7pGI5SLm6G6luMfU faWlChMt2UC9Rwk1NN90Vl0LmPY0ZSVNgWv11GEUtaTX+2gQzzLKNMfGxOUDxeupWv35 9Jz2KTyTABxGN1KhFJoeOmFqVJ0Phhswbz/0rIg05E4QUM/IyrxxbnPZ+6xRQlW3GPzV WEJuWW8N81wfhbXHXNdBLDj7LQv+w+ZeezvShIy+z2u53T/Rg8Sk5ufxNDe963yGMs14 dI1Q== X-Gm-Message-State: AOJu0YxHn2L6cSW4GRRZqNkqMfxPJDzYKqv+GS5ulpphC7v9Ml0wZ20s 6zp0wduCZx2tMC1QTBjFc8KzHu2w6m8qWKFpzbPvVI4QZ9Iiwe7oQ6Xt8/7fGYTeAcQQXR4rNkf 6CCnDhGnjTtBmXtWFtTKB7kI0pAenyqtPl/+6huwX0xUB2goidqVO X-Gm-Gg: ASbGnctWkOt67lnfV7KwNk8Xm94rzicUTYs0sluPGJ9rRQlx/FD4UfPGTQP4pdxFB5f yfh3yGxG1k5AaO9SE++yWxhcZUxazrUVqJvOMwLWwM0Zx0uX/RvuFY6RWX8s4CiDFoqU/6WinQn 2pJDUnYDQMD+fXCGKafzkSpJKBvfv2SQuek6SEjQeljELK/AWKyf20nI4EnkKg7x9hy5gZuAfv6 Jm37wnaq8V4pxhIz1Oj85HKlIVHpFfcF0gh67n4XKuP7lmlLM3vVY3qxrpnIux3hgagbqvoZi4L o9olAGM4xsMndGby56IiHjap71kCBEvvvnF9Nl93q7JkpDBpSJakBGol0XMuqtlWyNmy+wm9bkG JvtVPUBuTo4kSYvPKWzEhWN7gmIy3B10VT6lp/kK2Y3lNFYU= X-Received: by 2002:a5d:5d81:0:b0:3a4:edf5:b942 with SMTP id ffacd0b85a97d-3b4966048a9mr1541927f8f.57.1751625740427; Fri, 04 Jul 2025 03:42:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGI62JyhkVkZCDi3vTcH6ZUUy5ZMEU30PKZLPD9SUhqXYP1UC5bvM6fEyvquBWJFnSmFvVdtg== X-Received: by 2002:a5d:5d81:0:b0:3a4:edf5:b942 with SMTP id ffacd0b85a97d-3b4966048a9mr1541903f8f.57.1751625739929; Fri, 04 Jul 2025 03:42:19 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47225a755sm2159792f8f.78.2025.07.04.03.42.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 03:42:19 -0700 (PDT) Message-ID: <44d462b0-b72e-4eb5-a5ae-07319f6a6e80@redhat.com> Date: Fri, 4 Jul 2025 12:42:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 mm-hotfixes] mm/zsmalloc: do not pass __GFP_MOVABLE if CONFIG_COMPACTION=n To: Harry Yoo , akpm@linux-foundation.org, Minchan Kim , Sergey Senozhatsky Cc: linux-mm@kvack.org, stable@vger.kernel.org References: <20250704103053.6913-1-harry.yoo@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250704103053.6913-1-harry.yoo@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hMGsoH7LByjm_RmP-pjbZ9NhIavl1lS2BqxFsS_a458_1751625740 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 658531C0015 X-Stat-Signature: fi4zjyx7u9k8796cxna3thgmbtgrceyr X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1751625745-355813 X-HE-Meta: U2FsdGVkX1+cKK+nRk8Qfp5Qs3ztw2XtL3ENJJcJ0m3R2ImRKGdLa4tIWhczLJMG81Cjo0Mk4pOwVg6kHl4Ls8MgBo+c+DFzilMTjg4vIBZfme0guuaHXppgen60ybmn6U6hvu5lPp+QMY6mF9TXt0p/ebGrvRjnm4dwKAmGe85dKQbqman8cE0KB2D4PtRIbMmqsaDwTCTeLd69vr/W38HNMfK5tiFmJV5rUGmq9LOGRGPO7jht9BzBLMjUWTunvyucvLPRtjgUaK37en+2FMFfRuty1etMUckB70q3iTVpwjFOF3C/tT6G/dLbEBqrEz77ltwTP2xByOuow7UHLle/3oEx+Q3N3DlarER68Yr60SHlJZ/9rJ5et7R9yYpn9JjeQMv86bPKBwH6xuduxHXusyenGYO5SRTv5S48k9kEPC/v/MZeTXXgldxdR05dQ7U0PsguasEd/8YtZ7t4UfS0Y/jfVDOth/120SNiYEQKsNzefjfcIaZ47LGq6ssTrRY9pNXrk/pquCgvYtxd0IeQf/AB+Jot5W41OK+Slw5Mfg6Jd9OjbR3mD9baRTNaeuMBZy9MSV3PPU5DDsMt007Ov4PDDUIebUIyjMqJs38G65IWIzJaL/kkFRYk51UM/EQXPWHMbdGSXesAaZYs/j3wDvCawMMB8aJZatKhq/+/JTnv7ysC+p69xd0DKSetr5JyM+wpARtTze3R78VWfo84By9wJaS94pprOvZMAp9R1VR1WnLKmoo0cigRKrngwgWaU7s4Oe2nLHf+CKM9Q9LAt3Z105Dsh6U/xxaWFS66/MKBNZ6b/T20bBLWhB22P+dcM4ZEyLVV9+BMPByoIFMn8UOlc8eyK31ktsIyC9iNOuGYd3zbCH5dQj3TTJUoumM7xfhy923jGVv095Yg0mP9sCGTc1Lbu35ffDUqI9ncIFZkiFj9eRsWwu8YaLRK8ZB1GQXsOnw2V4efvPp W+k+ec8a UTcyWcHHDw7HZNPsEqRyUUw5tT1gjggSYUuu3/uAPQUMqszzHgPbaRQvBvpLf3aaq5/Py1iJG7sAqyngTM5pgL/SpuMLczA5IyBxBCnpx1Vxhnv8boyQXdxoVIRrD8+4S412tK2kWqfMzOAM+hrHU+gjkHzWAT/jfx3ZpKqECWzYY2hdODA1z9du/1nOX/PxNRqIGT6H95DHtsUBvJrquV3Fj428/vtabvjc4J9YXtyE6/mrPzpCgv0KrMqMsskARuqDKRa8ujE2HABcj85P5ryw6TUw/RS8ctd+hnUmatblMeopytJqqECS32HHzJ3LoQgUgDLyZ9LwY6PKisoMn44SvosWqbOw2K8UkXdrfScwm3kfo7y5JWZuzvV7CxLX2DdWUM8Y1Alv+pMBaGuwuONn+wDLvTs7yO/0GKPBYqRWLq8nvOu34hT4B8CxJX7fi4dGXRRC019hQFSmsi8Yda6ctLXuAfCppypFBVMkrl1fkbuJo6Z6AgQbwJKgVOfk5eH/SAI1yuiEr/7XhtCPKWQeAoK++ASC85hZx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.07.25 12:30, Harry Yoo wrote: > Commit 48b4800a1c6a ("zsmalloc: page migration support") added support > for migrating zsmalloc pages using the movable_operations migration > framework. However, the commit did not take into account that zsmalloc > supports migration only when CONFIG_COMPACTION is enabled. > Tracing shows that zsmalloc was still passing the __GFP_MOVABLE flag > even when compaction is not supported. > > This can result in unmovable pages being allocated from movable page > blocks (even without stealing page blocks), ZONE_MOVABLE and CMA area. > > Clear the __GFP_MOVABLE flag when !IS_ENABLED(CONFIG_COMPACTION). > > Cc: stable@vger.kernel.org > Fixes: 48b4800a1c6a ("zsmalloc: page migration support") > Signed-off-by: Harry Yoo > --- > mm/zsmalloc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 999b513c7fdf..f3e2215f95eb 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1043,6 +1043,9 @@ static struct zspage *alloc_zspage(struct zs_pool *pool, > if (!zspage) > return NULL; > > + if (!IS_ENABLED(CONFIG_COMPACTION)) > + gfp &= ~__GFP_MOVABLE; > + > zspage->magic = ZSPAGE_MAGIC; > zspage->pool = pool; > zspage->class = class->index; IIUC, the real problem was exposed once zsmalloc allocation users started passing __GFP_MOVABLE. Probably zpool_malloc_support_movable() was used for determining that at some point. Acked-by: David Hildenbrand -- Cheers, David / dhildenb