From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3689C77B73 for ; Thu, 25 May 2023 01:29:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64527900003; Wed, 24 May 2023 21:29:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F4D0900002; Wed, 24 May 2023 21:29:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BCB6900003; Wed, 24 May 2023 21:29:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2F1BA900002 for ; Wed, 24 May 2023 21:29:06 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EF976AE04D for ; Thu, 25 May 2023 01:29:05 +0000 (UTC) X-FDA: 80827043850.19.5EF2F36 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf25.hostedemail.com (Postfix) with ESMTP id 7EDB3A000B for ; Thu, 25 May 2023 01:29:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684978144; a=rsa-sha256; cv=none; b=DElMov1kfPcErI2cqMghmqgOu0o1a8lSJFpjxXXjHaUSWHrbc1y7Jn8roGO/vzzsGBsOSM rOLrglGQUvtdvNUcob7ORep7/PK+S6EwtBl/anli2zPKCHDmL+0F3PgXYU+ZOQXJ2+vam5 vcSeGciaYTPM3sYzFZ2QVc4u59YCh2Y= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684978144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bhbq8qxqvbjXXtQktBOmHzgGJfqWXpVMbql3tn6KkUc=; b=oZvZGmV4CbAaj3LxobuGa8uXu6Vre6fSnmD6TEx6ELilrJJXYmZiwKKuqq+KMiVQHD1lxk D+tEb+vipqx0bQIXIcFRvHqNPsx7r8Wm2XBQav2SwAPzshUJeCXqCY/HJjMgPCVE8JMySg srtpRpNuphE2bRQjp8mfAeXQPim+4Ro= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QRVhW3d5GzqTPs; Thu, 25 May 2023 09:24:27 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 25 May 2023 09:28:57 +0800 Message-ID: <44ce007d-8049-1cc9-7e2e-4ccb51a2867d@huawei.com> Date: Thu, 25 May 2023 09:28:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] memblock: update numa node of memblk reserved type Content-Language: en-US To: Mike Rapoport CC: Anshuman Khandual , <20230519105321.333-1-ssawgyw@gmail.com>, Andrew Morton , , , , References: <20230523115708.195597-1-wangkefeng.wang@huawei.com> <03cdccc3-8b8a-d972-bbad-d60966e59ca9@arm.com> <4eb83d16-58ed-9f09-4308-f0f786580257@huawei.com> <20230524153344.GM4967@kernel.org> From: Kefeng Wang In-Reply-To: <20230524153344.GM4967@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7EDB3A000B X-Stat-Signature: hsw77hk9h6k61xjy8bj681ubs3dn11nf X-Rspam-User: X-HE-Tag: 1684978142-280856 X-HE-Meta: U2FsdGVkX18uZYRMrd6SDy4HAM1K31v6jC6M07uS7WFSwEgbvFiQVUc2AqYUmsvyiw3LaTiuWiqm82/fVYysA6xRVZXNxsWmdNypJGeeDtat8LYauJ++u91eA1EpEa1k0//f3Ao+hWpDDryyenocwB82SmhCNSpIMy1XfoMREy5pduCqjy9wdPx87sut3KDgI7rUzsbT3JEluEuOd+skvctVdyfdjVTNbJDHxirUoO7L++8xfMvb3F3DHwaiTSfyKLY8UecEG89d5qyKVpuMTyqNsBLWyBIuLIu9QIpJtK9H0uIkrX1mnv76VVHBtoA0zHIPFxD265AFirf0WTQaYAGdSWkI5+6tYPSqFhS2sJcw+F+iV8wioCsf65D5GlSXz962dB+toWVZc3VRZJKjTYh0VD/aq8ezICgjK0fECl5/yPrYKlYy2t/3ISsKuarKqgCnDW6XAviUCuPbv80fRoIQFhYAC+kZ9tsf5l7loaUN9qEqPYrR2zjfJNuXwMu4bgXtFiZ3yoCudN/tZlTNp8RoeMqpeh5wgMWLigd9lfBJ9FTFm+TUHTXhTKs0S+tQM3bAXNFMAircdyVbAtnkyAqvHJpUyhemhPKLCS4JFf8KDemuAcLsDL8Oc1KayUkGBxbboMoOxpyQ8iAhPgIOv8uVDGnaFfbkqFLrUlaNeARXbMrdntfm+bAqjnTGx8uZSbFlSxLqZqBt4oBvjWmY2ijw1L93X13PX0YEaQ9jdkDXjHGc7gWEdDOvWYO8FBXHQvKgpT0DVDemV78jm7yMM7lkO5EF0kt2kjL/SFUDyHPoIlzuSISLp0O6xAYBcefB0q1X+e/GsKRBA99g5Xxz9B3HmFqLN7KcjNpCfzwM2JAvmlm7Kx7ykGH46dG5LNg3ub2wi3W88+LcK6oMTJreCBaFo27aLljI3BWL42JR7DqLyxZnnxBy6Ohrol4gAU+PZkrIgEWUGEgjO2InaTz 6/w/EA/y AuJOoWuIKPdTwGJ1X+czqSR6Og6uWPsev0uWHoUPOqI/jJ4TocCgFFww/Ut/F/IRpXLIRC/wlx4t0fgqSVom7xhymqAwCRH52n12Ctm+yM0WyzuQoe8tEToppz+sIsywAQlg8lUI6jnYS3dzpFSADH4610QkEeHzEeA+4FOgJCF2bqWWfAZMorzHTdkT6msGHsVH4AQ3w/AgS3xg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/24 23:33, Mike Rapoport wrote: > On Wed, May 24, 2023 at 02:47:26PM +0800, Kefeng Wang wrote: >> >> On 2023/5/24 12:59, Anshuman Khandual wrote: >>> >>> >>> __memblock_dump_all() gets called only when memblock_debug is enabled. >>> This helper should be called directly inside memblock_dump_all() right >>> at the beginning, regardless of memblock_debug. >> >> This is my first though, but I found there are still many memblock_alloc and >> memblock_reserve after memblock_dump_all(), so I update it twice, >> >> 1) __memblock_dump_all() >> 2) memblock_debug_show() >> >> and without the above two interface, no one care about the reserved node >> info, so I put memblock_reserved_update_node into __memblock_dump_all(). > > We don't care about the reserved node info and __memblock_dump_all() > actually does not print node info for reserved regions unless somebody > explicitly sets the node id on a reserved memory. > > So instead of updating reserved memory node info I'd rather avoid printing > it in debugfs. Ok, will skip nid = MAX_NUMNODES in debug show diff --git a/mm/memblock.c b/mm/memblock.c index c5c80d9bcea3..e6033de1f76d 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2169,17 +2169,19 @@ static int memblock_debug_show(struct seq_file *m, void *private) { struct memblock_type *type = m->private; struct memblock_region *reg; - int i, j; + int i, j, nid; unsigned int count = ARRAY_SIZE(flagname); phys_addr_t end; for (i = 0; i < type->cnt; i++) { reg = &type->regions[i]; end = reg->base + reg->size - 1; + nid = memblock_get_region_node(reg); seq_printf(m, "%4d: ", i); seq_printf(m, "%pa..%pa ", ®->base, &end); - seq_printf(m, "%4d ", memblock_get_region_node(reg)); + if (nid != MAX_NUMNODES) + seq_printf(m, "%4d ", nid); if (reg->flags) { for (j = 0; j < count; j++) { if (reg->flags & (1U << j)) {