From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A2AC77B7C for ; Tue, 24 Jun 2025 08:30:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6AA16B0099; Tue, 24 Jun 2025 04:30:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B41326B009F; Tue, 24 Jun 2025 04:30:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A30276B00A0; Tue, 24 Jun 2025 04:30:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8F8D86B0099 for ; Tue, 24 Jun 2025 04:30:07 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2A9DEC1CB6 for ; Tue, 24 Jun 2025 08:30:07 +0000 (UTC) X-FDA: 83589621654.25.2A99E7A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 93F8EC0016 for ; Tue, 24 Jun 2025 08:30:04 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KJvOzjmh; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750753804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AyqJMvywObY4nRmPc+2PsXq0lHTsftC0w2wrECC4jPI=; b=LWXmThIZq8Xy8+GLuWhVXGRh+cQjRtwzjHEO1Mt5g6ThH1EwIiWidE8vzX7i3L1ORsd/6H TmJKq8KLxme1HVNsDdMeo8248NnyqSAgBp4xu0itstz7FS0BHYlr4X5z2S1CHAsmNIfZlz H+5BxrIuHqcDcprXIOgbB4DS79AQUGc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KJvOzjmh; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750753804; a=rsa-sha256; cv=none; b=m3M5cUNi/jujntBEbuFjo+YRj3anl5dGqoTs4NQXTQOX5XCyqugu3auIxuIm17yOsmKFZr DY4NkbJZ6FhN2bYjnK8wZQjNCetOLEsRMzGFQ3pLnCQ/g0Itz2L9AlXF2TGul8tenozkYK kQmywBop82SWAS1ps1yC4SknezmTngI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750753804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AyqJMvywObY4nRmPc+2PsXq0lHTsftC0w2wrECC4jPI=; b=KJvOzjmhl0TGzLBBC7PiNzu4ENUcHidXKFl3JEhNyvgVzEd74Qtz3VdxpaIXtVObi5LTZE 6OdYUo0XPyl+Im9edHQ/fBwdTttIQpnohV+SU+GuPFOOPFXYd2WiIQlJcqjdQXGOsKs8M3 eM+Btubf0DB8UngyZBeYFEDYOvhgyfc= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-zDCCBxHHN2SWJaiUyBKh2w-1; Tue, 24 Jun 2025 04:30:01 -0400 X-MC-Unique: zDCCBxHHN2SWJaiUyBKh2w-1 X-Mimecast-MFC-AGG-ID: zDCCBxHHN2SWJaiUyBKh2w_1750753799 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-ade57fec429so381169266b.3 for ; Tue, 24 Jun 2025 01:30:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750753799; x=1751358599; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=AyqJMvywObY4nRmPc+2PsXq0lHTsftC0w2wrECC4jPI=; b=J7LrcWZsvB+Hg0nue8kbqKYfF8exIUjNGI4lOc8XhN74coyhMTTnxRzwHgbkFdTEFl UBiRaDq9ufbYcElZTMy8CJM2r2dMXI9HFP2j6RKtbBxn2ekztykRLHJg3e/A3XzwPJdw tZup5cO3MDp9sV9aBY37izb1DaoeNCfPD/FQ6WoptTjDalUIPwOR85rvaJdt95GWSEfm 6fofj2/1Xg9a4oUL5BGsbJ/pCRqWAyH/QS6qzwkIjsejGpDGK/KrQVYVovuFt0TVvbXF DnqWls73NQj384jeQzQrZIL/5ft+Ga0zu6ucQU18KysnxTSo/oInkq7g18PGKaBIgF1F MoRw== X-Forwarded-Encrypted: i=1; AJvYcCVrkPlQSP4Jtw0SXTHbjxSZyyMqjLk2k6i094ZD0lnpN8jPVCPy5ZA3GRKoN2FB0w7clxRs8673oQ==@kvack.org X-Gm-Message-State: AOJu0YzHigYP6MvgUWcfWMMnPT5LQUBHToX9B/V/6Pyei0lxoisnhTZJ j7e4lxMxSmFXZNT4dAlaSoINLyaRAdeu5DOZ37RcpxsEHkABt5vTFnf00c+4sDsu4D6OOX/KgBS x2D9c290fhYzYN492Bfq7MfINTvv41XSQ+gfJXOYR2AQdc23j6qMq X-Gm-Gg: ASbGncseA5Z6bJnGyf+SdC3FF+SkfnVIDJ+CnUUFzKGtg7rdJEfaOq3E+jQkN/D1w6E AYrJyMx2266LIX17z60XKPwrvYkZ7hh+dWk8DVwDp3fgxAmnduJqGB1CGeW8zWjpDMLUCmGvcYh b4kd0KAt8VeVBjRGuYoTNIPK48zdea35bTUtQuP8Dw1xCibZ1NQVDsrj+ydRXVk2mK/vDqt7/mJ op9ryKl+a4GhXFzCkonklXT2jSszdWzK2rJEM80PpW6Ag/UDWFWeMA7Pe4ElR7c8U/jzMpJDZLz McKrXhGugAJWYQMcWMKKaOaoWbGLpJ0tn0bZ X-Received: by 2002:a17:907:940d:b0:ade:c643:62ce with SMTP id a640c23a62f3a-ae057cd7b28mr1502688066b.56.1750753799363; Tue, 24 Jun 2025 01:29:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGoHZfuvldROZlOpGrlurDali1Q//bIgFk9wR+Ykn2N+4mx7sxvQlxPEOfDkbPRWBFbwP5rhw== X-Received: by 2002:a17:907:940d:b0:ade:c643:62ce with SMTP id a640c23a62f3a-ae057cd7b28mr1502684866b.56.1750753798914; Tue, 24 Jun 2025 01:29:58 -0700 (PDT) Received: from ?IPV6:2a09:80c0:84::108? (mischulz23.caps.cit.tum.de. [2a09:80c0:84::108]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae0541b6894sm836679466b.111.2025.06.24.01.29.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jun 2025 01:29:58 -0700 (PDT) Message-ID: <44c805d7-000a-440e-995b-106f324eff15@redhat.com> Date: Tue, 24 Jun 2025 10:29:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled To: Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SwxEzPcJZjQpuPXRlQGBsHlvqhbKTjQ-M4K36frHqsg_1750753799 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 93F8EC0016 X-Stat-Signature: sujozysscq3seczntrxr3tqt6ezk7rh6 X-Rspam-User: X-HE-Tag: 1750753804-322710 X-HE-Meta: U2FsdGVkX1/ESN23b1DgSBz0tO51M0hjwWD5w9NgBGqyHd1Pj+zGrHeOsqMC0vwcdHctsoYRZVc3Ct01FRfugWg4oaA1Sr9zd/ikQiHxv60nvMvQKFjIqODRa5O7KQpZTgkwKaMGxtxKOqtq06s/gSwJvBaww5+aofF7+kTBKYAZmKvtuov6fo3ONZvQb1V8lETPUxI4XmlsoHwq0jvAzxFCduhLg6sMmM7hOQu+DBRek4uAAyptgGw+HxHKBq0AfpcUBkmMIIfj6YEDa/moj9gq0Bude6xV/hqDjOwxb7+9N2scMOUiOWOicFWeR5ni/ahggMN8LjzzYBcjaJVXL6rJrxVKCI3z0Y6O9DeHumGr6TyFa0cJk74h3m+HVV7Ttn+AyR854BO65cmYgFovw4km7e28dgzN//gsrI0jzzGnxFqCK1iFJtr11pRmTOrDV6LMAhFodzalM1W/G2dotcb9a08N64y4AeaSMSDs9INPfrqut1xYbxhK93NP1emjp9+ftTwSy29thaMcLwvP3d1dtooq0ZHh+YLzOuNT18nDVQRqsw/BUmFbV3zNZgj6EasG5cAnwOne2iezGC8MZ6uYTR/Z4Q9JgSSzwpqnY3w8A+F6h1Xz6PQ7WFReI4TSpuRkQSnraPP4AkG6BYb5wVMim+1axRpuWrn2gkZtjCE7AWatZU30gbgxSWFqa084wyMdIxF8kSShf2TQbjMzhrYi4a94an29zdRuy9UhGJ14tBniLQiuu80d3D7iSwm1GiDW7ISTFzyvsv8Tg85c4R/YQ9V7ZDKcRX+RsjogbSIW/zcIwG40KF9aynTMzSZxvvkF6HbpbNUB+M9Q1plXba5slOKt84Nhvb3p+AveDHO6mtH6g/u8X4zXocwrGBD7YLtJrf6X5xgoe/EH9RhKuOHKHvA0RKxgGRqXCr/Vr5hHVPEhmS/6eAC94peKm5fWodJIyVJK9NGE5kzZsX8 Hj1dxZGD GcZlOfIIKnWOV3u38WJuYXNlRuUkVOV+16Ao67C5F9Bkr8uLo9aqq/tnm/9r0N2HCdYt2PP17su9P8sqOMBFOK10CJaZTyZXOPAK9rtxydadfi1T088g936pl2770nBJl79UwoRgAVtVG5i8Xn+dFixML9/r/OmIwTU0QavfrW30Q1asgAuu34A60ZldOkqN1cXjrcTQ46iUAkpkGn7l0QFC+36JQ1uCw9JYGi5vB74GEvteunKn7GzGYgVRYvt6sv7X4mReBVVD4syFeylqjPFDDAwF/Ng0+MPn4m6ZsxLsylZZxwYFG77xtpwXW9x9sz+zeMoGjWDqZbR2ecW64LCla7csBjkFK7nnMFw2T8Mb6ZHOHPM9dpF0rwwF5jJXQnlBV1uHne+FaZ5QZmCNiHVcr+99Ssiszfj4nkcvlK0qTQQYH6Sjj5APNBwEx8cyMnYV8bULPQpNGKmXi7PQKMLgt9O76ZYKqN3QF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.06.25 03:48, Baolin Wang wrote: > > > On 2025/6/23 21:54, David Hildenbrand wrote: >> >>> diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/ >>> selftests/mm/khugepaged.c >>> index 4341ce6b3b38..85bfff53dba6 100644 >>> --- a/tools/testing/selftests/mm/khugepaged.c >>> +++ b/tools/testing/selftests/mm/khugepaged.c >>> @@ -501,11 +501,7 @@ static void __madvise_collapse(const char *msg, >>> char *p, int nr_hpages, >>>       printf("%s...", msg); >>> -    /* >>> -     * Prevent khugepaged interference and tests that MADV_COLLAPSE >>> -     * ignores /sys/kernel/mm/transparent_hugepage/enabled >>> -     */ >>> -    settings.thp_enabled = THP_NEVER; >>> +    settings.thp_enabled = THP_ALWAYS; >> >> >> Would MADVISE mode also work here? If we don't set MADV_HUGEPAGE, then >> khugepaged should be excluded, correct? > > I tried this, but some test cases failed. As I replied to Barry, it's > because some tests previously set MADV_NOHUGEPAGE, and now there is no > way to clear the MADV_NOHUGEPAGE flag except by setting MADV_HUGEPAGE. Okay, can you add that detail to the patch description. I suspect we really want a way to undo what MADV_NOHUGEPAGE/MADV_NOHUGEPAGE did (if only naming wouldn't be complicated: MADV_DEFAULT_HUGEPAGE, hmmmm). -- Cheers, David / dhildenb