From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by rv-out-0708.google.com with SMTP id f25so742804rvb.26 for ; Sun, 04 May 2008 21:42:47 -0700 (PDT) Message-ID: <44c63dc40805042142k2e5bc366mffa9e0a22fbe94c9@mail.gmail.com> Date: Mon, 5 May 2008 13:42:47 +0900 From: "minchan Kim" Subject: Re: [-mm][PATCH 3/5] change function prototype of shrink_zone() In-Reply-To: <20080504215718.8F5B.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080504201343.8F52.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080504215718.8F5B.KOSAKI.MOTOHIRO@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org Return-Path: To: KOSAKI Motohiro Cc: LKML , linux-mm , Andrew Morton List-ID: > -static unsigned long shrink_zone(int priority, struct zone *zone, > - struct scan_control *sc) > +static int shrink_zone(int priority, struct zone *zone, > + struct scan_control *sc) > { > unsigned long nr_active; > unsigned long nr_inactive; > @@ -1236,8 +1239,9 @@ static unsigned long shrink_zone(int pri > } > } > > + sc->nr_reclaimed += nr_reclaimed; > throttle_vm_writeout(sc->gfp_mask); > - return nr_reclaimed; > + return 0; > } I am not sure this is right. I might be wrong if this patch is depended on another patch. As I see, shrink_zone always return 0 in your patch. If it is right, I think that return value is useless. It is better that we change function return type to "void" Also, we have to change functions that call shrink_zone properly. ex) balance_pgdat, __zone_reclaim That functions still use number of shrink_zone's reclaim page -- Thanks, barrios -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org