linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* wrong comment in do_try_to_free_pages ?
@ 2008-04-24  2:03 minchan Kim
  0 siblings, 0 replies; only message in thread
From: minchan Kim @ 2008-04-24  2:03 UTC (permalink / raw)
  To: linux-kernel, linux-mm, Andrew Morton

static unsigned long do_try_to_free_pages(struct zone **zones, gfp_t gfp_mask,
           struct scan_control *sc)
...
...
   /* Take a nap, wait for some writeback to complete */
   if (sc->nr_scanned && priority < DEF_PRIORITY - 2)
     congestion_wait(WRITE, HZ/10);
 }
 /* top priority shrink_caches still had more to do? don't OOM, then */
                     ^^^^^^^^^^^^^^^^^
 if (!sc->all_unreclaimable && scan_global_lru(sc))
   ret = 1;
out:
 /*
....

I think we change shrink_caches commet with shrink_zone.

And I can't understand that's comment.

What's role sc->all_unreclaimable ?
What benefit do we can get with that code ?
If we don't have that code, What's problem happen ?

-- 
Thanks,
barrios

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-04-24  2:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-24  2:03 wrong comment in do_try_to_free_pages ? minchan Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox