From: "minchan Kim" <barrioskmc@gmail.com>
To: linux-kernel@vger.kernel.org,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: wrong comment in do_try_to_free_pages ?
Date: Thu, 24 Apr 2008 11:03:11 +0900 [thread overview]
Message-ID: <44c63dc40804231903m654736e7k47d79373d5449571@mail.gmail.com> (raw)
static unsigned long do_try_to_free_pages(struct zone **zones, gfp_t gfp_mask,
struct scan_control *sc)
...
...
/* Take a nap, wait for some writeback to complete */
if (sc->nr_scanned && priority < DEF_PRIORITY - 2)
congestion_wait(WRITE, HZ/10);
}
/* top priority shrink_caches still had more to do? don't OOM, then */
^^^^^^^^^^^^^^^^^
if (!sc->all_unreclaimable && scan_global_lru(sc))
ret = 1;
out:
/*
....
I think we change shrink_caches commet with shrink_zone.
And I can't understand that's comment.
What's role sc->all_unreclaimable ?
What benefit do we can get with that code ?
If we don't have that code, What's problem happen ?
--
Thanks,
barrios
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
reply other threads:[~2008-04-24 2:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44c63dc40804231903m654736e7k47d79373d5449571@mail.gmail.com \
--to=barrioskmc@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox