From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E78C3271E for ; Fri, 5 Jul 2024 20:34:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BEE56B009B; Fri, 5 Jul 2024 16:34:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 248446B009C; Fri, 5 Jul 2024 16:34:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04C146B009D; Fri, 5 Jul 2024 16:33:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D71F56B009B for ; Fri, 5 Jul 2024 16:33:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 71CDE803D7 for ; Fri, 5 Jul 2024 20:33:59 +0000 (UTC) X-FDA: 82306850598.18.0B27952 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf04.hostedemail.com (Postfix) with ESMTP id 3939C40002 for ; Fri, 5 Jul 2024 20:33:56 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=hApXKNKa; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="B/rWUVZT"; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720211601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0qMYG8lazQcx+MP7yrBK4hVcHkjfwnSyCie7c7SmmgI=; b=2vbnCJomksSRWQh1v8hWnm4B/VP+6NwNNbJYjD9zyNyQF4xNr4TXt1d6MrbvEdV4ww5DeB mpoNx7Cqbkrk1Pl045Pb3j7ERMFtapYNaXYCWcuOR7tWLer/4uPc70UNd5mk8JG6KMoYP2 avABVk69xvv2zKlwXVKjlGGpKMVUULU= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=hApXKNKa; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="B/rWUVZT"; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1720211601; a=rsa-sha256; cv=pass; b=N73OfINiaUmU3YHkEvDh0KGyKoi1DA1dIeJ7AkWyPeyrvresZFF6ENbMpAqO4kUzCoWLp9 fo6fiyqR5p7jRSBCxP+nGru+deBJ7Wz+igTsmH7x1eXLqk6hs4BjC2niiHNP5AGfgG3uls z3DTOkX+dt+zxrLlTTMShgtAxcPDGsg= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 465K7XtX030297; Fri, 5 Jul 2024 20:33:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=0qMYG8lazQcx+MP 7yrBK4hVcHkjfwnSyCie7c7SmmgI=; b=hApXKNKauT3htNVT1T3WJNEVbjuvr+Q TSKOtWbZ/kwDFTyeKgjMENN6OYwvb3pC55IvTZwNwkZgTnxetjcnYwObY4bUj+So u4y5lDLa9pDkbEAE/1B5tR9pQJ7UPzTFNClZ8HSmciNm9MRw5SLWTzeemXT8Ted6 ngbRbLAwqHW/JB+XWLH+XGEzAhmK9mYWgr3KNksDXzgdnKrvZGNflBlgnShcmdbf PZCw4Nm4omCWNyy5CB3h8gXCLFseTfEaIZYKD8wDGLBQktXYPGAH7m4C9XwaDlii HNL/+mC2xxH/FI+r4St06g9uDKrg0ZZrWyMF2wjeeSZ6jpQgoWvIfPQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4029vsvd77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Jul 2024 20:33:46 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 465J2khf010337; Fri, 5 Jul 2024 20:33:46 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2047.outbound.protection.outlook.com [104.47.70.47]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4028qj3e89-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Jul 2024 20:33:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k+sdwzV9sI1oQtuQcY6+w9QC5UWmPLn8gv77QUdjvdLheoYN25Gp1jSC1JNl2q91cvv2MCFQuGv3CaCo6pxlFdwDOz3hj6bwUKaWX6n/GzLJ7mjMMIfCZfAM/sefxImq63N+T6+2IutPh01M09JfJJ1ZyEkxHsJhQeRBgLX1epcXF4GdletbVxFsay+m9IB3aMgfGnUXgwdKHByu+ONej6754W/bmfRWMU4ryYC2vkkv1PuXQrfpZ9NW2Pa5I21RQ3v6gvQSpq1hAhajr9Rao+BuneS5Zkkiu6iFdiVJ1qG47wvT0HiNZOnJHYJ/WQVhUEf0Pljb+W4+RekOjpDp2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0qMYG8lazQcx+MP7yrBK4hVcHkjfwnSyCie7c7SmmgI=; b=LvGIN+lDSSR6f832NpyW6Ia1VTAB78EQoqkMo4LCJ/LUcG7hs7+qo/obsTm/L7aE/3kfi2OdWWNExS3rB1KtYwqy3Z0VhUU9TCuiJLfqLQ1R5HR6nfyUhye1bSrEjOiOTx7OX8WJN/hQtgkvih3/nG/50R41cLwcv/LrD9cU96yeoN4Y4ao6pYrRnJq0zbdTn3JLuSS64v+7KMlgmz7bWQN0LeTvejTrgKkbn6cqadcllglxQ/8/5dY/mQP6eKxvURCXHdpmmQNTpS0RjH6gpS6G4Y64hQQ9/6Jee2VYcr9yuNXDgZnSOfWe266pxm0NFph5hvFwJtlf1Qupuk3gOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0qMYG8lazQcx+MP7yrBK4hVcHkjfwnSyCie7c7SmmgI=; b=B/rWUVZTAAUp0icNt3DKulrpjMCq6fv/gyF5QmH/147K6tmI4JY8ihy+XuUb08qz/DBOcAk9lF4CWR7R32pwMEfx/PKDcBYjxUjdCq53Am4vlNwziCwoNIEGijE1LgspP78fgEt3GXuMU13FhRhyJQIUo3JiI1Fw9DyXViPW7ds= Received: from SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) by IA1PR10MB6711.namprd10.prod.outlook.com (2603:10b6:208:418::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.30; Fri, 5 Jul 2024 20:33:43 +0000 Received: from SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e]) by SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e%6]) with mapi id 15.20.7741.025; Fri, 5 Jul 2024 20:33:43 +0000 Date: Fri, 5 Jul 2024 21:33:39 +0100 From: Lorenzo Stoakes To: "Liam R. Howlett" Cc: linux-mm@kvack.org, Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , Lorenzo Stoakes , Matthew Wilcox , sidhartha.kumar@oracle.com, "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH v3 12/16] mm/mmap: Clean up unmap_region() argument list Message-ID: <44baee28-a626-4be6-98ed-f5473d99157c@lucifer.local> References: <20240704182718.2653918-1-Liam.Howlett@oracle.com> <20240704182718.2653918-13-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240704182718.2653918-13-Liam.Howlett@oracle.com> X-ClientProxiedBy: LO6P123CA0043.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::17) To SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5613:EE_|IA1PR10MB6711:EE_ X-MS-Office365-Filtering-Correlation-Id: ca498b8b-69a9-47f1-3ec5-08dc9d31c349 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZKc94sgIt4MscUJwXy6byGszuWOvKeDDBE9w3eyk7/dBBr2B0BA+6Ky3GHJA?= =?us-ascii?Q?43PGaEJkWG2fC00FYicyvnqBxH5zDd5NaA1QvvFoTDFX8FeCBW3zEcku1zd5?= =?us-ascii?Q?58nxkOeZh1yCuQ7bJap+d7qtwIp/jrudE8lnL1ZxLuDIs9Lauxg/EWb0w9pD?= =?us-ascii?Q?5Af2y8nPrvQup9LQEAWgLp+jusnHQso2ob08bSfYsPwsCrlrhOZqfsmrFAJu?= =?us-ascii?Q?ls6WC1VR5WmD92/0t8aCVH7xRpdWTNukjZtPjVUgJ1XN2UqCsK+y8rVzZgXw?= =?us-ascii?Q?2aqg53OWkODckJcIY0wX+CXIhI1SPu32IksRUpKfZltFcvHmZgfjBwrxavI8?= =?us-ascii?Q?xkvrRT/68bUb718r3sA6mlUWA17XXrTdFe2DIU7x8J9CEfCV5sW+pW5nVsUj?= =?us-ascii?Q?tOwV8g9DPggTxdmAKXNzEkOzZt/sqR/BI10PX9fywqLH/oTuQmEFSNG5BiSG?= =?us-ascii?Q?/cEqaPflvwUeXKlZpMNGLkn1MThqgyMH+1yxvlGGBAneGGG4mRn+H8UGsetQ?= =?us-ascii?Q?1jE9N4woCjGUJMjwC4Sr4lTQOnqvxNnR1P46dhR0s39BR/yCOKvey6CRFSwa?= =?us-ascii?Q?SuJHFWNZ+k2B0cycucY3jyhaQ/TOEfDFN2sBhfZIxLLlzoNFHRBQcBNiKbfE?= =?us-ascii?Q?x0/lhD9XxsV5+aIN3PjaxVmllvcOc0xlE+iow47kdUDnxfHGNUZIJYGzYQtf?= =?us-ascii?Q?8cIG+z/SGIMa9g5q8kM2BP1/V+2+fnr3QrZlDWB7/I6g7OIJeZTVsdJazzfs?= =?us-ascii?Q?AgM/dtPpnQdr744SFyTyaZ5SGJ3hXk0chb/52jrKkQvChXs5+o9KSs653hbG?= =?us-ascii?Q?2XEYoRlBAsm/YKIzRgb6wC+/r2gAI/uobDsi8xpP7tR8bKBRLQWNS6tmNn1s?= =?us-ascii?Q?yXPBnCxHbe09HvWnScoBqIdqOGdqE3Q2rg53tWnfORVpCWh8sK+/otFNON/r?= =?us-ascii?Q?V9vgYjWpFQExPDnbLLuYyD8szS5d1hwfssh2mwqYSSl+wQxwKKeExeeo75ag?= =?us-ascii?Q?onlIw7rAiU/G83xcigdvD3141rS0iIZSGJhNdR+btXBONW48JS+E16rwbGIN?= =?us-ascii?Q?svlGBzWvJ9306+KKTNzAG4D4Jit+tdTQmYkvTf56SghD/sb0VBXcY0THl7cl?= =?us-ascii?Q?+1iypQ0kA6V5GTOYJ5EMFJwoAPOS1xjqBJNOqU5SXJPETeqZMzOhB5qSRqzb?= =?us-ascii?Q?7a2k+NOfO8+TTYQjta2jDwKD+nT8cajSoOGRzy0w2d5wEi0AriBWGCX9E1EU?= =?us-ascii?Q?cPJ+hMUPlrD04KcasxghDZZy6aoI36Lk0JpzMz/35FqaCrwC4bhQomjzcASh?= =?us-ascii?Q?p3c66Ipn9bNQqThfpVq03MnHuw+2V80wiN7/kpjVY+3VzQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB5613.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BRpJeFSYLmANJWwc86ViqYFinNQlL+tWouxhGcTjAepreWNgjwe2TRWiLnHF?= =?us-ascii?Q?t4YuQNJU1HVcv+L31H9KjrC7wHcrCebLAk7a6oNosS2dvWqLXWaWFWNYH1sS?= =?us-ascii?Q?FSNXUOqbn7+cQFgmXRzK0Oz+xO9fmZb4/7dUr45wSaTDbrXzIhsnT4dx82s8?= =?us-ascii?Q?Yh+zcddkhTMqn/qUv9xRHlDvUZLeqkDU6VEem1LmMXbmqsfOAQ80ez+TDqAi?= =?us-ascii?Q?prk1xPOLf/zDvaaOzYvFgmZuL38Kb/RLlHSJZEM8L//XdMsF0//ut0NDiyDO?= =?us-ascii?Q?72oLhTXQUlqTIUJYuOH1eV85Id5jI1pLjmpK/prZmqS+8DANEcSM6QOXXbAA?= =?us-ascii?Q?mBgh3KK3JguaNRNbNPNUQaQ7DOEXfR1KUJuu8DmDpENFx1id/8F/4cww3Pir?= =?us-ascii?Q?xlPmb2if28StE/aUk5mvXNadBjyFFiz+zcDmIZA+0S5DOdp2KWdeTXrE3DAy?= =?us-ascii?Q?7A2TxxgWv3r+Dig7n0m/SwjlRqvsrL62zn9CJF3FGh/saWrbMyj9VRRYcls3?= =?us-ascii?Q?0EdYAnm0G7iFYXEB2sa8/fkCwbl0KPWUMcj1E15Ckh+kuKx9Is2RoQGsqaFp?= =?us-ascii?Q?ESkg9A6aY3hVDnFypgSmYTK7CnRriyfmC8+/w7eStgBYT6OUly1OGlfOwPkY?= =?us-ascii?Q?3fC4N4DFUhOdXZap0m7sLO1TbCQDG803+jQRsUWOJfnvZ7ksG1Dr+KJ/CVi5?= =?us-ascii?Q?dfU3898Fk1dT4+waaJ7OTt2DBSkHOAdgzMWHLv24tJWL+gLv5njMA0jWjgU/?= =?us-ascii?Q?3vs1mPiIflQFDtKn2IvNVqrCJF1tPh9OYCLh2/IKEb9MuFcspwEkWybi5NHz?= =?us-ascii?Q?kQmYJhYKhNAsVXJ7B1eNKzhUhcguuiCCMaGUbM3I8TOOTOMYI6092L9hIKui?= =?us-ascii?Q?o7Y0mMPZi2Qwl6f/TgRTNzvHOkO6Mn5RO3q7O++joT4S/xZvyDjRTmRNHKew?= =?us-ascii?Q?m/6FG4xA+4Es+chv0bOKWY5cA1+ZitAGxxNRFKXV/iRZLwdMvY3cHu/04/3u?= =?us-ascii?Q?1yACmvhAqTnff1j2QqNRkaunEwxbWRUxqjSjKBQm3NANObFUtCASGkfE07FP?= =?us-ascii?Q?ul+HQwwuyemNDUrpugyWXCXK3WTKirQtRq/NVPIy2bYjHeI+PTotSuBOlfA3?= =?us-ascii?Q?lnsLP6mqC/tD5M5tV8GQEXAumaeaecDUALD5zNgZ8NvtoGV2ZSMKeAJ1myxO?= =?us-ascii?Q?Xev9kgyhFBL3Gp2iRifdM0UkevDtYtigjaZvLw3gzaH7usLGZd5IR5deIUaD?= =?us-ascii?Q?VBupAC9d8R8oMd68d+e8PCgaLIyFbkO4CBxZoyTtduMoQxxUUyqp8oNE6Kt/?= =?us-ascii?Q?0DwBSMb1mFUkJjvHKImqYVMzClGARh2nJ6udxF0nKNNa1LoLgZc5pYA23Plw?= =?us-ascii?Q?jF5+MQI7T1kd7ShACf1/02+gRl2Gayy/WQlGASsXglpq63JuEvhlCGcCdqok?= =?us-ascii?Q?kxYxMstrBKLPndweRY4kyWVrNjkvidyWC8ICELnlf9ZJ9fZRYTmW44l0Ehzk?= =?us-ascii?Q?S5BmOF1V4Dg51zdIux+p8eBCxYbcOhLjnw0rLV5E3sAj1yLWZel9openz/u+?= =?us-ascii?Q?YO78XRpY2xyAj9u1p0AmTEj2BwVy8AZf/e36ZB3kPTOLywhFLBCRJcyeBhzn?= =?us-ascii?Q?qA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 16GkvCl1Iyz0Xl43Ih6LwWuAmE4XV0X27xVgc7rqPogCOrjurT8YXFueLTm046ktlLdPdXuPi0VhHIY0uLEEWGstn0YqGCc+JCeW0sqxaionNwHpPFOr3zxhCnWn4uCmL0imsRvzgiYPfoRa0azFx1mF1LdajS+FwU83gd1kK/eWJv4VkAfIg2NiSxpDq72SPsm0PbrXyiO/xUB5JFLOWSWb75VIrO5Jv1EACrtWdVFv7z7qvSMQotIFkplYRv2DLKmX558+Piaz8JR1HCZuH2t2RLPsBu8dyQJR3PHkTpOZXElyrE0BBZkUNfLbpVdX304JFltfEarIx5tpZ5lBqh4+FesKIeIC1a3015vjSPH67fqQGQuNxK98JPZGISbpURazJVqEsgbST3EpdjJ2+6a7+ib+3q78/nDFLF2B2wij/lgDVuimv0IxLm06rqED/akdnN2dbXw77oF06Sv8m4eSjB6EYqLNRQS0LaLjyGFm3mxicyM0o59VxV+A9xQZBEriYPCbhWthj80CxIIUwdqlggXm+fUX4XkhwqUMcq8RFvC+Op4VNlCujx30rilIwC/Ty/cnGXfvItztNmTJXBdP4xZr44x9dlgVncnerlU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca498b8b-69a9-47f1-3ec5-08dc9d31c349 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5613.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2024 20:33:43.7363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nIZ+9dyknlujktftoXSVSJAuc61zM7s47AHBA8wQBtebdCGfbxIUKgO5+f6La9gGBXICkhfY0rYilq1cJEGh6PYBWrCTpoLT4hfZdwv3Jxo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6711 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-05_15,2024-07-05_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2406180000 definitions=main-2407050150 X-Proofpoint-GUID: rNpm9h8zX1rTWGxqD8mB4EZ8A1A1RJ0A X-Proofpoint-ORIG-GUID: rNpm9h8zX1rTWGxqD8mB4EZ8A1A1RJ0A X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3939C40002 X-Stat-Signature: 6hf6rjahge496h1ppn3kxgqgf8n3hdof X-Rspam-User: X-HE-Tag: 1720211636-654367 X-HE-Meta: U2FsdGVkX19tXoz37tMnkYnXX3zLdcm6SVAE3020k9juDCpvO2pYte4bu8hWWvoJwPAmGETLmdjA/qvKN4Ybc4FJcDzEMdHL1qS3SAcHvLFy0tMLhrdcdmk2wtZ8hO6uGTSdynfd/3sEm1+kNR5T1XgGkMlBXRYN+8wlEcAMh1GODKPoDjPIgDmHBu824ZaUOQD5J68Dp55fOqygU9zZq+lJn8n+L662Qxi+2Lvosu6fZnh7azenfdCNhQei/VN4/G7b34UMpx1yfdvjixy5qAyVtT/+LMazpISiUe/5pwHaOoyPJxWMJvwgQXuORdgdkSJ8sVJwuOzdOfJo50Ak7AdiHqcnbi8Pa7b7KVGYP9O2wgPJxU5Xu4E/8jMeFdYJDnAsubxUSsEFD+0oJwRnuat6goiFD0UXQHd8yjmEg+aiWr46+MXWQMl8cjhVc1XuoMGAgvrPZceqHS65HF4aXymYnQrAKHVavh3BriUTc9xkAFLqt7uBtnz1kTR+mbladDGED9S0m9I5NkI72HIX/3BCazQblZXOKk4LoieEaH/j+9x53cQZAS8M5/pSkRK4OPvXmmmCnvYkNhi4XEFEx03gxlmKllPsVPbm4SMs9abrh9qxoDifyHHmgoGQ9Dj6H2/Phd4Uy6ISn/+NiQWhRCX1Tv8+wdblhR/A8feJOsC717uGezvFXSPdklmC0lm8jMvUmWM60Sm7oPhNwh5q4c3QUfELpOjPMB4maPBk6nvI0T5VOyWq33uZuzK1UlNPWvmkKIO3d0JVsmFygrqh0Pe+L9SrJrAaxKO5tYDwJeIwQmiQZfVbD2J0egXOiyzLU12HSbfalDaRjmWGjKpeHDPoAbqYZ3cYL9Jr9J0fQoQbJfI57zCsiahcXPp07HzMw6wjoI2eg6nZjYnew2lYQOpDrdRMvQVrtsIhnvY2JHAsP9SMfa8rWUaYl5BVNaPaT8VLn8p+GUcZHXcDqtS MeQC8Opt aBLUJiU6dZq1lAT1EECeS/ds+f2JqAW5ifFquRMMnlk18BuczqrZIjqbne7C/7qjgOzxQXSpSepJep77hr9Lkz4FC6j9F5iazrbVLZKPMigq8gL2GC/g/KG2taxW9ICkOTDmctA3wV2XppRlUDmgVIksXMiVwXjiTkG0UxE2ANn/+6Fv0NSBOAt0mODzPF7gEQGlUJwv/XIEYJ4iZI3ZefjurJ0hdPrKlMrGQm+mAc45HkppBnN0qM9loLk78xKRZ+LcJpdPrQlzUQ5Lg5ZxmC90/ahUJAPUAGoL5y7C7yNfpq3TUp6dv3LoLYtoKm5EqUN/MydLvZPw+JiSLiPGmQez41gx9TKeVhsp7kdgqqf6+tPEQN9nHoTiXNdNMbIYjKPUFWQ7C1kqMe+ElD+4EqcKUUHYQY2G5Z9vJD9z76BQAQENtw07ZuxwRQqIXhFOG2Vq7kbmZqmlgzQk4qzRHlebpZa1SOhlQ81ex6P502IZ+O5pfCW3JKwfShR381FnqJIUWAVTVmL8pVFvACg0DAsOQNQ22E3AGletP8AOogU0UBXXEoN/keyFnnQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 02:27:14PM GMT, Liam R. Howlett wrote: > From: "Liam R. Howlett" > > With the only caller to unmap_region() being the error path of > mmap_region(), the argument list can be significantly reduced. > > There is also no need to forward declare the static function any > longer. > > Signed-off-by: Liam R. Howlett > --- > mm/mmap.c | 25 +++++++++---------------- > 1 file changed, 9 insertions(+), 16 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 45443a53be76..5d458c5f080e 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -76,11 +76,6 @@ int mmap_rnd_compat_bits __read_mostly = CONFIG_ARCH_MMAP_RND_COMPAT_BITS; > static bool ignore_rlimit_data; > core_param(ignore_rlimit_data, ignore_rlimit_data, bool, 0644); > > -static void unmap_region(struct mm_struct *mm, struct ma_state *mas, > - struct vm_area_struct *vma, struct vm_area_struct *prev, > - struct vm_area_struct *next, unsigned long start, > - unsigned long end, unsigned long tree_end, bool mm_wr_locked); > - > static pgprot_t vm_pgprot_modify(pgprot_t oldprot, unsigned long vm_flags) > { > return pgprot_modify(oldprot, vm_get_page_prot(vm_flags)); > @@ -2398,22 +2393,21 @@ struct vm_area_struct *expand_stack(struct mm_struct *mm, unsigned long addr) > * > * Called with the mm semaphore held. > */ > -static void unmap_region(struct mm_struct *mm, struct ma_state *mas, > - struct vm_area_struct *vma, struct vm_area_struct *prev, > - struct vm_area_struct *next, unsigned long start, > - unsigned long end, unsigned long tree_end, bool mm_wr_locked) > +static void unmap_region(struct ma_state *mas, struct vm_area_struct *vma, > + struct vm_area_struct *prev, struct vm_area_struct *next) > { > + struct mm_struct *mm = vma->vm_mm; > struct mmu_gather tlb; > - unsigned long mt_start = mas->index; > > lru_add_drain(); > tlb_gather_mmu(&tlb, mm); > update_hiwater_rss(mm); > - unmap_vmas(&tlb, mas, vma, start, end, tree_end, mm_wr_locked); > - mas_set(mas, mt_start); OK so the 'raise something in one patch only for it to be removed in the next' pattern continues :) more aesthetically plasing. > + unmap_vmas(&tlb, mas, vma, vma->vm_start, vma->vm_end, vma->vm_end, > + /* mm_wr_locked = */ true); > + mas_set(mas, vma->vm_end); > free_pgtables(&tlb, mas, vma, prev ? prev->vm_end : FIRST_USER_ADDRESS, > - next ? next->vm_start : USER_PGTABLES_CEILING, > - mm_wr_locked); > + next ? next->vm_start : USER_PGTABLES_CEILING, > + /* mm_wr_locked = */ true); > tlb_finish_mmu(&tlb); > } > > @@ -3186,8 +3180,7 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > vma_iter_set(&vmi, vma->vm_end); > /* Undo any partial mapping done by a device driver. */ > - unmap_region(mm, &vmi.mas, vma, prev, next, vma->vm_start, > - vma->vm_end, vma->vm_end, true); > + unmap_region(&vmi.mas, vma, prev, next); > } > if (writable_file_mapping) > mapping_unmap_writable(file->f_mapping); > -- > 2.43.0 > Lovely reduction in parameters. Reviewed-by: Lorenzo Stoakes