From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 020BBCA0FEB for ; Fri, 30 Aug 2024 13:06:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F0616B012D; Fri, 30 Aug 2024 09:06:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89FDB6B0131; Fri, 30 Aug 2024 09:06:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7404B6B0139; Fri, 30 Aug 2024 09:06:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 542E56B012D for ; Fri, 30 Aug 2024 09:06:08 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BC15F1C67A7 for ; Fri, 30 Aug 2024 13:06:07 +0000 (UTC) X-FDA: 82508934774.22.9039B1F Received: from mail-40131.protonmail.ch (mail-40131.protonmail.ch [185.70.40.131]) by imf19.hostedemail.com (Postfix) with ESMTP id 85C861A0021 for ; Fri, 30 Aug 2024 13:06:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=a1cnbXOh; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf19.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.131 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725023144; a=rsa-sha256; cv=none; b=f7JJkvx8A2+apNwxc2molb6DMrTa1CmM+rP+tsRy0rE1kl7r/pMWyK+5CmSLDKir9bu/7x z04fXkchSxfbVUf0HzRyk6+AGHsAl1Wp13sHSq+3e5L+KVwTho7J3akEQyJkLFHeyN/qzS osCvw49jk/OE7P09EbeAxm8C4ejsPkk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=a1cnbXOh; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf19.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.131 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725023144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aBe8onPW5ybz1/iMjQay95hHNR5F07fd5YsN+o+D6vE=; b=4AjWjkgfwCw7Mi1JoipdDE5KovVpC8joy3gRKKbIUbF4vFtm2HzZrcKB5c3C+GD21yuZwE 2Sp4/hqOGGi5Kev1wbNxKxhevmXLnBjyeYKsjXdi7ww3AdS5WWL1Y35taN6SyMSfXDGUWb RxN4vBajOOuz0NPnoxSgMvShU2EsXvI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1725023162; x=1725282362; bh=aBe8onPW5ybz1/iMjQay95hHNR5F07fd5YsN+o+D6vE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=a1cnbXOhSBDk1Nnb29XFhNCGCpaj4e+NrzusYHi+QnEqKf1L45F4NHDlpTb0z9KBz 3q2rGwJY5fbrYAqN3ZuACOEmpy9xl2z/4Jmn1vgr5Q7GjqHJTuvWOVZbr6oKWATEDQ Y83s9yBngzoQ3QQB1T3n5GM3djuqBaKnOC5R5nUM7ESgfIfUmWa7V0++irIyioji1C VP7L0gxJMb1FjoRMJi9h93avmzfQSCP8WIwJuXEccFe93pnh6AxuTw3arND9tsfSgh 5bNOEnPPcmHMNkU8GAZ5GI+UP51Iw3X4ggLbWXgIsDbwDeWEOCGOMZaPXdTcLck2FT 6uTmIDi2BsZQA== Date: Fri, 30 Aug 2024 13:06:00 +0000 To: Danilo Krummrich From: Benno Lossin Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 01/26] rust: alloc: add `Allocator` trait Message-ID: <44b80095-8b03-4558-967e-138ea712f780@proton.me> In-Reply-To: References: <20240816001216.26575-1-dakr@kernel.org> <20240816001216.26575-2-dakr@kernel.org> <60253988-37e7-4acb-b2ae-748b30a4ac21@proton.me> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 53541a418b18778e4e773fc078d8959f34bc6b19 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 85C861A0021 X-Rspamd-Server: rspam01 X-Stat-Signature: tpmrdgijc6y5our3536h331qfo75bjti X-HE-Tag: 1725023165-960454 X-HE-Meta: U2FsdGVkX1+tnKx+k486aZ9CdUxQ/9znBpdQnASuguBaUzoKiSMD8NKAY8fTDLy0GZrwTIbJ5gDqHIzbyjsHck+2BYiLdtkBKWq9prWTXypZEzv9hiDTuFoWKZ60mtn5CxzVQWVBBdzAnWA6wCWA5Mw8p8TtOJ98LsGmxsIrJ7YoR03n8VWYJYrgXAni4EWBA1N3pI/ZJN1hBK5A9LJ0FBhM5AfiazvsegbW9p/64IljLxNefVeUUbMDRnVK1jO2MvM8nf0eV9wQJ+DVD9SzfM3VubpsZVHMXd55+McS0K3qw5sz+n6A07IKjKbq5NcL/dLybreLpD26x+gcVW/w1DCg+3F8nwfJxEqyihGTY+KAn7EPS5tWcOtTzNdgirpRF5TGl4Vl094R5S07W1K7Zp+nsYACsIjrxSfwIjgoCSwz/eNQek2sdfaD6IVjzLeix1OwPXtISzzKU6pfeHvIjvbQt4K3jgVclUPkAKGmk0iFyYIzrPkbotD5oy2o0BKbJQ7BiFDbXHSWysd7GlwodF+vcXNiIID/FUqGyhosFjZ4l9Nnh3sGuZ0Q1GjkEJRr0dz7gj7Qq0YgflM6wfZqcuYrgoPyRBwJfzeIGZgE0UL/m6PWOTTQdxKnoVSh/0VDyUP/900tvwXNhW0KI1dJOKYRBYv2iwsbgs1Ltt7CZaK0XvFg2LjjcWRS/d6FT2YZFLa0MkM8K9Ujo4XUvcAkMBT1dHDLtDqaZ0pay8XDmwrtNHX2PsKhw4OOHF9sAZj9zJ727foMSFqp6xoA6mdP+2FMFE38ScfJ2LXsN+L+ZsR8SdFBDCgImCp3Fg72GXahawSraugCekBU0LpF+2FFWjiEWaQ/x0wRllsT/XDJCrc6AvmlVeRwNXY4q85iatFCWqou9FTITEBMkdE/ij6RPiCXa1XMtei+dujyPwinDo/2EfSDBt8zbfrtls7UeSqiSqzJ5vXlQrVt9CmrvVS VjzFtNf+ vbq21wvWFX9e94zsU/1+u/qGXp+14QAguatdXz4yAJlKKj/pVPK0pAr4dzb38HN6Xwsw9IypHetj2ObUDnDGgo+gi7TE2SOb9KRtVL9nM33w0eJDKx0EGPQ/pm6TMw8tGopgUUIlBRsYyknI7HLdo7VRu/flPAp/LDNIAXVSgRNwww7BOUS7NmCbiCyMNEwK47PGU66fDVb4ZhWDlv4yQixDj/6novCBQYRV2cZdvLJaZm/oXgL8VEtPdiSkkwRqaquJxldWYEIvsfIJrsbcZQJRmzwuSwYPnLGdR9gXp2WzTtaOhOfvgrO0Q0Stw5KoKaFbWrgrVgNJ4DLcbJ6amtRYpE3QZYaAisVg489wCH1z4VZL1/ytufhYeTjGvnHCjZbSf/IzCB2upJc4Tb3+YPL0zr7XEJ/OOyYkgIgJdg/nFeLco68gavb/z+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.08.24 23:56, Danilo Krummrich wrote: > On Thu, Aug 29, 2024 at 06:19:09PM +0000, Benno Lossin wrote: >> On 16.08.24 02:10, Danilo Krummrich wrote: >>> Add a kernel specific `Allocator` trait, that in contrast to the one in >>> Rust's core library doesn't require unstable features and supports GFP >>> flags. >>> >>> Subsequent patches add the following trait implementors: `Kmalloc`, >>> `Vmalloc` and `KVmalloc`. >>> >>> Reviewed-by: Alice Ryhl >>> Signed-off-by: Danilo Krummrich >> >> We discussed this in our weekly meeting (I think ~one week ago?). If you >> give me a draft version of the comment that you plan to add regarding >> the `old_layout` parameter, I can see if I am happy with it. If I am, I >> would give you my RB. >=20 > May I propose you let me know what you would like to see covered, rather = than > me trying to guess it. :-) I was hoping that we put that in our meeting notes, but I failed to find them... I would put this in a normal comment, so it doesn't show up in the documentation. Preface it like implementation decision/detail: - Why do `Allocator::{realloc,free}` not have an `old_layout` parameter like in the stdlib? (the reasons you had for that decision, like we don't need it etc.) - Then something along the lines of "Note that no technical reason is listed above, so if you need/want to implement an allocator taking advantage of that, you can change it" I don't think we need a lot here. Additionally it would be very useful to also put this in an issue to not lose track of it. --- Cheers, Benno