From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5276C5AD49 for ; Fri, 6 Jun 2025 18:23:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C3526B0092; Fri, 6 Jun 2025 14:23:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 574166B0093; Fri, 6 Jun 2025 14:23:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43BAF6B0095; Fri, 6 Jun 2025 14:23:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2439D6B0092 for ; Fri, 6 Jun 2025 14:23:36 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B609BC069A for ; Fri, 6 Jun 2025 18:23:35 +0000 (UTC) X-FDA: 83525798790.22.6C98039 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 55A66A000D for ; Fri, 6 Jun 2025 18:23:33 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NbhLLzhp; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749234213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ug2rgnBs6oJAavrVeN9J6WIfZuijp5pXf6YiUZQknzU=; b=F5jziOujJWlI7yJEjt+uH9Kq/74ttokVdE6Kg8r5hgu02Yt/yvPyLgjJNiBX05Pf04df/0 Q2L9Q1k7HY2/dn8YYbONGNMcsBiCyWR3iJ4wiIWxDBbj9fzumcfZTI84yoLRCGQ53uYbSL PiwO3QEYB3bOR8tWtVMdY4MKlYhbqv0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NbhLLzhp; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749234213; a=rsa-sha256; cv=none; b=WL91I/D9s24y68CZctyul2oWhyyiKqGIY+PmBOt3wzMYR6NRi83HOoc/JVltZjajjVEbu8 2Bw9JvKmVBEa2gZl913SUCDF2cYtryjTuVmUNNZc8LkfNePHgEz0gD/h9lIuPpSqhs0RKT SQLSKGZIiY8BzouMzGbIC5JJdn3TfDQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749234212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ug2rgnBs6oJAavrVeN9J6WIfZuijp5pXf6YiUZQknzU=; b=NbhLLzhpQDWiShfoYR2MvnpkyzQU4TdfYHtyQSo+2gYCfGkH9XIaxnCJya3AxFSlag/vWI Lm8/07Q6OTMCKayigWpCAIo9VL55T7YXyRJwMt4p7jlJNmn1FdFzPpAQ3AJ7GemwG1qtF6 Ohdo6cv0bt8Yxvx4nf2c2kiZNtgPktI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-0dNAZM8xPMu-yTz2uYUYxw-1; Fri, 06 Jun 2025 14:23:29 -0400 X-MC-Unique: 0dNAZM8xPMu-yTz2uYUYxw-1 X-Mimecast-MFC-AGG-ID: 0dNAZM8xPMu-yTz2uYUYxw_1749234208 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f85f31d9so1295748f8f.1 for ; Fri, 06 Jun 2025 11:23:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749234208; x=1749839008; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ug2rgnBs6oJAavrVeN9J6WIfZuijp5pXf6YiUZQknzU=; b=S+7ushPXu4R7XnnIoojJl3z1ur8Z1HNSNi9cNbTEPzF0n3ZqaYxiwKs6HMPbsTMO2N mpQ5Z5vc7CoaaqBwQDZNq5zxwGUvqKXpCCsHSJpwYzMeN7NwLgP48hzxApPUGuSz9nE+ mNbTp7Ud7dJknt2ekBk3VQ1Oo/t+lAi/IX33p/A+EBzshFDYXVVzjYoaDZGHo/jnEdPC OiwsJrFxUqQIfY+Fmui0TkyaXaL4UhUrUg9nVz1csib3LN/Q44Ok7mkLxkxp2PjHFD6F 6Wb/j+7y82SXDAMQUMWaN2xrZfOtDT3F8q+TujLoAT+TPL+sFBJv/Wt4NSz1NtVC2aWA 55eA== X-Forwarded-Encrypted: i=1; AJvYcCVcDy4je1C12dIEO4qexhaKSsha0w/pwf7c53IajZz8W4Abn3++1VSLWKWJ7hEhncXLJm4XyBUzZA==@kvack.org X-Gm-Message-State: AOJu0YydQY3xoYtn9fODYiZSfwEgcWeKtQ9EALzpn2Wpf6F1s/Fi/pzR IvJ08/ifcvVB+kflSYuMCZ+qip/kIAB6IYrvnlQ85xTnYMWOgxvletyxXlgkLzm+csclTg+mEkM x2MixT1tGX6hzcC5c/x88EkQRvDQmanChp4tfUFcfgrcGlsMEHyJA X-Gm-Gg: ASbGncvZvfnIqjidwLc3ekn+VP5LjzlMudFmkH0Ih9iTaKA2LAwaEGMRr6y7n3Zrifm ppgddQQsQf6d8OrCjnieGi3YEZm+0wROWYu07RHchWzFQHeNAELm3C7139xKOH7aYAK9p7gwlvj FZ01Rj2TgLyWAOuYhAqvtTgZqqMu0N5W7jhrBey0OxFVEoQbrmQPUIhpAoNOHV6nXueGqzs18ox trp1/YF+j/xzmIJI6hu0U86fl9IUHc07qxFVUT88rQXRHCy/k5YVExWrRYfubYqyuOu1YjbAq2f 2tW3NRwa/XRWK1jyMgX8hQyrLrkIckSVSORI0tJddIq1xFQ1fBBaueVf12a/YdayzXQSagOmjGA wDrs0uMPFSQwKouhVlHwCBlC0MKk7f/M= X-Received: by 2002:a05:6000:200d:b0:3a4:dc2a:924e with SMTP id ffacd0b85a97d-3a531784971mr3973402f8f.6.1749234208241; Fri, 06 Jun 2025 11:23:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8/EXOFVWPefbdu/a4nHn2MByHfexAc310Ody1Xrl1rxFHi1hd9fL2kjWdNFfNi7AORNazHQ== X-Received: by 2002:a05:6000:200d:b0:3a4:dc2a:924e with SMTP id ffacd0b85a97d-3a531784971mr3973385f8f.6.1749234207849; Fri, 06 Jun 2025 11:23:27 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451f8fb57b1sm34324945e9.1.2025.06.06.11.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 11:23:26 -0700 (PDT) Message-ID: <44af8f5a-2d94-498b-a3e0-31f5dde74538@redhat.com> Date: Fri, 6 Jun 2025 20:23:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs To: John Hubbard , Lorenzo Stoakes Cc: Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Jason Gunthorpe , Peter Xu References: <20250604140544.688711-1-david@redhat.com> <1a65d0e6-6088-4a15-9c19-537203fe655c@redhat.com> <50ff9149-2824-4e57-8d74-d8d0c063c87e@lucifer.local> <1a7513cf-4a0a-4e58-b20d-31c1370b760f@lucifer.local> <72bb36f2-65b6-4785-af9d-5b1f8126fc78@lucifer.local> <2f866f12-2aa0-4456-b215-08ddc9b13b1e@redhat.com> <3dfbbd63-697d-42aa-8906-539d74df9123@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3dfbbd63-697d-42aa-8906-539d74df9123@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IQubDtSC6PhLyFMXv5zEjFLjFn7_JBOgxxCC3SOwEu4_1749234208 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 55A66A000D X-Stat-Signature: 5h36nm31jfdywbdq5fza3csiz7ryyr4g X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749234213-3925 X-HE-Meta: U2FsdGVkX1/h7Xon3Ft2US8/EC6DpvWLu2qP27cGyRvjZP46EehzGJfzDlgp3ELSmHhr7LRnREQuP5z00WDOICGcSR33MKUsTtA7wXuk4yJe7ZmYZL77BviPXiuueSR4nVURYydRnw3nsupvMm3oVYdOPrFgPXJFKTjGJoFoqPyk4ae8j2D7TOQw8N1Yobj9Hu6lGnNlzfDwcak/xgVIU1CPtfozzU0AOTFvIyeES4cL9Ldw/iop+d2o5vlxulf962oUS9fjN+NKGAPd35ORXRQAYTs4gpNAtgRpCTsQ7dsw3mbNzWXSfrRpcaLeL6mg6K5pGbPui6grM7Cqvy8J/KeJ0M2sWakBQ/HRW2M8txj6VqM4mMBCMDxGOcTXDv5/Bwsf2dCtmj9X9c6F7U6fXPUp/MWoOgWqKVg3brEQ+q6WMn0OPMUux5TSwVqeGPdhO5qwlzFRvcV0HBpHnZfoIswY/UGffWGFpHcVZi1z94KJul5RnB/5FJV51yO5R5QSmkJkzsZHiX3sKzlJK+7TRG6Y1s3H6IosTsw9cRU8TCj7EmiOOpHX+gcpy8VFdVmMn+2VykQITIgFnZY0V8czfd1rYqVba2Z18ml6zjWp/pY8SMvU7z0Cpo8mVo2KSWjOU11XKu7g8vG7VF3hGmBhTlhjq+w7zcr02T5FGK1rcqHIb5Q2M24scEHsCfrTQZ8jmXUDbpMHifOmxEO7usUYNWFwisInY4Yu7iZVdVDZfa5xZig6kqYWOXahMe6vTG8CXLsI/dA5jDf/9FBMpjAD/LAGkVxQG/gaSq9M6wVzfiVtMyy5BPAs7nguNgmhxYaikUAOp27Vjzwh0fywr6uX3vGkTF8szS3WrLGkjHb0IVRN1DP9xe5sWkfPA0P+Krpk9znN1826y4EMZd8Y0YGMbOKpWLr46Ci+Uv2PK4uGuRQKzFqjKOarcAVKjCE2lbzx1Q1rAnPzzWGBAAr8gsf YOlpa8hI jOr8zxGd5DvvUe+w4Ijq0Tvj4Y6ermLEv4i9ysQMu52fxLoxCO675HOFTNBMEvF0AR5vHc4yaYaFNypII82cpWbMIemCuFeqjhVtKOOpI+oza0uc11zfx4lZ8hVY92Q+taEVXW/Jn3uKFFbKefY8NvLyMkUmwnOD0YLgd39H/UOFB9kJjpklfIW1aguu3KCleoDeKHGwXQN0FS+h9vBm91dmwRuzzX8mKPd35qh8NYx/+fBaQ3W0mDM8eWA2W01m0H+Va9UfP3agKlXyrgTP8zEXWLBBdri8LQLijZtPSgGzOEDxFJhUlbIQW2PiEteWVSzzxQ30dnCg9SQbCPfuTzbkKalWJnwR+8g7p8ohfn1Q+qvIsczryLoqs/KvlzIihBYUytKQgLqfnvITyn0uKet3EuBRgSn35IYY/7XNMG+pteok6jXsfq7L+wqhBKlD9wj2+dx4moVF/+bs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.25 20:21, John Hubbard wrote: > > > On 6/6/25 11:15 AM, David Hildenbrand wrote: >> On 06.06.25 20:06, Lorenzo Stoakes wrote: >>> On Fri, Jun 06, 2025 at 10:57:44AM -0700, John Hubbard wrote: >>>> On 6/6/25 4:04 AM, Lorenzo Stoakes wrote: >>>>> On Fri, Jun 06, 2025 at 12:28:28PM +0200, David Hildenbrand wrote: >>>>>> On 06.06.25 12:19, Lorenzo Stoakes wrote: >>>>>>> On Fri, Jun 06, 2025 at 12:13:27PM +0200, Michal Hocko wrote: >>>>>>>> On Fri 06-06-25 11:01:18, David Hildenbrand wrote: >>>>>>>>> On 06.06.25 10:31, Michal Hocko wrote: >>>>>>>> [...] >>>>> So to me the only assessment needed is 'do we want to warn on this or not?'. >>>>> >>>>> And as you say, really WARN_ON_ONCE() seems appropriate, because nearly always >>>>> we will get flooded with useless information. >>>>> >>>> >>>> As yet another victim of such WARN_ON() floods at times, I've followed >>>> this thread with great interest. And after reflecting on it a bit, I believe >>>> that, surprisingly enough, WARN_ON() is a better replacement for VM_BUG_ON() >>>> than WARN_ON_ONCE(), because: >>> >>> Right, these shouldn't be happening _at all_. >> > > I'm easy on this point, I'd say in that case VM_WARN_ON() is the most >>> _conservative_ approach, since these are things that must not happen, and >>> so it's not unreasonable to fail to repress repetitions of the 'impossible' >>> :) >>> >>> But I get the general point about ...WARN_ON_ONCE() avoiding floods. >>> >>> David, what do you think? >> >> Well, in this patch here I deliberately want _ONCE for the unpin sanity >> checks. Because if they start happening (IOW, now after 5 years observed >> for the first time?) I *absolutely don't* want to get flooded and >> *really* figure out what is going on by seeing what else failed. >> >> And crashing on VM_BUG_ON() and not observing anything else was also not >> particularly helpful :) >> >> Because ... they shouldn't be happening ... >> >> (well, it goes back to my initial point about requiring individual >> decisions etc ...) >> >> Not sure what's best now in the general case, in the end I don't care >> that much. >> >> Roll a dice? ;) > > One last data point: I've often logged onto systems that were running > long enough that the dmesg had long since rolled over. And this makes > the WARN_ON_ONCE() items disappear. I think what would be *really* helpful would be quick access to the very first warning that triggered. At least that's what I usually dig for ... :) -- Cheers, David / dhildenb