From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E910C6FA82 for ; Thu, 15 Sep 2022 00:45:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C0976B0071; Wed, 14 Sep 2022 20:45:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2498E8D0001; Wed, 14 Sep 2022 20:45:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C31A6B0074; Wed, 14 Sep 2022 20:45:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EC13C6B0071 for ; Wed, 14 Sep 2022 20:45:48 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BA57E80252 for ; Thu, 15 Sep 2022 00:45:48 +0000 (UTC) X-FDA: 79912477176.25.5E06F02 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf15.hostedemail.com (Postfix) with ESMTP id 70D0FA00AB for ; Thu, 15 Sep 2022 00:45:48 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id b23so16463154pfp.9 for ; Wed, 14 Sep 2022 17:45:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=n05HjcTTlTQT7owpfGLGmfiA73hG6sYlZ2pnjGc9I30=; b=fv3cSYOZbY9VMUoZBomXZXPTKZ6IdxVPJbomwoCCiADypz4dyw9tCzBk3lHO6n7ieI 9OlnF4Jx0ogHV62iLj/6HgMg/eIYJc0WvG9LIhfDPJL4wKvwa/zl5BMsnNS96kOJjiOH W2QbroVCbx++V18wB81pRVuINX09n3gyhvW7213n5gHEQMihA6tLipb9Bq49iPzFRGDR F37IAu3e6IXtcEpzUauldYAqhtdWr78ISZ1mPhLmv5rfgVmIh7m6MG74wer2y0lev6kA LVTJtg1uzoSi3naV4uRC8F3UDDOT1uuCyh+sA2Yf1HlEIjR96SohQRcKOQZl2y+2Bi/J axBQ== X-Gm-Message-State: ACgBeo1hu73nDhXB0h+rDK2eZuHQTj6VzcsPU5AmGxeRdKILN6Wa/kaU FYwU529dtEyHhiLxJ+SiMHw= X-Google-Smtp-Source: AA6agR7OUk1btd2IJ6tSFOA3HxLtLLbIojIYWD6zfrKjJ4mcN0cqytEeSz5/Ar49RMNHPPoLUXbJRg== X-Received: by 2002:a65:638d:0:b0:420:849f:77ed with SMTP id h13-20020a65638d000000b00420849f77edmr34202536pgv.523.1663202747475; Wed, 14 Sep 2022 17:45:47 -0700 (PDT) Received: from [10.8.0.3] (144.34.241.68.16clouds.com. [144.34.241.68]) by smtp.gmail.com with ESMTPSA id k29-20020aa7999d000000b00537b6bfab7fsm11144548pfh.177.2022.09.14.17.45.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Sep 2022 17:45:46 -0700 (PDT) Message-ID: <44af62e3-8f51-bf0a-509e-4a5fdbf62b29@kylinos.cn> Date: Thu, 15 Sep 2022 08:45:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Ke Sun Subject: Re: [PATCH] mm/filemap: Make folio_put_wait_locked static To: Matthew Wilcox , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, k2ci , linux-fsdevel@vger.kernel.org References: <20220914015836.3193197-1-sunke@kylinos.cn> Content-Language: en-US In-Reply-To: <20220914015836.3193197-1-sunke@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of sk.alvin.x@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=sk.alvin.x@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663202748; a=rsa-sha256; cv=none; b=cE8moopIALfSusk4+Ag/gohKENh8RJwZVa0PewIbfvcKDTGdVpMEopkj4ea46cWJkoZ3LZ 29Bp+mM2ZXPmWq8HmTdbmLC1PTlS8bwRjj+UHwsnh7+kdoRSUIlRheybTunhvyQ6c3Ci7y o8blW3YsFupJjHdXwHm6WQW7EERY4K0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663202748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n05HjcTTlTQT7owpfGLGmfiA73hG6sYlZ2pnjGc9I30=; b=eKNyUPQux1MCer2O0ZFmEoixOwyV8z1iyCfmf36Ft+t6EJ0bLb5tunbd/pyLK2uDSw3IaN EXyyS5hRUO4IN7kX9xrGt5h4VAgkSbRSze5ncENScW7YZkOARNE0MxPw6uREt/YwRbD5U3 7YTXnskxeJdubIlK4LLP2vLjlJrPaDA= X-Stat-Signature: samrkoxnoqdsoeuj45y48uns4jrikrax X-Rspamd-Queue-Id: 70D0FA00AB X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of sk.alvin.x@gmail.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=sk.alvin.x@gmail.com; dmarc=none X-Rspamd-Server: rspam12 X-HE-Tag: 1663202748-238031 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Ping. On 2022/9/14 09:58, Ke Sun wrote: > It's only used in mm/filemap.c, since commit > ("mm/migrate.c: rework migration_entry_wait() to not take a pageref"). > > Make it static. > > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Reported-by: k2ci > Signed-off-by: Ke Sun > --- > include/linux/pagemap.h | 1 - > mm/filemap.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index 0178b2040ea3..82880993dd1a 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -1042,7 +1042,6 @@ static inline int > wait_on_page_locked_killable(struct page *page) > return folio_wait_locked_killable(page_folio(page)); > } > -int folio_put_wait_locked(struct folio *folio, int state); > void wait_on_page_writeback(struct page *page); > void folio_wait_writeback(struct folio *folio); > int folio_wait_writeback_killable(struct folio *folio); > diff --git a/mm/filemap.c b/mm/filemap.c > index 15800334147b..ade9b7bfe7fc 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1467,7 +1467,7 @@ EXPORT_SYMBOL(folio_wait_bit_killable); > * > * Return: 0 if the folio was unlocked or -EINTR if interrupted by a > signal. > */ > -int folio_put_wait_locked(struct folio *folio, int state) > +static int folio_put_wait_locked(struct folio *folio, int state) > { > return folio_wait_bit_common(folio, PG_locked, state, DROP); > }