From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67690C433EF for ; Fri, 29 Apr 2022 09:33:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA4D76B0074; Fri, 29 Apr 2022 05:33:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E84986B0075; Fri, 29 Apr 2022 05:33:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D42586B0078; Fri, 29 Apr 2022 05:33:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id C4DFD6B0074 for ; Fri, 29 Apr 2022 05:33:00 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 93C182AAB6 for ; Fri, 29 Apr 2022 09:33:00 +0000 (UTC) X-FDA: 79409402520.15.F17B3A1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id BED83C0044 for ; Fri, 29 Apr 2022 09:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651224779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I/tOR54sNmC3XZUOFOHQ4Yl+AwgBMX0e/7hZwa5pXik=; b=Ze+TiAQP7zWMYCOZDbngfbZchUkW1yqUC9sBpDQjXXSMDzeTuN0sAll0ZIdQUYCop52Y6C A/SwWmzWCx6Uq5p1+DQ6/9rt2HsF37AOmVi1GpGCGpmDNA4EvwsFnQjzwnXNETnhBLV3oY eUIFKGc1fpNShnSwgCAvB+6uQeY2M+c= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-glMdu0PTOuKRG1kDYmmXPA-1; Fri, 29 Apr 2022 05:32:58 -0400 X-MC-Unique: glMdu0PTOuKRG1kDYmmXPA-1 Received: by mail-wm1-f70.google.com with SMTP id bh11-20020a05600c3d0b00b003928fe7ba07so2266175wmb.6 for ; Fri, 29 Apr 2022 02:32:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=I/tOR54sNmC3XZUOFOHQ4Yl+AwgBMX0e/7hZwa5pXik=; b=1O4K8j5ybKXgz9k54ZQGDjr99SFBukuX6FRCzLIoFvQYAw4rxKcImt8uMW2EpONG3t 9vFxi7k8S3aUBSpY7H5oGS+FXyB15l2//5ryEiJkPqf8AssE2zRxZ4WdLkzDC2zqYvpw sYmgCgtzxljJwKDTc498Ruek9zfyF1Lgn24QWoYoMLGjhX7DlPTKMRrQh3+WNeHtbEbs qZoJAQyZu5jIzwFqEWGW20NkkY48ciDR4PXKXpinHLd9RK15gQoL3hVrWdRAXJ0F+1Ms wgwSyq5A9sr3+g9NP3SUYr0app4vPJADqxNZ7QtaWK8c18L7/2JmWp4e7h2EX6CnIlrr V4iw== X-Gm-Message-State: AOAM531kLy5TFBsNtVgyZxBYagwmGBBvE6QIs8BgVqxvrPk9FdZJFiYt CyuqwMq6ZQ6gS5HSuK+amQRE983UnXXgkc5C1DL713/8A2F9/oypME+Gd6FQUGOv4l1XIyg+c2T 0UkS45sRgj1E= X-Received: by 2002:a05:600c:1d9b:b0:393:ffc8:a09b with SMTP id p27-20020a05600c1d9b00b00393ffc8a09bmr2361946wms.40.1651224777291; Fri, 29 Apr 2022 02:32:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAZpnopCct+J3YhYQM6TcFt5LHE6kqYWM16L6lA6v065iSffCewmWU3++q1gRQMouQtPZgzQ== X-Received: by 2002:a05:600c:1d9b:b0:393:ffc8:a09b with SMTP id p27-20020a05600c1d9b00b00393ffc8a09bmr2361932wms.40.1651224777084; Fri, 29 Apr 2022 02:32:57 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:fe00:bbeb:98e6:617a:dea1? (p200300cbc707fe00bbeb98e6617adea1.dip0.t-ipconnect.de. [2003:cb:c707:fe00:bbeb:98e6:617a:dea1]) by smtp.gmail.com with ESMTPSA id v3-20020a5d4b03000000b0020af3a12d15sm1966249wrq.2.2022.04.29.02.32.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 02:32:56 -0700 (PDT) Message-ID: <44a6d752-6957-0cdc-aafa-eee81725a215@redhat.com> Date: Fri, 29 Apr 2022 11:32:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v4] hugetlb: Fix wrong use of nr_online_nodes To: Peng Liu , mike.kravetz@oracle.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, baolin.wang@linux.alibaba.com, songmuchun@bytedance.com, liuyuntao10@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, dave@stgolabs.net References: <20220413032915.251254-2-liupeng256@huawei.com> <20220416103526.3287348-1-liupeng256@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220416103526.3287348-1-liupeng256@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BED83C0044 X-Stat-Signature: 31g1187sti8axawaf7mhqxzb5ywxzjns Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ze+TiAQP; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf28.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1651224770-918091 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.04.22 12:35, Peng Liu wrote: > Certain systems are designed to have sparse/discontiguous nodes. In > this case, nr_online_nodes can not be used to walk through numa node. > Also, a valid node may be greater than nr_online_nodes. > > However, in hugetlb, it is assumed that nodes are contiguous. Recheck > all the places that use nr_online_nodes, and repair them one by one. > > Suggested-by: David Hildenbrand > Fixes: 4178158ef8ca ("hugetlbfs: fix issue of preallocation of gigantic pages can't work") > Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation") > Fixes: e79ce9832316 ("hugetlbfs: fix a truncation issue in hugepages parameter") > Fixes: f9317f77a6e0 ("hugetlb: clean up potential spectre issue warnings") > Signed-off-by: Peng Liu > --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb