From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C7F4C433EF for ; Wed, 13 Jul 2022 15:56:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9E7494014C; Wed, 13 Jul 2022 11:56:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4E68940134; Wed, 13 Jul 2022 11:56:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A160D94014C; Wed, 13 Jul 2022 11:56:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9402B940134 for ; Wed, 13 Jul 2022 11:56:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 70BED60549 for ; Wed, 13 Jul 2022 15:56:07 +0000 (UTC) X-FDA: 79682527974.28.E24ACD6 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by imf25.hostedemail.com (Postfix) with ESMTP id 25446A0080 for ; Wed, 13 Jul 2022 15:56:07 +0000 (UTC) Received: by mail-oi1-f177.google.com with SMTP id bb16so43994oib.11 for ; Wed, 13 Jul 2022 08:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=WkSQGMlzkcg7F25RRv5rghI0mHalOBr7A56+aczRN84=; b=TokE2vNEcYXOMc500qMsLWmfRFBNAnA2uXvm+HMyhAe7V5c3ZxWMyZwZjtBi0haXR8 HGp/59n2cy5qMOW13Jyx/nBGhBVCuc6cMJxHpAoFEJJ9MFF04rbMfzejGcBRYpGcHnDF uU/p+EDK/T7/nTWm44yWdQkH6kFZhK08PL4dZLmzKRWuJE5MivwpMoBoBnqbLRiCWJJ+ 9O6zXKo+ZRqjSyBM1B1rzvxLRRI5TZ7k3QfmKYp9djPkN3F9qDEdRSE8FJC0YsaPaCBb o4Xv5RiCw4ZJycv+SCfQBsaKaSOy8KzJnrn7cuMWTP19XQJ88fmZHW5gvIwV5cuR82X+ iPNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=WkSQGMlzkcg7F25RRv5rghI0mHalOBr7A56+aczRN84=; b=2FdxD6xiIixooEtp+cf3WsGa8yNDp5TOLqLBLZrvsujy7Og6Apgsi4w9oljkg/r3XO rzGXuw8uN70zF5KDzAvPF195EeeRr1THqZZQ7uFWIXmQJST6fHWeCp4KbRHUk66RtjOh HykwcWWGvUxsgMIaVFQQrlklVeNZFd2DSRHZlCIkJSQ/hxiELX8TYbeMw3daKs/JrgC5 HUUDc4Or1NIvyl6QaxeTNMyYKLTIXysXB0tT+RL9qNd1ZcTbN3xQrNdP+ytDQdFEuBcG nHLUhExXKin09Tk1ehwjIKKEmKzyZn+taqSj7rIt26yvpOSjw0KCZuDiRXRtMaWzvkvy E+Ag== X-Gm-Message-State: AJIora/QcsDnE6+mBOpZHIuYFJci9dqhqARujCEv5EbO9Kowhc4hvsI1 JtURxxqdvqX4A1q50Uq9+0F32Q== X-Google-Smtp-Source: AGRyM1uf0Tdw2UqbBNRwyWQHGpfHBB44kcUu4QCB3PbjhmzP3bihR91dHuYa4cms3heNmXYpoaGk7A== X-Received: by 2002:a05:6808:19a5:b0:335:cffd:b276 with SMTP id bj37-20020a05680819a500b00335cffdb276mr2134313oib.226.1657727766210; Wed, 13 Jul 2022 08:56:06 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id q16-20020a9d7c90000000b0061c35e7aceesm5016860otn.42.2022.07.13.08.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:56:05 -0700 (PDT) Date: Wed, 13 Jul 2022 08:55:53 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Liam Howlett cc: David Hildenbrand , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH] maple_tree: Fix sparse reported issues In-Reply-To: <20220713132926.3sl7gs67dyjj7kit@revolver> Message-ID: <44a478e8-2ccc-e82-bd5a-172778c01529@google.com> References: <20220712142441.4184969-1-Liam.Howlett@oracle.com> <653cc1da-e45a-9a93-7158-cee3e710ba35@redhat.com> <20220713132926.3sl7gs67dyjj7kit@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657727767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WkSQGMlzkcg7F25RRv5rghI0mHalOBr7A56+aczRN84=; b=pqdFhTviedO04PwciAabmjtV2JpFhB5ck13bku/JE1SiV3A/tnBgoZs7CQMDeDQNR6qWD3 WkaiIwgK/rBFRSniseltpRz6ZBEviKRC/FN9Xdx0eYwDTsdHC1hguHiIFFuXSYZJ1L82nR 03E1Z57VEzZbomAnuwA2kesZcZMtTZQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657727767; a=rsa-sha256; cv=none; b=ermOl4e1zA7iiMp7cshDHW1df1oxNBkfwG1XD6seTH73RpuAf4hPFaD7WZ2vnyspsKepkA lGC66g+8xI2JzyMfonKg68Iquo4M4xBm5f76UXgNysFgH2IAJM/yGps4df77cUgawv0GFu R8C6566j1cMkhW8ZOSQIOyJVnXJmH2g= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=TokE2vNE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of hughd@google.com designates 209.85.167.177 as permitted sender) smtp.mailfrom=hughd@google.com X-Stat-Signature: he15znzq1g8tdzfwosp99dupdpakwoiz X-Rspamd-Queue-Id: 25446A0080 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=TokE2vNE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of hughd@google.com designates 209.85.167.177 as permitted sender) smtp.mailfrom=hughd@google.com X-Rspamd-Server: rspam05 X-HE-Tag: 1657727766-197012 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 13 Jul 2022, Liam Howlett wrote: > * David Hildenbrand [220713 04:34]: > > On 12.07.22 16:24, Liam Howlett wrote: > > > When building with C=1, the maple tree had some rcu type mismatch & > > > locking mismatches in the destroy functions. There were cosmetic only > > > since this happens after the nodes are removed from the tree. > > > > > > Fixes: f8acc5e9581e (Maple Tree: add new data structure) > > > Reported-by: kernel test robot > > > Signed-off-by: Liam R. Howlett > > > > Sorry to say, but the fixes become hard to follow (what/where/why). :) > > > > I guess it's time for a new series soon. Eventually it makes sense to > > send the fixes as reply to the individual problematic patches. (instead > > of fixes to commit ids that are not upstream) > > > > [yes, I'll do more review soon :) ] > > I appreciate the feedback, it's much better than yelling into the void. > I have one more fix in the works - for __vma_adjust() of all functions > so that'll be impossible to follow anyways :) I'll work on a v11 to > include that last one. Please do also post the incremental for that "one more fix" once it's ready: I have been keeping up with what you've been posting so far, folding them into my debugging here, and believe we have made some but still not enough progress on the bugs I hit. Folding in one more fix will be easy for me, advancing to v11 of a 69-part patchset will be... dispiriting. Thanks, Hugh