From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <44DF834E.4020302@garzik.org> Date: Sun, 13 Aug 2006 15:53:50 -0400 From: Jeff Garzik MIME-Version: 1.0 Subject: Re: [RFC][PATCH 8/9] 3c59x driver conversion References: <20060808193447.1396.59301.sendpatchset@lappy> <44D9191E.7080203@garzik.org> <44D977D8.5070306@google.com> <20060808.225537.112622421.davem@davemloft.net> <44DF7FB9.8020003@google.com> In-Reply-To: <44DF7FB9.8020003@google.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Daniel Phillips Cc: David Miller , a.p.zijlstra@chello.nl, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: Daniel Phillips wrote: > That is why it has not yet been submitted upstream. Respectfully, I > do not think that jgarzik has yet put in the work to know if this anti > deadlock technique is reasonable or not, and he was only commenting > on some superficial blemish. I still don't get his point, if there > was one. He seems to be arguing in favor of a jump-off-the-cliff > approach to driver conversion. If he wants to do the work and take > the blame when some driver inevitably breaks because of being edited > in a hurry then he is welcome to submit the necessary additional > patches. Until then, there are about 3 nics that actually matter to > network storage at the moment, all of them GigE. Quite whining and blaming the reviewer for a poor approach. A "this driver is sane, VM-wise" flag is just plain stupid, and clearly fragments drivers. In Linux, "temporary flags"... aren't. Jeff -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org