From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <44D980EB.5010608@garzik.org> Date: Wed, 09 Aug 2006 02:30:03 -0400 From: Jeff Garzik MIME-Version: 1.0 Subject: Re: [RFC][PATCH 8/9] 3c59x driver conversion References: <20060808193447.1396.59301.sendpatchset@lappy> <44D9191E.7080203@garzik.org> <44D977D8.5070306@google.com> <20060808.225537.112622421.davem@davemloft.net> In-Reply-To: <20060808.225537.112622421.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: David Miller Cc: phillips@google.com, a.p.zijlstra@chello.nl, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: David Miller wrote: > From: Daniel Phillips > Date: Tue, 08 Aug 2006 22:51:20 -0700 > >> Elaborate please. Do you think that all drivers should be updated to >> fix the broken blockdev semantics, making NETIF_F_MEMALLOC redundant? >> If so, I trust you will help audit for it? > > I think he's saying that he doesn't think your code is yet a > reasonable way to solve the problem, and therefore doesn't belong > upstream. Pretty much. It is completely non-sensical to add NETIF_F_MEMALLOC, when it should be blindingly obvious that every net driver will be allocating memory, and every net driver could potentially be used with NBD and similar situations. Jeff -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org