From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <44D7E641.6090306@yahoo.com.au> Date: Tue, 08 Aug 2006 11:17:53 +1000 From: Nick Piggin MIME-Version: 1.0 Subject: Re: [patch][rfc] possible lock_page fix for Andrea's nopage vs invalidate race? References: <44CF3CB7.7030009@yahoo.com.au> <44D74B98.3030305@yahoo.com.au> <44D75526.4050108@yahoo.com.au> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Andrea Arcangeli , Andrew Morton , David Howells , Linux Memory Management List-ID: Hugh Dickins wrote: > On Tue, 8 Aug 2006, Nick Piggin wrote: > >>Nick Piggin wrote: >> >>>Generic pagecache doesn't have an mmap method, which is where >>>I stopped looking. I guess you could add the |= to filemap_nopage, >>>but that's much uglier. > > > You can't |= vm_flags in nopage, mmap_sem isn't exclusive there. Well you *could*. So long as nobody else modifies vm_flags under a read lock ;) > But what's the matter with generic_file_mmap? Umm... I don't know. Maybe my eyes? -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org