From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrea Arcangeli <andrea@suse.de>, Andrew Morton <akpm@osdl.org>,
David Howells <dhowells@redhat.com>,
Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [patch][rfc] possible lock_page fix for Andrea's nopage vs invalidate race?
Date: Tue, 08 Aug 2006 11:17:53 +1000 [thread overview]
Message-ID: <44D7E641.6090306@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0608071620001.13736@blonde.wat.veritas.com>
Hugh Dickins wrote:
> On Tue, 8 Aug 2006, Nick Piggin wrote:
>
>>Nick Piggin wrote:
>>
>>>Generic pagecache doesn't have an mmap method, which is where
>>>I stopped looking. I guess you could add the |= to filemap_nopage,
>>>but that's much uglier.
>
>
> You can't |= vm_flags in nopage, mmap_sem isn't exclusive there.
Well you *could*. So long as nobody else modifies vm_flags under
a read lock ;)
> But what's the matter with generic_file_mmap?
Umm... I don't know. Maybe my eyes?
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-08-08 1:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 11:36 Nick Piggin
2006-08-01 14:27 ` Andrea Arcangeli
2006-08-02 0:19 ` Nick Piggin
2006-08-03 16:04 ` Hugh Dickins
2006-08-05 3:52 ` Nick Piggin
2006-08-07 14:18 ` Nick Piggin
2006-08-07 14:58 ` Nick Piggin
2006-08-07 15:25 ` Hugh Dickins
2006-08-08 1:17 ` Nick Piggin [this message]
2006-08-07 17:05 ` Hugh Dickins
2006-08-08 1:14 ` Nick Piggin
2006-08-08 18:19 ` Hugh Dickins
2006-08-03 16:34 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44D7E641.6090306@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=andrea@suse.de \
--cc=dhowells@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox