From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <44CFE98D.2060901@yahoo.com.au> Date: Wed, 02 Aug 2006 09:53:49 +1000 From: Nick Piggin MIME-Version: 1.0 Subject: Re: [patch 1/2] mm: speculative get_page References: <20060801193203.GA191@oleg> <1154447729.10401.16.camel@kleikamp.austin.ibm.com> <20060801204202.GA223@oleg> In-Reply-To: <20060801204202.GA223@oleg> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Oleg Nesterov Cc: Dave Kleikamp , Nick Piggin , Hugh Dickins , Andrew Morton , Andy Whitcroft , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: Oleg Nesterov wrote: > On 08/01, Dave Kleikamp wrote: >>Isn't the page locked when calling remove_mapping()? It looks like >>SetPageNoNewRefs & ClearPageNoNewRefs are called in safe places. Either >>the page is locked, or it's newly allocated. I could have missed >>something, though. > > > No, I think it is I who missed something, thanks. Yeah, SetPageNoNewRefs is indeed called only under PageLocked or for newly allocated pages. I should make a note about that, as it isn't immediately clear. Thanks -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org