From: Martin Bligh <mbligh@google.com>
To: Nate Diller <nate.diller@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
David Howells <dhowells@redhat.com>,
Christoph Lameter <christoph@lameter.com>,
Nick Piggin <npiggin@suse.de>, Linus Torvalds <torvalds@osdl.org>,
Hans Reiser <reiser@namesys.com>,
"E. Gryaznova" <grev@namesys.com>
Subject: Re: [PATCH] mm/tracking dirty pages: update get_dirty_limits for mmap tracking
Date: Wed, 21 Jun 2006 11:13:35 -0700 [thread overview]
Message-ID: <44998C4F.8090502@google.com> (raw)
In-Reply-To: <5c49b0ed0606211001s452c080cu3f55103a130b78f1@mail.gmail.com>
> -int vm_dirty_ratio = 40;
> +int vm_dirty_ratio = 80;
I don't think you can do that. Because ...
> unsigned long available_memory = total_pages;
...
> + dirty = (vm_dirty_ratio * available_memory) / 100;
... there are other things in memory besides pagecache. Limiting
dirty pages to 80% of pagecache might be fine, but not 80%
of total memory.
dirty = (vm_dirty_ratio * (nr_active + nr_inactive)) / 100
might be more sensible. Frankly the whole thing is a crock
anyway, because we should be counting easily freeable clean
pages, not dirty pages, but still.
M.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2006-06-21 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 17:01 Nate Diller
2006-06-21 18:08 ` Nick Piggin
2006-06-21 22:25 ` Nate Diller
2006-06-23 7:31 ` Hans Reiser
2006-06-21 18:13 ` Martin Bligh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44998C4F.8090502@google.com \
--to=mbligh@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=christoph@lameter.com \
--cc=dhowells@redhat.com \
--cc=grev@namesys.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nate.diller@gmail.com \
--cc=npiggin@suse.de \
--cc=reiser@namesys.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox