From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61C88C32772 for ; Fri, 19 Aug 2022 13:51:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C6DB8D0003; Fri, 19 Aug 2022 09:51:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 476608D0001; Fri, 19 Aug 2022 09:51:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3181B8D0003; Fri, 19 Aug 2022 09:51:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2359E8D0001 for ; Fri, 19 Aug 2022 09:51:53 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E9646A0D00 for ; Fri, 19 Aug 2022 13:51:52 +0000 (UTC) X-FDA: 79816480464.16.92C90A2 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf23.hostedemail.com (Postfix) with ESMTP id A7CF3140016 for ; Fri, 19 Aug 2022 13:51:52 +0000 (UTC) Received: by mail-ed1-f41.google.com with SMTP id z20so5717915edb.9 for ; Fri, 19 Aug 2022 06:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=ExRVfq7Dqj4MRK0AfAWWfcL/ahJ1VdZq0IJIIIIDJpY=; b=HJ18yJjQh/UZhfSSatfDFg6Ntdr5PHrz2aXfk8Sp6j86nRlSaHK9f7iQq+BOlUhOOW azcSIXdLYJ8GTT7DTL92fKm5JudxRLgDwoy/KOvzAW/unOj5W2gh/4sMD+py07zZId+G llvAxOQjtgDYwOrqTwptPq3MjvF97fhH/zvLV5dKpyUulA//fxZ3Yv5fiuft7puUvHOU FS1obv218MGt8bDWbYU7CaEcm6Iz1fNRHFuEwi8gnGvJygpF/6x/8xTOAbNmQ7JsM8lV Vl6nMSOD/SHwxbKyF4O2VWRn3HAs4TbmxHvO24czQWWSFw8NM8BHm58N9dpRUZ/SVjLP uZ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=ExRVfq7Dqj4MRK0AfAWWfcL/ahJ1VdZq0IJIIIIDJpY=; b=wKjskqhLwsL63eDDrAHC6ljsANZrwCq4IcoZNNJjmbBxPwUTidyPgfOUj0h+YfMqm1 XTBik++xBEWtXnB/0ApG4V4ruvBmhqoiKH7VBdCl4Y3O0rU4NdwjIP3JYLlizpDcxcfM jAJ8qzC1ShwDYuFEqpzmO5MRi/qWsVXNkxzzlDo4IpqrSdwv0BUonJmwNM409Nr75UOo d7w+DvaZFUBzHobv4Ta2RtSPW/OsK/XxVg+B/oXgckIQO+WCj/VZDdJwDYz/IS732ntl 8BIo+YxZOuaiZ/PN2qvd4atcDUNwdBVrp9wRiYckpyj+kyUiGk2eBG6/qMMDFOWZMKDD iUrw== X-Gm-Message-State: ACgBeo1HCWQTwgq9zWf8+HdS3FlexyoKzoixr+xNfes0605H6gfFPy4N in3EUus66j6EqDGD2chdhxQ= X-Google-Smtp-Source: AA6agR7Qpl3jSwXli1tMFajU9lcJN/pG5JLh1/Lf7iXV3COBC6r11zEme5Yb06eR75yx0uLPgtmZEw== X-Received: by 2002:aa7:dc13:0:b0:443:3f15:8440 with SMTP id b19-20020aa7dc13000000b004433f158440mr5991305edu.274.1660917111163; Fri, 19 Aug 2022 06:51:51 -0700 (PDT) Received: from opensuse.localnet (host-87-17-106-94.retail.telecomitalia.it. [87.17.106.94]) by smtp.gmail.com with ESMTPSA id a9-20020a17090640c900b0072637b9c8c0sm2327610ejk.219.2022.08.19.06.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Aug 2022 06:51:49 -0700 (PDT) From: "Fabio M. De Francesco" To: linux-fscrypt@vger.kernel.org, Eric Biggers Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] fs-verity: use kmap_local_page() instead of kmap() Date: Fri, 19 Aug 2022 09:50:37 +0200 Message-ID: <44912540.fMDQidcC6G@opensuse> In-Reply-To: <20220818224010.43778-1-ebiggers@kernel.org> References: <20220818224010.43778-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660917112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ExRVfq7Dqj4MRK0AfAWWfcL/ahJ1VdZq0IJIIIIDJpY=; b=BnCN3aibyPmBYsDvLouj7jdlLiee9N2Oaae2YACL+zx5tmqqKuqimqvLO5pRqVnmuUfqY+ xblPE6hUIoG0ph4OuLArxPDzLV6jnvNPM+xxLVBTuqW2UU/8YWDgQGpfpHcLY9UYthVinP Swy3xWtRndsPXA1pYOog1zP0wIOuBFk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HJ18yJjQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660917112; a=rsa-sha256; cv=none; b=Tz9TVCMyIadfSMiWteNSDK0o2q3HJEyo6NeGU+WWRclLF/swMkSBeI/BzwGpzwWYkYymz7 Z8NcaHasr50qsWiAgKhZMn1k9EtUtJi05/dNwvBkNG94YhiRnN91pf0KGrTIxpgll74HQn LEipAIkVGtW8ZaF7bitzmefFOl0NuOs= X-Stat-Signature: 6re5u6g9qqq91mbctyjdts1no6sfjj1k X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A7CF3140016 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HJ18yJjQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com X-Rspam-User: X-HE-Tag: 1660917112-880775 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On venerd=C3=AC 19 agosto 2022 00:40:10 CEST Eric Biggers wrote: > From: Eric Biggers >=20 > Convert the use of kmap() to its recommended replacement > kmap_local_page(). This avoids the overhead of doing a non-local > mapping, which is unnecessary in this case. >=20 > Signed-off-by: Eric Biggers > --- > fs/verity/read_metadata.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) It looks good to me... Reviewed-by: Fabio M. De Francesco Thanks, =46abio > diff --git a/fs/verity/read_metadata.c b/fs/verity/read_metadata.c > index 6ee849dc7bc183..2aefc5565152ad 100644 > --- a/fs/verity/read_metadata.c > +++ b/fs/verity/read_metadata.c > @@ -53,14 +53,14 @@ static int fsverity_read_merkle_tree(struct inode=20 *inode, > break; > } >=20 > - virt =3D kmap(page); > + virt =3D kmap_local_page(page); > if (copy_to_user(buf, virt + offs_in_page, bytes_to_copy))=20 { > - kunmap(page); > + kunmap_local(virt); > put_page(page); > err =3D -EFAULT; > break; > } > - kunmap(page); > + kunmap_local(virt); > put_page(page); >=20 > retval +=3D bytes_to_copy; >=20 > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > prerequisite-patch-id: 188e114bdf3546eb18e7984b70be8a7c773acec3 > -- > 2.37.1