From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 277CAE7D246 for ; Tue, 26 Sep 2023 07:34:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9978C6B017D; Tue, 26 Sep 2023 03:34:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 922D46B017E; Tue, 26 Sep 2023 03:34:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79C026B017F; Tue, 26 Sep 2023 03:34:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5B9246B017D for ; Tue, 26 Sep 2023 03:34:18 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1A39C1211AF for ; Tue, 26 Sep 2023 07:34:18 +0000 (UTC) X-FDA: 81277935396.12.FAB68F6 Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by imf25.hostedemail.com (Postfix) with ESMTP id CFB87A0009 for ; Tue, 26 Sep 2023 07:34:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b="Rkj4/ro9"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=AUbkuoyp; dmarc=none; spf=pass (imf25.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.24 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695713656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LBGMXw95teWGAkpYjMD4yl8r6TRMMDISQAqR/M1cGNQ=; b=LFpIS+hId18XukXQ3t9SgSa9aIGABkO614+LrfKt9KAAaCBVSr7aMwLhqSjoJCBdOi8aGz QXDARHfYJI/Qjm3CpQAD2AyLhB/ju24dnUG4LdFbf6Mmd0VHFOWwjAY3XyWwqlvYRj8Olg 1ovUgOkfCUH5CAmyVdLxMngoPncsOS8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b="Rkj4/ro9"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=AUbkuoyp; dmarc=none; spf=pass (imf25.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.24 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695713656; a=rsa-sha256; cv=none; b=GOsWX3rhytQ4dXgc/7Z7CLTiYcHlsG5dlAJO14XF3GqJfF6XtyLtm1yXFvQNbdQMJeKtsf lST6X/pf96xiaAhbk9G6K99i+sRlxSF6SjBJSP3Ainj/joKOMSFMYsVO2PuoRfyo4ZMR7T xLrSM/fSpyRCMgEVQoLigHLoxfPLrEg= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C07C03200962; Tue, 26 Sep 2023 03:34:10 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 26 Sep 2023 03:34:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1695713650; x=1695800050; bh=LB GMXw95teWGAkpYjMD4yl8r6TRMMDISQAqR/M1cGNQ=; b=Rkj4/ro9taZZHblsOD /G8RJaZMr5EoZi3BiBVuPydXcqLBt6JUnEwEBSkbH9zdT7CVUQuwhIR4vjOvrJz7 RZ3Epil4/1SvO77nFH1rFPyl9t2f+Q3SRKIN5+S4FzuiUdD22wwkSW/OYnjpuALL HtrICoJLxOpcEVcHu9AQxv5pZ6n5GVT1uDBGpmDdsYnAQw6s5OIHZilwNqnUGPkm 4OjsMTRyNEOUw1tZgRF9dlyeKj8s8seL81kM8PIIQFyxX0qyog9Nsf+CDsm3zk8h ezgMFSodT5jl9S32PkpOMs3SS0XWcl664oOOjadAHKGA1Ihbl0lrhFruTxPcgfco mn5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695713650; x=1695800050; bh=LBGMXw95teWGA kpYjMD4yl8r6TRMMDISQAqR/M1cGNQ=; b=AUbkuoypa4Wsdj208B6uCagaZC/Xk A1dPx5DaS9T0xX5d79iQJKairrxWJfzJIhsL7KqjrQbLgE5SLde8s6vzO2Sgu7sc 06ynHhZftaf9a44gz/tuW8lW6ktE/LPxdi/tVwr9o/giNuQS7K9R78duFOULJVvk 1k2A1E6wKGy90242NbwgZjUpS/iNNlAkmDAYcKfQzd00vuPUSehSxxUFVE1h0t2e NLQf14NhEcO8lrG9/A5cKEmPG4gi+I2E+epzgguRRtykOaSiMVKbfBpOOt0GKV+w YvfRUboIrciFszM3IJHagkCio2kLoAGar1HvM8dXPFSk3ZdLkcytutiKA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudelhedguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeegteeihfejvdfhfeffhfdvvddvfffgtedvteeigfehhfehudffleejuedu vdelgfenucffohhmrghinhepphgrshhtvggsihhnrdgtohhmnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4513AB60089; Tue, 26 Sep 2023 03:34:09 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-957-ga1ccdb4cff-fm-20230919.001-ga1ccdb4c MIME-Version: 1.0 Message-Id: <44867c60-db1a-4a0c-8973-c8a03e8da0f3@app.fastmail.com> In-Reply-To: <20230918072955.2507221-11-rppt@kernel.org> References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-11-rppt@kernel.org> Date: Tue, 26 Sep 2023 09:33:48 +0200 From: "Arnd Bergmann" To: "Mike Rapoport" , linux-kernel@vger.kernel.org Cc: "Andrew Morton" , =?UTF-8?Q?Bj=C3=B6rn_T=C3=B6pel?= , "Catalin Marinas" , "Christophe Leroy" , "David S . Miller" , "Dinh Nguyen" , "Heiko Carstens" , "Helge Deller" , "Huacai Chen" , "Kent Overstreet" , "Luis Chamberlain" , "Mark Rutland" , "Michael Ellerman" , "Nadav Amit" , "Naveen N. Rao" , "Palmer Dabbelt" , "Puranjay Mohan" , "Rick Edgecombe" , "Russell King" , "Song Liu" , "Steven Rostedt" , "Thomas Bogendoerfer" , "Thomas Gleixner" , "Will Deacon" , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, Netdev , sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 10/13] arch: make execmem setup available regardless of CONFIG_MODULES Content-Type: text/plain X-Rspamd-Queue-Id: CFB87A0009 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: c6ane4zq7wwk4eyxwjrn6becjptxe7cd X-HE-Tag: 1695713655-117065 X-HE-Meta: U2FsdGVkX18nKMjDVabLmSN4d/+TV+Q7QacVb55j7R4uExXr23cRwTTlMwp2XV/2RQhGKtg7enGnguVycU4swEWfjQw3y1gLW3V7m9czEPs8T0JpxMs43mFYZMcOOzFwu7HfYtpFuAZo3/KWMUIbWqscYyfBqSxMEpO/fV+75RNwQ1WDSAQZX97guTOCLc6Uaf43UCuZQXRcBY9y5d190Otck2pBsmn+E9sZbmjD/JOZWj1fg0RWNBntHzDk49o898Hno9XLIErRGuj+zBZypzcIasE4u5rAhtPu5X+uE100wcjn1FGTDcRujT1o+nLfMOg4snn5s0g/gdKvGgYZtivyF74B2QwWZ/Fg5HSUbeqxNOB4vTjktq/RVsPyQeZa4rNA9scvtKPiSUJDBieu71fprY+5EF2Q0mMwYkLCzPEzwzZ9+Rc0ISa47AFw0hnMg1nOTozMwArcVMT/xO+XYVKphuJ+dZBaBCPd5deqwCH64W4YAm89uB6BGGEu2jASTD6kHwtEyA4tsosxdqltHAZEBPn46OFA0yHXD10OrSBKIk71XhadupKzt99BhaoyDmAaGKCzXda8TToL/Djs1KMb7Bd9MFtdKmrM1udl9U0ROr+PBjEg5fZIgEG0x32H3LBDnoE8Dmt9D8jOyYaiezB5Nhx5x4l0fzC+fa9PWzSH6AOBz2Pi1dN3WECg96XkvM+0+Bj8YYKwa4LZDd6a7FY1H+oKduncgkcaqqZi39o+BO2vibeA7waRdnzjnNoPcEVgjt7mDUfiu5+I+Ga8y2oZV2E21nQlQGnC2k+S7xO78ArXsHCIzahm/Qe9KW+kdNcz+gSCOZ6Vm/bEVBE9do7FPqUg77Eezh2YrNURDmgPgv1Cedes2p9NbORBVKSEG8gx5pqLA4JEj9QYVWBFMnzKUtWjaUBVPmQsmXuhdtHb08zktyF81Oex6TULwAy6OY1Kaz5RaKmYkUIJ5/x +yeLxiR9 3gfS9mI+2RHNXNA0wCja7nnYZo4KostKCIIreAwTU7PtrD7laKYu/LBkQxFhISC+LuG8urxa3LeSC/AVF54KvszHo/+57s/ZoTTd/k2TNCQWk2e2jUpryUjQtw6utaf6Q0OsAlPlhjdcTVpo4/6kaQKQElbSRsOblOdM0WfK6u3c8UGvVWpxX16/tddkWCOgSr25hClkvIjHEVhXwpAxEmg5fXXuN41ACPFjpznpJfWLCPLD192hCiDn1ng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 18, 2023, at 09:29, Mike Rapoport wrote: > index a42e4cd11db2..c0b536e398b4 100644 > --- a/arch/arm/mm/init.c > +++ b/arch/arm/mm/init.c > +#ifdef CONFIG_XIP_KERNEL > +/* > + * The XIP kernel text is mapped in the module area for modules and > + * some other stuff to work without any indirect relocations. > + * MODULES_VADDR is redefined here and not in asm/memory.h to avoid > + * recompiling the whole kernel when CONFIG_XIP_KERNEL is turned > on/off. > + */ > +#undef MODULES_VADDR > +#define MODULES_VADDR (((unsigned long)_exiprom + ~PMD_MASK) & > PMD_MASK) > +#endif > + > +#if defined(CONFIG_MMU) && defined(CONFIG_EXECMEM) > +static struct execmem_params execmem_params __ro_after_init = { > + .ranges = { > + [EXECMEM_DEFAULT] = { > + .start = MODULES_VADDR, > + .end = MODULES_END, > + .alignment = 1, > + }, This causes a randconfig build failure for me on linux-next now: arch/arm/mm/init.c:499:25: error: initializer element is not constant 499 | #define MODULES_VADDR (((unsigned long)_exiprom + ~PMD_MASK) & PMD_MASK) | ^ arch/arm/mm/init.c:506:34: note: in expansion of macro 'MODULES_VADDR' 506 | .start = MODULES_VADDR, | ^~~~~~~~~~~~~ arch/arm/mm/init.c:499:25: note: (near initialization for 'execmem_params.ranges[0].start') 499 | #define MODULES_VADDR (((unsigned long)_exiprom + ~PMD_MASK) & PMD_MASK) | ^ arch/arm/mm/init.c:506:34: note: in expansion of macro 'MODULES_VADDR' 506 | .start = MODULES_VADDR, | ^~~~~~~~~~~~~ I have not done any analysis on the issue so far, I hope you can see the problem directly. See https://pastebin.com/raw/xVqAyakH for a .config that runs into this problem with gcc-13.2.0. Arnd