From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34258C369D3 for ; Mon, 28 Apr 2025 09:23:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 357456B002E; Mon, 28 Apr 2025 05:23:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DFF06B002F; Mon, 28 Apr 2025 05:23:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 133646B0030; Mon, 28 Apr 2025 05:23:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E50E06B002E for ; Mon, 28 Apr 2025 05:23:33 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 357B51CF9F8 for ; Mon, 28 Apr 2025 09:23:35 +0000 (UTC) X-FDA: 83382914790.26.0BE91FA Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf11.hostedemail.com (Postfix) with ESMTP id A569940005 for ; Mon, 28 Apr 2025 09:23:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=S1d90qh8; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of leon@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745832213; a=rsa-sha256; cv=none; b=Bdzp1i5sDF6WwVc/VzMVqs8wmnmy9jmT5Y24mow1Ag1OKLYGudXoV5HStyaSftMIyP4clY N8Fl5Eu9VjopvqLDaGi0u+0b145jrevUOQJc+b3A2S5MgB0UdPhpQJLLrYLypGZK3kGsfw RwebxXPvey1VhJpmBMvjFWv+C8Z5zaE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=S1d90qh8; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of leon@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745832213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0/3N3K7XZccfvrp8qdj4h6IoKH4QoumzCs4XS69VK+U=; b=cVHRGc6FrKr1leP5+OqZ+TkvUdCmCRdwwP+L1a2R6NqQVwxSbu9bZpsom3EAEJs3+j6MSy iO7OTeOmZue2Kz0ujY38eDIFqdGREZHxW+PC0Pdsf6C2+ymoRzvKNHB0QHILagZbz08Qf3 10r2kuACrelaeYpfgfhsR1LtSE/cpdw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 6BFC76115E; Mon, 28 Apr 2025 09:23:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31E69C4CEE9; Mon, 28 Apr 2025 09:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745832212; bh=zDzlqykv86nTBfYEytc8wm5wkFShzSQKAsrmEhNbBwU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S1d90qh8CUE1R68AnclyKFgyc3M3PH8lRc6WjFsjygRgtWsAEkSuXRwZyPk5H2mWM yCIjmPjwBIzNqNOH29THOBXxLDDuAZw5RIzE+DbuJITHoomDA8eEEMQ24PeQgAyr9A zmhitSbQdvMeIgR+oZ5F+ZZ8YiqyBnwmEK2fSCJajwUgYutk+OX5i7mjlkL88cgAmv AYmthdpUSXspJkugyHwrF2tpdEh2aUssZitwTMgxeS9uC/9y7HeLUu/Ov6P8e9WkBZ RDhA7gkiFAOg5KHkp69Haf5Or2OAtnLQpJilA1Vti+fDK5ZkFfVMcaWVVXQOIyx3E/ fi+Uw3fAUJHUg== From: Leon Romanovsky To: Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch Cc: Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni , Leon Romanovsky Subject: [PATCH v10 08/24] dma-mapping: add a dma_need_unmap helper Date: Mon, 28 Apr 2025 12:22:14 +0300 Message-ID: <448112d7b47869724d99b00de052127fc9d81612.1745831017.git.leon@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A569940005 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: e7ycyy7xjtegyf76hfp3y1jakenedwew X-HE-Tag: 1745832213-750842 X-HE-Meta: U2FsdGVkX18w2Sez6WmDBRgG/bXQASZTOXiMEqqixlRytWH50ha9L9iQ/GiMR5NJu9l6KVo8xp8JA/VmpDpwsZTIx/IkPyABHNbVturpNlD9+Jrygbv51pnMTRX9sK57DJrMQpsjo6GZeM53pf4tYYFCg9j+m1u/vcGuDj2k8w0p+eWwmJWN2FxchjutZFBe9IgS1kAwMvT9IC7DO/tdhGzaKOAjaIyw9BpA2YGUwtNjJmgvRtw9k/oT8o1NqeCOyKU/yNIHDzhSglE9OIE+TIsuR80jlAEOuLLIH6PaLBIVmfJACbmK6CGcwW7p842XN4+L27VS9c5ZGETNC0/uFMj6oNbSnPe7z4A6ILtGyTU+aYsHxwQYpco1351AzKrTClxAj6THcsfUuGbhtWc5CuJ/DhfO4jMdFTjV156Qi+hHlk7NPV/6K8fZwKpWpz1zOkCtPigvWC8NYDnQUZW2gMhrELzyOv2dzkMnnFpz6nRnFAfkLwyr7hMsq17zwZ0aEU/9MLH9Cr/wbKtoae8wG2XhsuGaDYPb1H3NqaiGof7GZQHkXXru18ZJWHnJInCmYVtHVJa8uX1qgdE1ekN2O6riTmwq1TUYl437vgpAMFoL/yE3gVxOIaKqHV1BZnsgkkknT450pkscm20vebOLxPXgGrju4ugbu41EonxoJPdcqJNVnU0BDTcggNfjJjT3sto+98UpsS3ZjmXZOQPPSl9Ku+6u9ev+GZ9PmQg1qX+PxI44fgQFuANIrPFSZGeRVsNa8evqZpAFRoEt/xL8X++4Ux3qF233MUFT2ja4p5XLSSvaZKyzx/fvL1QwmkVtA9pnRw3o87dcj4VJMkFiEpBnkw/eWrgzodBMiFjIZ8lWSK5Q4s9wEFQRLUsNPcsIXYO+kkt18GDfTGcRoaBBK3nEz0gNyIrcxGT1Tdg9sh56uLIUBxmYtvLqwN5LZaq0lLFFvJofCdjcTd5pTXT 3UFyevDS DHUWIobe8TekioWJKmCRuJKd3eTOtr+El9pAWx9CP/MaZ9268e25AD0aDWBrBw3+TwhiDAe1qv5DLW6ZBQ21c1BHTNMtEIIvX20ixpeGhMWDSvAFuK4omy4L74Zn7EAtu6/+GdpYusD50uHPtyJ+3zAM6mntCQtHOlw6tdIaeN32ssMpNvLpF+bTSAv277MpB+oBR7NhBq5wQTY2DD/4u9gdSXGXaW9lN4tzc/qMWRKu9Tfa/5b5cBvphyW5cyFyk5gyuueOuDs6BYknIyzstxO6IePbSaBBd5cI0OXax74n+TEQ/CZ17DwS4qw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Christoph Hellwig Add helper that allows a driver to skip calling dma_unmap_* if the DMA layer can guarantee that they are no-nops. Signed-off-by: Christoph Hellwig Tested-by: Jens Axboe Reviewed-by: Luis Chamberlain Signed-off-by: Leon Romanovsky --- include/linux/dma-mapping.h | 5 +++++ kernel/dma/mapping.c | 18 ++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index a71e110f1e9d..d2f358c5a25d 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -406,6 +406,7 @@ static inline bool dma_need_sync(struct device *dev, dma_addr_t dma_addr) { return dma_dev_need_sync(dev) ? __dma_need_sync(dev, dma_addr) : false; } +bool dma_need_unmap(struct device *dev); #else /* !CONFIG_HAS_DMA || !CONFIG_DMA_NEED_SYNC */ static inline bool dma_dev_need_sync(const struct device *dev) { @@ -431,6 +432,10 @@ static inline bool dma_need_sync(struct device *dev, dma_addr_t dma_addr) { return false; } +static inline bool dma_need_unmap(struct device *dev) +{ + return false; +} #endif /* !CONFIG_HAS_DMA || !CONFIG_DMA_NEED_SYNC */ struct page *dma_alloc_pages(struct device *dev, size_t size, diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c index cda127027e48..3c3204ad2839 100644 --- a/kernel/dma/mapping.c +++ b/kernel/dma/mapping.c @@ -443,6 +443,24 @@ bool __dma_need_sync(struct device *dev, dma_addr_t dma_addr) } EXPORT_SYMBOL_GPL(__dma_need_sync); +/** + * dma_need_unmap - does this device need dma_unmap_* operations + * @dev: device to check + * + * If this function returns %false, drivers can skip calling dma_unmap_* after + * finishing an I/O. This function must be called after all mappings that might + * need to be unmapped have been performed. + */ +bool dma_need_unmap(struct device *dev) +{ + if (!dma_map_direct(dev, get_dma_ops(dev))) + return true; + if (!dev->dma_skip_sync) + return true; + return IS_ENABLED(CONFIG_DMA_API_DEBUG); +} +EXPORT_SYMBOL_GPL(dma_need_unmap); + static void dma_setup_need_sync(struct device *dev) { const struct dma_map_ops *ops = get_dma_ops(dev); -- 2.49.0