From: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>
Subject: Re: [Experimental][PATCH 21/21]memcg-new-hierarchical-reclaim.patch
Date: Thu, 4 Dec 2008 21:44:52 +0900 (JST) [thread overview]
Message-ID: <44799.10.75.179.61.1228394692.squirrel@webmail-b.css.fujitsu.com> (raw)
In-Reply-To: <20081204200037.63ff03c9.nishimura@mxp.nes.nec.co.jp>
Daisuke Nishimura said:
> On Wed, 3 Dec 2008 14:14:23 +0900, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> Implement hierarchy reclaim by cgroup_id.
>> + rcu_read_lock();
>> + if (!root_mem->use_hierarchy) {
>> + spin_lock(&root_mem->reclaim_param_lock);
>> + root_mem->scan_age++;
>> + spin_unlock(&root_mem->reclaim_param_lock);
>> + css_get(&root_mem->css);
>> + goto out;
>> }
>>
> I think you forgot "ret = root_mem".
> I got NULL pointer dereference BUG in my test(I've not tested
> use_hierarchy case yet).
>
yes...thank you for catching. will fix.
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-12-04 12:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 4:47 [PATCH 0/21] memcg updates 2008/12/03 KAMEZAWA Hiroyuki
2008-12-03 4:48 ` [PATCH 1/21] memcg-revert-gfp-mask-fix.patch KAMEZAWA Hiroyuki
2008-12-03 4:50 ` [PATCH 2/21] memcg-check-group-leader-fix.patch KAMEZAWA Hiroyuki
2008-12-03 4:51 ` [PATCH 3/21] memcg-memoryswap-controller-fix-limit-check.patch KAMEZAWA Hiroyuki
2008-12-03 4:52 ` [PATCH 4/21] memcg-swapout-refcnt-fix.patch KAMEZAWA Hiroyuki
2008-12-03 4:53 ` [PATCH 5/21] memcg-hierarchy-avoid-unnecessary-reclaim.patch KAMEZAWA Hiroyuki
2008-12-03 4:54 ` [PATCH 6/21] inactive_anon_is_low-move-to-vmscan.patch KAMEZAWA Hiroyuki
2008-12-03 4:55 ` [PATCH 7/21] introduce-zone_reclaim-struct.patch KAMEZAWA Hiroyuki
2008-12-03 4:55 ` [PATCH 8/21] make-zone-nr_pages-helper-function.patch KAMEZAWA Hiroyuki
2008-12-03 4:57 ` [PATCH 9/21] make-get_scan_ratio-to-memcg-safe.patch KAMEZAWA Hiroyuki
2008-12-03 4:58 ` [PATCH 10/21] memcg-add-null-check-to-page_cgroup_zoneinfo.patch KAMEZAWA Hiroyuki
2008-12-03 5:00 ` [PATCH 11/21] memcg-make-inactive_anon_is_low.patch KAMEZAWA Hiroyuki
2008-12-03 5:01 ` [PATCH 12/21] memcg-make-mem_cgroup_zone_nr_pages.patch KAMEZAWA Hiroyuki
2008-12-03 5:02 ` [PATCH 13/21] memcg-make-zone_reclaim_stat.patch KAMEZAWA Hiroyuki
2008-12-03 5:04 ` [PATCH 14/21] memcg-remove-mem_cgroup_cal_reclaim.patch KAMEZAWA Hiroyuki
2008-12-03 5:05 ` [PATCH 15/21] memcg-show-reclaim-stat.patch KAMEZAWA Hiroyuki
2008-12-03 5:06 ` [PATCH 16/21] memcg-rename-scan-glonal-lru.patch KAMEZAWA Hiroyuki
2008-12-03 5:08 ` [PATCH 17/21] memcg_prev_priority_protect.patch KAMEZAWA Hiroyuki
2008-12-03 5:09 ` [PATCH 18/21] memcg-swappiness.patch KAMEZAWA Hiroyuki
2008-12-03 5:11 ` [Experimental][PATCH 19/21] memcg-fix-pre-destroy.patch KAMEZAWA Hiroyuki
2008-12-04 9:34 ` Daisuke Nishimura
2008-12-04 9:43 ` KAMEZAWA Hiroyuki
2008-12-04 9:49 ` KAMEZAWA Hiroyuki
2008-12-04 10:17 ` Daisuke Nishimura
2008-12-03 5:12 ` [Experimental][PATCH 20/21] cgroup_id.patch KAMEZAWA Hiroyuki
2008-12-03 5:14 ` [Experimental][PATCH 21/21] memcg-new-hierarchical-reclaim.patch KAMEZAWA Hiroyuki
2008-12-04 11:00 ` Daisuke Nishimura
2008-12-04 12:44 ` KAMEZAWA Hiroyuki [this message]
2008-12-03 5:15 ` [PATCH 22/21] memcg-explain-details-and-test-document.patch KAMEZAWA Hiroyuki
2008-12-03 5:20 ` [PATCH 0/21] memcg updates 2008/12/03 KAMEZAWA Hiroyuki
2008-12-03 5:56 ` Andrew Morton
2008-12-03 6:17 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44799.10.75.179.61.1228394692.squirrel@webmail-b.css.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox