From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77518C433EF for ; Wed, 9 Mar 2022 11:22:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA7CB8D0003; Wed, 9 Mar 2022 06:22:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2E7F8D0001; Wed, 9 Mar 2022 06:22:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD3EA8D0003; Wed, 9 Mar 2022 06:22:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id A82618D0001 for ; Wed, 9 Mar 2022 06:22:37 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6C5972294E for ; Wed, 9 Mar 2022 11:22:37 +0000 (UTC) X-FDA: 79224609954.10.435B958 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf02.hostedemail.com (Postfix) with ESMTP id 9D4FD8000E for ; Wed, 9 Mar 2022 11:22:36 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 82633B820BA; Wed, 9 Mar 2022 11:22:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44F3FC340E8; Wed, 9 Mar 2022 11:22:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646824953; bh=jxlnwAkD26Indg1Wp4iaXXBb6KhNjNVN8WZQUMdJDUI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FOk0fSnc19L2j5UAtvXQvtRY4RYr/l7kxzdR9Gl68NooSX3kGWoAlrRXkVJmTkT+0 Oz4ifAQIzYaSQDpKN+wJI/f87gs91bo4Me9zJdVbNicxci1qFgUuD9l0ctD25T3Qv/ EuxnOaj6Ond0+qXWgaiQtbDV5mSeG/5uc/4RvWrlEXXrtp58lXfADYy1v9cGXkD0tY aI/btsHOvBHdydWAFeyu8S2wwlnFZp5QAsF9tFC0qaDSXon+9sHxrhTHqWLkZJv7IX cvK6jkdQkR2kmW3PkDKeHpIU5vzCmssAOZ2IU+ROZdXxzNEWvP8oH5BVYVYl0SSEnl HVgrnKS/A548g== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nRuOl-00DIhM-3T; Wed, 09 Mar 2022 11:22:31 +0000 MIME-Version: 1.0 Date: Wed, 09 Mar 2022 11:22:30 +0000 From: Marc Zyngier To: kernel test robot Cc: Qianggui Song , kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 10152/11353] drivers/irqchip/irq-meson-gpio.c:351:45: warning: variable 'params' set but not used In-Reply-To: <202203082010.Qn0EhDWH-lkp@intel.com> References: <202203082010.Qn0EhDWH-lkp@intel.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <446eb08c642e385cc7dd4ffbe7017e57@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lkp@intel.com, qianggui.song@amlogic.com, kbuild-all@lists.01.org, linux-mm@kvack.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9D4FD8000E X-Stat-Signature: asee6nr37ng951i5w1y5h5nwijigwx5d Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FOk0fSnc; spf=pass (imf02.hostedemail.com: domain of maz@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=maz@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-HE-Tag: 1646824956-774733 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022-03-08 12:34, kernel test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > master > head: cb153b68ff91cbc434f3de70ac549e110543e1bb > commit: d8a61a2ec7e75723083d33800423b151106922e0 [10152/11353] > irqchip/meson-gpio: Add support for meson s4 SoCs > config: h8300-buildonly-randconfig-r004-20220307 > (https://download.01.org/0day-ci/archive/20220308/202203082010.Qn0EhDWH-lkp@intel.com/config) > compiler: h8300-linux-gcc (GCC) 11.2.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d8a61a2ec7e75723083d33800423b151106922e0 > git remote add linux-next > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout d8a61a2ec7e75723083d33800423b151106922e0 > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 > make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash drivers/irqchip/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > drivers/irqchip/irq-meson-gpio.c: In function > 'meson_s4_gpio_irq_set_type': >>> drivers/irqchip/irq-meson-gpio.c:351:45: warning: variable 'params' >>> set but not used [-Wunused-but-set-variable] > 351 | const struct meson_gpio_irq_params *params; > | ^~~~~~ > > > vim +/params +351 drivers/irqchip/irq-meson-gpio.c > > 330 > 331 /* > 332 * gpio irq relative registers for s4 > 333 * -PADCTRL_GPIO_IRQ_CTRL0 > 334 * bit[31]: enable/disable all the irq lines > 335 * bit[12-23]: single edge trigger > 336 * bit[0-11]: polarity trigger > 337 * > 338 * -PADCTRL_GPIO_IRQ_CTRL[X] > 339 * bit[0-16]: 7 bits to choose gpio source for irq line 2*[X] - > 2 > 340 * bit[16-22]:7 bits to choose gpio source for irq line 2*[X] - > 1 > 341 * where X = 1-6 > 342 * > 343 * -PADCTRL_GPIO_IRQ_CTRL[7] > 344 * bit[0-11]: both edge trigger > 345 */ > 346 static int meson_s4_gpio_irq_set_type(struct > meson_gpio_irq_controller *ctl, > 347 unsigned int type, u32 *channel_hwirq) > 348 { > 349 u32 val = 0; > 350 unsigned int idx; > > 351 const struct meson_gpio_irq_params *params; > 352 > 353 params = ctl->params; Squashed the fix into the original commit (deleting these 2 lines). M. -- Jazz is not dead. It just smells funny...