From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D4DE77188 for ; Mon, 30 Dec 2024 19:52:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 320D26B00A8; Mon, 30 Dec 2024 14:52:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A81F6B00AA; Mon, 30 Dec 2024 14:52:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AD256B00AB; Mon, 30 Dec 2024 14:52:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DA7876B00A8 for ; Mon, 30 Dec 2024 14:52:12 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5D3871A0A3C for ; Mon, 30 Dec 2024 19:52:12 +0000 (UTC) X-FDA: 82952670780.11.A9FCA33 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id C5CCD8000D for ; Mon, 30 Dec 2024 19:50:39 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bPj2mikC; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735588286; a=rsa-sha256; cv=none; b=fWBQUO3VqzpokMMGShwUxu1xp0TrADmT1FqnjOaeGvPfpUOK8YlaJVRfV8ccZAFAV2A49W XyX41o0YqrxyjzpsCUweWQ5w56qWorrk4WcSxXympfrvajwKwf7yq52l1PJM5ery4frvIp gvxsMkIH0PcebY0ZvKOzlastNTEsjjo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bPj2mikC; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735588286; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FMNDW99s41EelbmyuRNIhiw1B6HcvlNy1zjoDEXzZN4=; b=YTO2pqPNFJsnDcqgX6U3/h8PvMKHegUPFBLT25DDUcPFxKRSTH//JgapTW8TcrNL3FCXC/ YKcFqlKa8L+3hXYh46ZBiknFjSfrCBIUtsN1pwTzmsvs9vxn5Gib94IoAjfuAw/a2pwClC i1xhFvWCrWqVmGvhaWv7udO5U90LZds= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1735588329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FMNDW99s41EelbmyuRNIhiw1B6HcvlNy1zjoDEXzZN4=; b=bPj2mikCUGhMhl4q+72KCmGG1GBQ2kU462cekTn2Uv06MVYuqp0fgjHzkGhxt6VQnRFKB7 5bU09DWgCGuAPMHCUIIYpgSWab4UPLs9xoixrctallLi3nng9rNDDeQs+5OqJ9x5ZbeOUg MBLIFy+IMa+NWPq2rGPeYoflIyGaHAk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-80za99uHOp-gif_EEdHtkw-1; Mon, 30 Dec 2024 14:52:08 -0500 X-MC-Unique: 80za99uHOp-gif_EEdHtkw-1 X-Mimecast-MFC-AGG-ID: 80za99uHOp-gif_EEdHtkw Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43623bf2a83so69963515e9.0 for ; Mon, 30 Dec 2024 11:52:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735588327; x=1736193127; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FMNDW99s41EelbmyuRNIhiw1B6HcvlNy1zjoDEXzZN4=; b=uXuoSqEncItYDm111wxrDIEfOPMe7gC/s0k8JS05wyRjsdPmNdbYQ1N1GoM7mJ2bj1 LQWNe4twUIRE0Rw98pOZ/LboUKRHsI2/BPODJbCSpTZvcLCGeaqUcoE/TdzXhirvY0Kd /94EqnarDHtSu40RvGqygvPUUxYcjccRFmpZTABLKF2MRYeSUNxrKMoiTSqGY/hdlMSn t2t3l7omVGD1wyUgAQ2HT4kzuwmFCs7oAvZCvK7MSssaqzF04Hgl3CI9RYCBn8lfMivC u+tpNehjZuAcEngOjpc0kQvQvoZ9NT/qbTxnHNACoayFJiNhk8fNKm6WBsAUySVSFhkP lzlA== X-Forwarded-Encrypted: i=1; AJvYcCUVhiL3SEDWyLyQnw4AOCp8huEDIKSLPinthCuHCCiS1+WTeLZdFL1bxBrGBrvPnB+ZkmnaKiOS2g==@kvack.org X-Gm-Message-State: AOJu0YziZpFyMIIxRg36tk9W0L7dN04gj6ozRH8JT+yzJgViWLimHbxu ngQ8hOJzbRQkjUh//4NngsHnpvHJmYBK97LxBSEaOh+lIB1Bj2wfcb34VCMS/0IcB+Nwwmn0V2y caLepB/txmXJa7SbD0O5bVdZDaPGDaJ47Mar7vvEAVcGe4Uog X-Gm-Gg: ASbGncvkCEujrSO9Yzm4a7P+R8gleVrpq7Kc9hzixWCjO3ueiA4/fQDAQb5VMsowuTl +zjvF0mf6ZjHbbWi8i33GNyXX4MBPbG30bIJ/g7pCnBge9G0xDsa0MJOpGPmcbauR19SDajF4SY gl2YTPTZw1FzgepMu4DamHZSqlC962rLr9iAowa657JywuhUHb2TUhe4hhbCaYODBrcomzEvNSJ iScabjnX8FtnxikNNfvYKVG7S+h7Z7RFTonZAilLPw12i9e5RDsTResc8pw2esVJFOnSb2BcSJa tfyEZvXmaiMUfpuudqlaHm+kbnGCtyP2sWzspQ9mNgFJrPlrx0N9a79kHgmQfMXtrBq9ZPzaoSl w87pX0sEh X-Received: by 2002:a05:600c:3507:b0:434:f7e3:bfa0 with SMTP id 5b1f17b1804b1-43668b5e090mr275550475e9.21.1735588326902; Mon, 30 Dec 2024 11:52:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGodv7uYIQitXvNfGr/YSKUWSViIzuVIVcfXqyQaqMKyFGQasRUq7guc82PNrQQjx10fwoILw== X-Received: by 2002:a05:600c:3507:b0:434:f7e3:bfa0 with SMTP id 5b1f17b1804b1-43668b5e090mr275550295e9.21.1735588326499; Mon, 30 Dec 2024 11:52:06 -0800 (PST) Received: from ?IPV6:2003:cb:c718:5800:c745:7e74:aa59:8dbe? (p200300cbc7185800c7457e74aa598dbe.dip0.t-ipconnect.de. [2003:cb:c718:5800:c745:7e74:aa59:8dbe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b119b6sm402438725e9.22.2024.12.30.11.52.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Dec 2024 11:52:06 -0800 (PST) Message-ID: <446704ab-434e-45ac-a062-45fef78815e4@redhat.com> Date: Mon, 30 Dec 2024 20:52:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/5] mm/migrate: skip migrating folios under writeback with AS_WRITEBACK_INDETERMINATE mappings To: Joanne Koong Cc: Shakeel Butt , Bernd Schubert , Zi Yan , miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com, josef@toxicpanda.com, linux-mm@kvack.org, kernel-team@meta.com, Matthew Wilcox , Oscar Salvador , Michal Hocko References: <2bph7jx4hvhxpgp77shq2j7mo4xssobhqndw5v7hdvbn43jo2w@scqly5zby7bm> <71d7ac34-a5e5-4e59-802b-33d8a4256040@redhat.com> <9404aaa2-4fc2-4b8b-8f95-5604c54c162a@redhat.com> <3f3c7254-7171-4987-bb1b-24c323e22a0f@redhat.com> <0ed5241e-10af-43ee-baaf-87a5b4dc9694@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Z-LZIatMDnThVo0tfNM-u3sc6rGp-0eMcgJ48-TvDhU_1735588327 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C5CCD8000D X-Stat-Signature: zbcy1xxjx9cwurgbiy98uqqcu57z9t4r X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1735588239-627471 X-HE-Meta: U2FsdGVkX1/NrMRK5UD4G91dwVT/+rinG73sRTAbbx+w5p0wNSYWzTFI3n1hisj1i0vX2Nx6VCPZ+jFM1+k4HGIQUxcggExXZ/J8y674ZvOQZ2XHLnp9bkB4O2AxvUDqwU+zFTP3iTDRH87Q6nqXlNhj/lo2UVHHpfbB/jM9TLMyM33BViRScTUyrmO+m8fK7izZtvXhLW2Lkp35BNKtoo+Blm3qhVuI4R42ZSeTOLnCE4MWB6vChJau2p2/rpSdXzCokRhh+wCKk9RIT51x1RMGke18lrktvaITZTvd6H5U2UdrBevT0HOQvDIHpPpSkIcjNOcasbrCrzvEncC9ygA458RZSbf8OjVMd9pXuxWRhn6P9/YZ1IQuNL8/ZIHDJ0uRBZcEodeLKx2epmnyIIWH2sg2fiz9Qd83mkUor8mdg119e5j/qgdoPGKSUC9VMSLskAV7D85Mohbe/ZdAzq5dInVAOkMuWZFRQcIJ/XDDs/2ZCI9GdXBp//HYsSSPXOX7WNwJNOl9Yngbpu/+hrhqHQF8QrQ14aZ3UDoMIER+DUxDyn5ovlsJUn+j2VU08GcCifF2gW/Nol76ad9JX744yPEpRcP0MYuNFJ5DkDcs+0yDR0p98LBl4o1rP+3+6xQDQb5FzDwRvjq0/bBQvK10yJcNmB1MIs6iB1sKleVYzgRsNrCQUSllSP3qMCxIcbkw+iWGWomSjJa5tXF+SCQd5357rcvF+stYiY8uxYYCy8Rap4ZsvQIxdCGj4Ws/LbW6mQcPwchazdFAajsjec3iddB/aCdL8TwLmnI0e85N7+Dk0pn/OeDs4ZJKl+A2NP5r4ad8Z0Ig6s/XAxPyd5J/UFwkSqHe3UvoyMA23lKEflSb/weJakXQBqsbOkZ5MS5WxkNiN8lXUdj3OKv+lPUM5/77phpGI2wcTQic9es23R8dUdfJhbbVKCsjrMBS8etzx5L19slJgnb0VgD SezWMYEZ nCXkQmA57ZtAPngZAqr4Gb13P3LxNTy4qwkLeJtVCs1m8Hz8qSPJb0tC04HdyOfQfqeN7faNsCADuceXldOTCH79FgiPobTY7Um/Df3mGM8DHw6oPficz0lZNI7m4i6+Umkmo9O00+clw+cbn1m3ZPeKqc4dSyB58+wHJ6PvfQ2/SRZQ20yccnNv8XCqKHBewD3wi585jBQQLOWskypmzGqjRI/p3ddD19PrGsCXmbPlu8kINkY9zSrE4HCLo1ooPOzN42qNF2HLZh4cs9qiQbTilAWnUtVx9SP6bMaokwzwwLdkO75qwvKNL6zoSyxlq70ko/3PIivFVAYpgFySH/gGYjzYKz422ERlpPaEc67+361dmtEHCU0yogPfOZMDq5Xw6M+BQhWcaPM7IN/yyCSPpwqrviN+WMhiTsNG3QLPdGcouM8f31dzLH7CsJ9gYSo7C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> What sounds plausible for me is: >> >> a) Make this only affect the actual deadlock path: sync migration >> during compaction. Communicate it either using some "context" >> information or with a new MIGRATE_SYNC_COMPACTION. >> b) Call it sth. like AS_WRITEBACK_MIGHT_DEADLOCK_ON_RECLAIM to express >> that very deadlock problem. >> c) Leave all others sync migration users alone for now > > The deadlock path is separate from sync migration. The deadlock arises > from a corner case where cgroupv1 reclaim waits on a folio under > writeback where that writeback itself is blocked on reclaim. Okay, so compaction (IOW this patch) is not relevant at all to resolve the deadlock in any way, correct? For a second I thought I understood how this patch here relates to the deadlock :) > >> >> Would that prevent the deadlock? Even *better* would be to to be able to >> ask the fs if starting writeback on a specific folio could deadlock. >> Because in most cases, as I understand, we'll not actually run into the >> deadlock and would just want to wait for writeback to just complete >> (esp. compaction). >> >> (I still think having folios under writeback for a long time might be a >> problem, but that's indeed something to sort out separately in the >> future, because I suspect NFS has similar issues. We'd want to "wait >> with timeout" and e.g., cancel writeback during memory >> offlining/alloc_cma ...) > > I'm looking back at some of the discussions in v2 [1] and I'm still > not clear on how memory fragmentation for non-movable pages differs > from memory fragmentation from movable pages and whether one is worse > than the other. Currently fuse uses movable temp pages (allocated with > gfp flags GFP_NOFS | __GFP_HIGHMEM), and these can run into the same Why are they movable? Do you also specify __GFP_MOVABLE? If not, they are unmovable and are never allocated from ZONE_MOVABLE/MIGRATE_CMA -- and usually only from MIGRATE_UNMOVBALE, to group these unmovable pages. > issue where a buggy/malicious server may never complete writeback. If the temp pages are not allocated using __GFP_MOVABLE, they are just like any other kernel allocation -- unmovable. Nobody would even try migrating them, ever. And they are allocated from memory regions where that is expected. > This has the same effect of fragmenting memory and has a worse memory > cost to the system in terms of memory used. With not having temp pages > though, now in this scenario, pages allocated in a movable page block > can't be compacted and that memory is fragmented. Yes. With temp pages, they simply grouped naturally "where they belong". After all, pagecache pages are allocated using __GFP_MOVABLE, which implies "this thing is movable" -- so the buddy can place them in physical memory regions that allow only for movable allocations or minimize fragmentation. > My (basic and maybe > incorrect) understanding is that memory gets allocated through a buddy > allocator and moveable vs nonmovable pages get allocated to > corresponding blocks that match their type, but there's no other > difference otherwise. Is this understanding correct? Or is there some > substantial difference between fragmentation for movable vs nonmovable > blocks? I assume not regarding fragmentation. In general, I see two main issues: A) We are no longer waiting on writeback, even though we expect in sane environments that writeback will happen and we it might be worthwhile to just wait for writeback so we can migrate these folios. B) We allow turning movable pages to be unmovable, possibly forever/long time, and there is no way to make them movable again (e.g., cancel writeback). I'm wondering if A) is actually a new issue introduced by this change. Can folios with busy temp pages (writeback cleared on folio, but temp pages are still around) be migrated? I will look into some details once I'm back from vacation. -- Cheers, David / dhildenb