From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8477C52D71 for ; Fri, 9 Aug 2024 08:42:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63CB2900003; Fri, 9 Aug 2024 04:42:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EBB5900002; Fri, 9 Aug 2024 04:42:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48C9D900003; Fri, 9 Aug 2024 04:42:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 29258900002 for ; Fri, 9 Aug 2024 04:42:22 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9BA881C42C2 for ; Fri, 9 Aug 2024 08:42:21 +0000 (UTC) X-FDA: 82432065282.08.7A7042C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 508951C0002 for ; Fri, 9 Aug 2024 08:42:19 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="XLxPje/j"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723192887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o8dU1j47wBaVmdxtmpM/u5bzIOpmMPMBAHatYBFq7dI=; b=a6xqbwj0bNpuyQoNS0FdD1SQu+lofrQWzCfuYlSulWqv/7itHYUpb8bcejqdkLqg2QipRw a9kGYnlUkWVgSPFbdjK4LVw8pMj6/4RjpYQ3hXJBd2tjMCIUdsSVRediOcEaoQ2eQWhoXc aBuF6eGw1U3lrYyDRI/0UJQNTZY98XE= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="XLxPje/j"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723192887; a=rsa-sha256; cv=none; b=gFZ9qk7meIC08xzQRpJCZTHb59xWbM1B3qrskZ6so++RrQRaVGihaw/VXPr/gJwGXXjGQQ q7RsOVdKCQNLvYz4rUA3DH48zL9im2BHxcMvS4bLC0k04DpG4nWnMFqur3Ohapn58QRBhW neprwg8YYE8G/0klcUegYvwrVE3E0jU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723192938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=o8dU1j47wBaVmdxtmpM/u5bzIOpmMPMBAHatYBFq7dI=; b=XLxPje/jXG7UBAc/Wuatc0b7lE6qZAGfcd5ZPRS63la35JGjcc1NlxL9+M4chCkHILrKmT 01EvSNAqCGrAxahFcCRBex1+TBAqMcLRjRqpQlJ8YjQ2s8QviX8vgTaUf2TpMesECKHfwS pVxIzE8RY6GbQvRwWN6dz9VY88/bcHs= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-dWh1KFWYObiIva7tHNcxSw-1; Fri, 09 Aug 2024 04:42:17 -0400 X-MC-Unique: dWh1KFWYObiIva7tHNcxSw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ef1b9a466cso18139311fa.3 for ; Fri, 09 Aug 2024 01:42:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723192935; x=1723797735; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=o8dU1j47wBaVmdxtmpM/u5bzIOpmMPMBAHatYBFq7dI=; b=NJeY1bqy+IGQaPNm0HHaHpMETkmlZOlMrPHi3sq6sduYcMrrAKifJiGDFqnXUVJeRZ D80NIXgooo4bwUe+BnfE7zG+0K7AmGVx4kaX9nie6FBNMy48qBTISjY5lZnWrXZ7D5x9 6wHurmLpDXKcl8QVmh7jfcdB5476TO/RidlkOJRAKSpaKip7TZc28ocg2pyWvZgAaJPN b9JX6MpvAUJdjZcDsEX1dj/EZUS/moRJq2prsbuKUHzfKmruOj2mmkq+nsNfJHAsVA8q yB4yo4hr+mM2LIjHmyAkDDH1INeYW6BmGpmIrYNr5T2vaov6Rv7dqNzTj2NuY0Okk9Rg vPfQ== X-Forwarded-Encrypted: i=1; AJvYcCWKPrwrjLfrn/fDDhtKT0NnXklgcxCkYi6avYzp3QNWlGsjnJxZLuBtt9/pjJ3QuQ/btHkVRoGJ9IaCX9S1O4xgpKA= X-Gm-Message-State: AOJu0YwYbZijZlzPH7chvuQI5Gnd8M6zngNEl07U7nNj86kFrVMC+iwm kmIJz/b8fN+RS8ns86RwVLzJhgD/p6RP3z307eGZ1K4gPwejEbYakwSX4WoRFuEejeDY4LFQfW7 M2QcU/DDDXWYRqZQLIsdRP4WvruA9gsIRyM5iuFjh/C+DJxeN X-Received: by 2002:a05:651c:1545:b0:2ef:320e:cbe9 with SMTP id 38308e7fff4ca-2f1a6c448b6mr7791641fa.9.1723192935581; Fri, 09 Aug 2024 01:42:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHADDLJUcNHwS9K94NJcMbXjpltKdjNfjQU7CmelDNKKozWmbTsmV3/91z6D/zixvZFwCz4wQ== X-Received: by 2002:a05:651c:1545:b0:2ef:320e:cbe9 with SMTP id 38308e7fff4ca-2f1a6c448b6mr7791381fa.9.1723192935028; Fri, 09 Aug 2024 01:42:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c71c:4e00:b097:7075:f6ba:300a? (p200300cbc71c4e00b0977075f6ba300a.dip0.t-ipconnect.de. [2003:cb:c71c:4e00:b097:7075:f6ba:300a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4290597199fsm118698135e9.14.2024.08.09.01.42.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 01:42:14 -0700 (PDT) Message-ID: <4465afdc-23e9-4844-a0a0-519f49b1229c@redhat.com> Date: Fri, 9 Aug 2024 10:42:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 1/2] mm: collect the number of anon large folios To: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: chrisl@kernel.org, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ioworker0@gmail.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, hanchuanhua@oppo.com, Barry Song References: <20240808010457.228753-1-21cnbao@gmail.com> <20240808010457.228753-2-21cnbao@gmail.com> <1222cd76-e732-4238-9413-61843249c1e8@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1222cd76-e732-4238-9413-61843249c1e8@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: q5b4mpu836a4dcjzdme51rbs6kjfbf96 X-Rspam-User: X-Rspamd-Queue-Id: 508951C0002 X-Rspamd-Server: rspam02 X-HE-Tag: 1723192939-397909 X-HE-Meta: U2FsdGVkX1/sKpuo6FhDJH7J2nGu67TCPec9G7N2utWKJx18sNKtXX7+n1hj316OhPvEqb6u+soG4q75FjY2yWXzSYwT9FtkYQ5rMLNL0t1WVSaBaXYM9g/wM5UN7iyuGs0K3veVqZr289hnnieWb3PdvBVSz1yDrWRmJHv0/VNf/wr/NgC7Nb+lo/urbDeEFRPYoD26CXv3KtZDa0tY+tj4KfkLwCoJtOSJy7ew9Tvoo4vb1Vad3+BfKd/39Sbo36bXttP7meUfCBHG4X0eRSHMRnimyf+XQIjH3q/nN5gZLGgfs5KcCOu+ama6UDU5Kxgk8YRrNaolYYe02PrtNg4v5aEkr4bT+Jxa3GDDDqNxG1By8XE9rnwRE/yGg4h7Ld0xlRg98XZ2etKKhzza66wMW+7qYmTDlSjiGe6Uik2ftWwDpYOl96riZIy/zNtZuYnssgfhi6RQ+H7Fb6JJ+vg7qgBrBEEfsOdM67Y78yDcO0wMfZ7yHRjReWfsH7EIX21xBE6RBpgtKzFNkBkrzpka95BuL3CrNkkCnrunJkjpXuYj6Nj+0NZE6DNPY9zNVkpag5gvgROkO6c3MXkDpA/6BOAyxCMNsJqjie3EXBzLffoOUZNFCK+apA38rFzB4bbSoPQRmZ+wBWoiKTQlAOy13Gma7MF86zdtlztHWr+jjvE9A8ZleC+inuUHXJF1zhvZxh4EXlQZoszdgvApBxv4ni0whqgOMlTkgzzmwRIfmeK7Bna40M796qXYimwEYoqK5F4LAdMvHePmM0oAMsbkWEySmdiuFe/70N16H/ZXByTEeOdghtycpN4fIBarmQZn9eydvNSnQOr6JHWLmGliZU9/1VzG4PBzFAKlF+B1RgXw2nTAccwN8HKDTxnOdTpIt1u/5XMulJBGFZ2qOrX4cdrLdpARffhOvzHE20uUDj3j0TwIPeFumxJjESZcP46caDDeJHNTQFTYYDO kPxA/CyE eTd2VehocZA/mq1Z48OsvbjsIJZYEg0g6TnlB6FtOEUlWjzRbG0QacoBPTLLAuR/FcPTyEFT73JxbuX4Mjb+fswGBxqPAsR3R8JO2i4emW/YVeC/v8onAD9HxPbo2rtGdGN3qI6EWHZ1TzuRw0So34gyY1k1ebyZXKQHG4tERwo3CWc3Va1hFDZQXpiCb6wZQ1rRSo+fBvPVxUVHt3EYZmrjJE2GIBlb/53yyeqaUYNKvy02CYf2jGql92F8+HC3jTIXIjTuhtdVVag/7mMWNqc3cjxuQhbhjsjbhh6TuSwMLums4bBlw43d/GnI7RfZETYZGVHnvnvTwUUdoP4FGvxyC1ShB5sYvHsiI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> Not sure I fully understand why David prefers to do the unaccounting at >> free-time though? It feels unbalanced to me to increment when first mapped but >> decrement when freed. Surely its safer to either use alloc/free or use first >> map/last map? >> >> If using alloc/free isn't there a THP constructor/destructor that prepares the >> deferred list? (My memory may be failing me). Could we use that? > > Additionally, if we wanted to extend (eventually) to track the number of shmem > and file mthps in additional counters, could we also account using similar folio > free-time hooks? If not, it might be an argument to account in rmap_unmap to be > consistent for all? Again, see NR_FILE_THPS handling. No rmap over-complication please. -- Cheers, David / dhildenb