From: David Hildenbrand <david@redhat.com>
To: Ryan Roberts <ryan.roberts@arm.com>,
Barry Song <21cnbao@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org
Cc: chrisl@kernel.org, kaleshsingh@google.com, kasong@tencent.com,
linux-kernel@vger.kernel.org, ioworker0@gmail.com,
baolin.wang@linux.alibaba.com, ziy@nvidia.com,
hanchuanhua@oppo.com, Barry Song <v-songbaohua@oppo.com>
Subject: Re: [PATCH RFC 1/2] mm: collect the number of anon large folios
Date: Fri, 9 Aug 2024 10:42:13 +0200 [thread overview]
Message-ID: <4465afdc-23e9-4844-a0a0-519f49b1229c@redhat.com> (raw)
In-Reply-To: <1222cd76-e732-4238-9413-61843249c1e8@arm.com>
>> Not sure I fully understand why David prefers to do the unaccounting at
>> free-time though? It feels unbalanced to me to increment when first mapped but
>> decrement when freed. Surely its safer to either use alloc/free or use first
>> map/last map?
>>
>> If using alloc/free isn't there a THP constructor/destructor that prepares the
>> deferred list? (My memory may be failing me). Could we use that?
>
> Additionally, if we wanted to extend (eventually) to track the number of shmem
> and file mthps in additional counters, could we also account using similar folio
> free-time hooks? If not, it might be an argument to account in rmap_unmap to be
> consistent for all?
Again, see NR_FILE_THPS handling. No rmap over-complication please.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-08-09 8:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240808010457.228753-1-21cnbao@gmail.com>
[not found] ` <20240808010457.228753-2-21cnbao@gmail.com>
2024-08-09 8:13 ` Ryan Roberts
2024-08-09 8:27 ` Ryan Roberts
2024-08-09 8:40 ` Barry Song
2024-08-09 8:42 ` David Hildenbrand [this message]
2024-08-09 8:58 ` David Hildenbrand
2024-08-09 9:05 ` Ryan Roberts
2024-08-09 9:22 ` David Hildenbrand
2024-08-11 8:13 ` Barry Song
2024-08-09 8:39 ` David Hildenbrand
2024-08-09 9:00 ` Ryan Roberts
[not found] ` <20240808010457.228753-3-21cnbao@gmail.com>
2024-08-09 8:23 ` [PATCH RFC 2/2] mm: collect the number of anon large folios partially unmapped Ryan Roberts
2024-08-09 8:48 ` Barry Song
[not found] <41b49313-5804-46ba-9e1d-358b079274cd@redhat.com>
2024-08-09 7:04 ` [PATCH RFC 1/2] mm: collect the number of anon large folios Barry Song
2024-08-09 7:22 ` David Hildenbrand
2024-08-11 5:20 ` Barry Song
2024-08-11 6:54 ` Barry Song
2024-08-11 8:51 ` David Hildenbrand
2024-08-11 9:22 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4465afdc-23e9-4844-a0a0-519f49b1229c@redhat.com \
--to=david@redhat.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chrisl@kernel.org \
--cc=hanchuanhua@oppo.com \
--cc=ioworker0@gmail.com \
--cc=kaleshsingh@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=v-songbaohua@oppo.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox