From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Gavin Shan <gshan@redhat.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, gerald.schaefer@linux.ibm.com,
aneesh.kumar@linux.ibm.com, christophe.leroy@csgroup.eu,
cai@lca.pw, catalin.marinas@arm.com, will@kernel.org,
akpm@linux-foundation.org, chuhu@redhat.com,
shan.gavin@gmail.com
Subject: Re: [PATCH v4 05/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in soft_dirty and swap tests
Date: Thu, 29 Jul 2021 10:37:26 +0530 [thread overview]
Message-ID: <445d4b02-c221-096f-eee0-573503350e44@arm.com> (raw)
In-Reply-To: <20210727061401.592616-6-gshan@redhat.com>
On 7/27/21 11:43 AM, Gavin Shan wrote:
> This uses struct pgtable_debug_args in the soft_dirty and swap test
> functions.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> mm/debug_vm_pgtable.c | 48 +++++++++++++++++++++----------------------
> 1 file changed, 23 insertions(+), 25 deletions(-)
>
> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
> index 650e35656660..bc153cad9045 100644
> --- a/mm/debug_vm_pgtable.c
> +++ b/mm/debug_vm_pgtable.c
> @@ -752,9 +752,9 @@ static void __init pmd_devmap_tests(struct pgtable_debug_args *args) { }
> static void __init pud_devmap_tests(struct pgtable_debug_args *args) { }
> #endif /* CONFIG_ARCH_HAS_PTE_DEVMAP */
>
> -static void __init pte_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
> +static void __init pte_soft_dirty_tests(struct pgtable_debug_args *args)
> {
> - pte_t pte = pfn_pte(pfn, prot);
> + pte_t pte = pfn_pte(args->fixed_pte_pfn, args->page_prot);
>
> if (!IS_ENABLED(CONFIG_MEM_SOFT_DIRTY))
> return;
> @@ -764,9 +764,9 @@ static void __init pte_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
> WARN_ON(pte_soft_dirty(pte_clear_soft_dirty(pte)));
> }
>
> -static void __init pte_swap_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
> +static void __init pte_swap_soft_dirty_tests(struct pgtable_debug_args *args)
> {
> - pte_t pte = pfn_pte(pfn, prot);
> + pte_t pte = pfn_pte(args->fixed_pte_pfn, args->page_prot);
>
> if (!IS_ENABLED(CONFIG_MEM_SOFT_DIRTY))
> return;
> @@ -777,7 +777,7 @@ static void __init pte_swap_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
> }
>
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> -static void __init pmd_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
> +static void __init pmd_soft_dirty_tests(struct pgtable_debug_args *args)
> {
> pmd_t pmd;
>
> @@ -788,12 +788,12 @@ static void __init pmd_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
> return;
>
> pr_debug("Validating PMD soft dirty\n");
> - pmd = pfn_pmd(pfn, prot);
> + pmd = pfn_pmd(args->fixed_pmd_pfn, args->page_prot);
> WARN_ON(!pmd_soft_dirty(pmd_mksoft_dirty(pmd)));
> WARN_ON(pmd_soft_dirty(pmd_clear_soft_dirty(pmd)));
> }
>
> -static void __init pmd_swap_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
> +static void __init pmd_swap_soft_dirty_tests(struct pgtable_debug_args *args)
> {
> pmd_t pmd;
>
> @@ -805,31 +805,29 @@ static void __init pmd_swap_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
> return;
>
> pr_debug("Validating PMD swap soft dirty\n");
> - pmd = pfn_pmd(pfn, prot);
> + pmd = pfn_pmd(args->fixed_pmd_pfn, args->page_prot);
> WARN_ON(!pmd_swp_soft_dirty(pmd_swp_mksoft_dirty(pmd)));
> WARN_ON(pmd_swp_soft_dirty(pmd_swp_clear_soft_dirty(pmd)));
> }
> #else /* !CONFIG_TRANSPARENT_HUGEPAGE */
> -static void __init pmd_soft_dirty_tests(unsigned long pfn, pgprot_t prot) { }
> -static void __init pmd_swap_soft_dirty_tests(unsigned long pfn, pgprot_t prot)
> -{
> -}
> +static void __init pmd_soft_dirty_tests(struct pgtable_debug_args *args) { }
> +static void __init pmd_swap_soft_dirty_tests(struct pgtable_debug_args *args) { }
> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
>
> -static void __init pte_swap_tests(unsigned long pfn, pgprot_t prot)
> +static void __init pte_swap_tests(struct pgtable_debug_args *args)
> {
> swp_entry_t swp;
> pte_t pte;
>
> pr_debug("Validating PTE swap\n");
> - pte = pfn_pte(pfn, prot);
> + pte = pfn_pte(args->fixed_pte_pfn, args->page_prot);
> swp = __pte_to_swp_entry(pte);
> pte = __swp_entry_to_pte(swp);
> - WARN_ON(pfn != pte_pfn(pte));
> + WARN_ON(args->fixed_pte_pfn != pte_pfn(pte));
> }
>
> #ifdef CONFIG_ARCH_ENABLE_THP_MIGRATION
> -static void __init pmd_swap_tests(unsigned long pfn, pgprot_t prot)
> +static void __init pmd_swap_tests(struct pgtable_debug_args *args)
> {
> swp_entry_t swp;
> pmd_t pmd;
> @@ -838,13 +836,13 @@ static void __init pmd_swap_tests(unsigned long pfn, pgprot_t prot)
> return;
>
> pr_debug("Validating PMD swap\n");
> - pmd = pfn_pmd(pfn, prot);
> + pmd = pfn_pmd(args->fixed_pmd_pfn, args->page_prot);
> swp = __pmd_to_swp_entry(pmd);
> pmd = __swp_entry_to_pmd(swp);
> - WARN_ON(pfn != pmd_pfn(pmd));
> + WARN_ON(args->fixed_pmd_pfn != pmd_pfn(pmd));
> }
> #else /* !CONFIG_ARCH_ENABLE_THP_MIGRATION */
> -static void __init pmd_swap_tests(unsigned long pfn, pgprot_t prot) { }
> +static void __init pmd_swap_tests(struct pgtable_debug_args *args) { }
> #endif /* CONFIG_ARCH_ENABLE_THP_MIGRATION */
>
> static void __init swap_migration_tests(void)
> @@ -1339,13 +1337,13 @@ static int __init debug_vm_pgtable(void)
> pmd_devmap_tests(&args);
> pud_devmap_tests(&args);
>
> - pte_soft_dirty_tests(pte_aligned, prot);
> - pmd_soft_dirty_tests(pmd_aligned, prot);
> - pte_swap_soft_dirty_tests(pte_aligned, prot);
> - pmd_swap_soft_dirty_tests(pmd_aligned, prot);
> + pte_soft_dirty_tests(&args);
> + pmd_soft_dirty_tests(&args);
> + pte_swap_soft_dirty_tests(&args);
> + pmd_swap_soft_dirty_tests(&args);
>
> - pte_swap_tests(pte_aligned, prot);
> - pmd_swap_tests(pmd_aligned, prot);
> + pte_swap_tests(&args);
> + pmd_swap_tests(&args);
>
> swap_migration_tests();
>
>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
next prev parent reply other threads:[~2021-07-29 5:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 6:13 [PATCH v4 00/12] mm/debug_vm_pgtable: Enhancements Gavin Shan
2021-07-27 6:13 ` [PATCH v4 01/12] mm/debug_vm_pgtable: Introduce struct pgtable_debug_args Gavin Shan
2021-07-28 7:32 ` Anshuman Khandual
2021-07-28 7:38 ` Gavin Shan
2021-07-29 4:45 ` Anshuman Khandual
2021-07-29 9:40 ` Gavin Shan
2021-07-27 6:13 ` [PATCH v4 02/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in basic tests Gavin Shan
2021-07-29 4:53 ` Anshuman Khandual
2021-07-27 6:13 ` [PATCH v4 03/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in leaf and savewrite tests Gavin Shan
2021-07-29 5:00 ` Anshuman Khandual
2021-07-27 6:13 ` [PATCH v4 04/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in protnone and devmap tests Gavin Shan
2021-07-29 5:02 ` Anshuman Khandual
2021-07-27 6:13 ` [PATCH v4 05/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in soft_dirty and swap tests Gavin Shan
2021-07-29 5:07 ` Anshuman Khandual [this message]
2021-07-27 6:13 ` [PATCH v4 06/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in migration and thp tests Gavin Shan
2021-07-28 11:08 ` Anshuman Khandual
2021-07-28 23:54 ` Gavin Shan
2021-07-27 6:13 ` [PATCH v4 07/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PTE modifying tests Gavin Shan
2021-07-29 5:16 ` Anshuman Khandual
2021-07-27 6:13 ` [PATCH v4 08/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PMD " Gavin Shan
2021-07-29 5:30 ` Anshuman Khandual
2021-07-27 6:13 ` [PATCH v4 09/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PUD " Gavin Shan
2021-07-29 5:44 ` Anshuman Khandual
2021-07-27 6:13 ` [PATCH v4 10/12] mm/debug_vm_pgtable: Use struct pgtable_debug_args in PGD and P4D " Gavin Shan
2021-07-29 5:51 ` Anshuman Khandual
2021-07-27 6:14 ` [PATCH v4 11/12] mm/debug_vm_pgtable: Remove unused code Gavin Shan
2021-07-29 5:59 ` Anshuman Khandual
2021-07-27 6:14 ` [PATCH v4 12/12] mm/debug_vm_pgtable: Fix corrupted page flag Gavin Shan
2021-07-28 7:53 ` Christophe Leroy
2021-07-28 10:05 ` Anshuman Khandual
2021-07-29 0:00 ` Gavin Shan
2021-07-29 6:05 ` Anshuman Khandual
2021-07-29 7:14 ` [PATCH v4 00/12] mm/debug_vm_pgtable: Enhancements Anshuman Khandual
2021-08-02 0:09 ` Gavin Shan
2021-08-02 4:53 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445d4b02-c221-096f-eee0-573503350e44@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=chuhu@redhat.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gshan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox