From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB55C433F5 for ; Thu, 31 Mar 2022 08:51:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D210D6B0072; Thu, 31 Mar 2022 04:51:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF7426B0074; Thu, 31 Mar 2022 04:51:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE79B6B0075; Thu, 31 Mar 2022 04:51:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id B23696B0072 for ; Thu, 31 Mar 2022 04:51:04 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8074F243B4 for ; Thu, 31 Mar 2022 08:51:04 +0000 (UTC) X-FDA: 79304061648.01.6876AFD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id CD32918000C for ; Thu, 31 Mar 2022 08:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648716663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wa4p/wO+PmXujUL5WGPRn9DNetCFbX+Ev3ZZgYBJonU=; b=Cpf0JIQqqbMwFibszXGEHM2KQC3qUvYGgEQnZo8luC/3L0Jpv7yuPPUwJ6zepGJsodMNb1 9kv8Eqn/TbcxGP2523zhKKO5ii/2hVBYWwsuu7cmwgPBF1M0TKTeXq+UnqNb3dwLDWq2jS c28MMsDExZGwwzGK5J2tJHKFnjEhJMA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-397-7pKlPqvKPyOaEwZvYQF0mQ-1; Thu, 31 Mar 2022 04:51:00 -0400 X-MC-Unique: 7pKlPqvKPyOaEwZvYQF0mQ-1 Received: by mail-wm1-f72.google.com with SMTP id i65-20020a1c3b44000000b00385c3f3defaso9212506wma.3 for ; Thu, 31 Mar 2022 01:50:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=wa4p/wO+PmXujUL5WGPRn9DNetCFbX+Ev3ZZgYBJonU=; b=TbDV5GlJVRhVhyTVs8QoTZQ8gXrSFmefXXTEijI1h5BD/PnheAmxs5mMeYUiDGdX1y CHXAPFAWOQlcYtvB4PTb3eEdSNtmzarYP1C5cK0ca39deUItvRgAzBh0Oy+sf0xbFnRW 0byaSzJIXj41Maa7nKVtlNYJ4j9KGgACADIRDn0XcUlK6mlmq512pXjsN+aStlEaF69P CFFEYFtPrjlM7Q7dgWhEhQtnsuQSXBBfPkM/LxFfmc3Q+1hXwIcRyw9yuiwmrgS28gKY VVTVKvTdKy83IG8dNy2+OhevbCUUaU9kvUUhbEMG1EK8hF0YdPb2IDD70TG0nIl6mFmK yALg== X-Gm-Message-State: AOAM533EfpqLYbiq1DUWltx7QzsX+wcgVQuO1TPrihvnIhjrg/yuVfM2 obU7QRJsMTpOzNF0bAj4TmMTb6BRWNhNu2KeGQlwrSFLgDEUG/id2ei/w53oNXmKkD/LR+4lvRx v7YTZwq2MtCc= X-Received: by 2002:a05:600c:4241:b0:38c:ec66:7c8f with SMTP id r1-20020a05600c424100b0038cec667c8fmr3779477wmm.179.1648716658875; Thu, 31 Mar 2022 01:50:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydHgZaeT4SyBikwI+ArVPjRxw0uDniD5ZVMGFpCcHvAsXuy7PE8lVHxzWUOPwpkP/X97R8KA== X-Received: by 2002:a05:600c:4241:b0:38c:ec66:7c8f with SMTP id r1-20020a05600c424100b0038cec667c8fmr3779451wmm.179.1648716658625; Thu, 31 Mar 2022 01:50:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:ac00:381c:2e8b:3b48:488e? (p200300cbc707ac00381c2e8b3b48488e.dip0.t-ipconnect.de. [2003:cb:c707:ac00:381c:2e8b:3b48:488e]) by smtp.gmail.com with ESMTPSA id v18-20020a5d5912000000b00205a7d0c6a3sm15035485wrd.69.2022.03.31.01.50.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 01:50:58 -0700 (PDT) Message-ID: <445c5426-cfb6-0232-6ea5-41cf8aaa264e@redhat.com> Date: Thu, 31 Mar 2022 10:50:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v4 1/2] mm: hugetlb_vmemmap: introduce ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP To: Muchun Song Cc: Will Deacon , Andrew Morton , "Bodeddula, Balasubramaniam" , Oscar Salvador , Mike Kravetz , David Rientjes , Mark Rutland , Catalin Marinas , james.morse@arm.com, Barry Song <21cnbao@gmail.com>, LAK , LKML , Linux Memory Management List , Xiongchun duan , Fam Zheng , Muchun Song References: <20220331065640.5777-1-songmuchun@bytedance.com> <6c774e27-26d2-6c45-65f9-8a5b8acd6433@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: e1fhwxe6isaoxapnrmmk7sjpcsorx71n Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cpf0JIQq; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf24.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CD32918000C X-HE-Tag: 1648716663-925689 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.03.22 10:48, Muchun Song wrote: > On Thu, Mar 31, 2022 at 4:42 PM David Hildenbrand wrote: >> >> On 31.03.22 08:56, Muchun Song wrote: >>> The feature of minimizing overhead of struct page associated with each >>> HugeTLB page is implemented on x86_64, however, the infrastructure of >>> this feature is already there, we could easily enable it for other >>> architectures. Introduce ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP for other >>> architectures to be easily enabled. Just select this config if they >>> want to enable this feature. >>> >>> Suggested-by: Andrew Morton >>> Signed-off-by: Muchun Song >>> --- >>> arch/x86/Kconfig | 1 + >>> fs/Kconfig | 10 +++++++++- >>> 2 files changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >>> index 9f5bd41bf660..e69d42528542 100644 >>> --- a/arch/x86/Kconfig >>> +++ b/arch/x86/Kconfig >>> @@ -119,6 +119,7 @@ config X86 >>> select ARCH_WANTS_DYNAMIC_TASK_STRUCT >>> select ARCH_WANTS_NO_INSTR >>> select ARCH_WANT_HUGE_PMD_SHARE >>> + select ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP if X86_64 >>> select ARCH_WANT_LD_ORPHAN_WARN >>> select ARCH_WANTS_THP_SWAP if X86_64 >>> select ARCH_HAS_PARANOID_L1D_FLUSH >>> diff --git a/fs/Kconfig b/fs/Kconfig >>> index 6c7dc1387beb..f6db2af33738 100644 >>> --- a/fs/Kconfig >>> +++ b/fs/Kconfig >>> @@ -245,9 +245,17 @@ config HUGETLBFS >>> config HUGETLB_PAGE >>> def_bool HUGETLBFS >>> >>> +# >>> +# Select this config option from the architecture Kconfig, if it is preferred >>> +# to enable the feature of minimizing overhead of struct page associated with >>> +# each HugeTLB page. >>> +# >>> +config ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP >>> + bool >>> + >>> config HUGETLB_PAGE_FREE_VMEMMAP >>> def_bool HUGETLB_PAGE >>> - depends on X86_64 >>> + depends on ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP >>> depends on SPARSEMEM_VMEMMAP >>> >>> config HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON >> >> >> I think something like "HUGETLB_OPTIMIZE_VMEMMAP" might be more >> expressive, but that would imply renaming the existing config knob. >> > > How about doing a full code cleanup in a separate series in the future? > Yeah. -- Thanks, David / dhildenb