From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7687EDE99D for ; Thu, 14 Sep 2023 09:06:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 150786B02A6; Thu, 14 Sep 2023 05:06:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 101186B02A8; Thu, 14 Sep 2023 05:06:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F318A6B02AA; Thu, 14 Sep 2023 05:06:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E459A6B02A6 for ; Thu, 14 Sep 2023 05:06:49 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B52EF410C9 for ; Thu, 14 Sep 2023 09:06:49 +0000 (UTC) X-FDA: 81234622938.30.7313163 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by imf05.hostedemail.com (Postfix) with ESMTP id 1789C10001F for ; Thu, 14 Sep 2023 09:06:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf05.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694682407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qyNKl29gt2cAvlnLLkwbV1GeANOWoPdNLfhEoqLbx9M=; b=paD45gfISef+u94XwCvQWVUnrHEBjpMSk5xc6A8WLjXAfT7g/ajQzkaFU6dJoiWZDD8iwv bcOE1SBLWV6f4folbz5ulckK4umFAnO2/iOhr2UE1ewJB90U6fzdteyPq+gdcWWprX+NDg dONo4MQIIBcVWNnqP2odnnNq8XA5AQA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=aculab.com; spf=pass (imf05.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694682407; a=rsa-sha256; cv=none; b=g+QlXOyrSdSZZwhYcQWRWoAmPlcKmMRcBKXE3NtLWtO1Sz0PAC3KJk8i7efD2RrrnH7pep Ug+hMrso9JxoQn0tI4SZLp2HUlqXuFf80ogt7z6A3kP7OOLBi5Gcu/uvr/fpiqmZQC/hGt f4iXqh15R97NqqZFOgfANt1VXYLrInQ= Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-252-oVJiQy4pMkOK69oh5CjVkA-1; Thu, 14 Sep 2023 10:06:29 +0100 X-MC-Unique: oVJiQy4pMkOK69oh5CjVkA-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 14 Sep 2023 10:06:25 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Thu, 14 Sep 2023 10:06:25 +0100 From: David Laight To: 'David Howells' , Al Viro , Linus Torvalds CC: Jens Axboe , Christoph Hellwig , "Christian Brauner" , Matthew Wilcox , "Jeff Layton" , "linux-fsdevel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v4 05/13] iov: Move iterator functions to a header file Thread-Topic: [PATCH v4 05/13] iov: Move iterator functions to a header file Thread-Index: AQHZ5mNctrIi+SmkLEm1sOlIj5L+5rAaBNNA Date: Thu, 14 Sep 2023 09:06:25 +0000 Message-ID: <445a78b0ff3047fea20d3c8058a5ff6a@AcuMS.aculab.com> References: <20230913165648.2570623-1-dhowells@redhat.com> <20230913165648.2570623-6-dhowells@redhat.com> In-Reply-To: <20230913165648.2570623-6-dhowells@redhat.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: ib3e1nsqrbtuioe1hpr6ugkkezwt8ifj X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1789C10001F X-HE-Tag: 1694682406-558795 X-HE-Meta: U2FsdGVkX19gDWNkQ0eP6pY93Q13S1WlZV+uh6DpFdCeMZbZ2io+KcZDikB3b/Fg39qyMGY1IvBH39z2phXdjEJPTP3AWTloJM1bhat5DP4QKRfXOdGZ8Ipnzh1nSY9EFHmVprJB3uQkI+W8oVmXVaCO98HJEwq8EJduWNDiUzfVUIFn+Uwm0AorHOYOYV8Nyl6YOnfhVwddAwQ0W4gXaP1/Eq3NvfFbMdPE7Ou8dWN0o2QlSXWpgAE632dEZocjVvlMqbRhoL5K8p2l7Edycy4Rg1Ce82oC2hkxyVYa+rdzRfS6+AeS2cxk8W9jFLJUkOafzElSoda2uxBKfhyDQDmFOEE5hufK7X0Av+U9jH4iGjBbpg4flUQH66RkFDnGjXf2ZahwyJMgs2GN3qtFsNjs7ST3IKAYuz7M4Xpt/8ldR4PCJmd4LHytG7D+x/18ROsSkIU8k0Y9xPnDMQ6symAx4PL/WcnE37m4ua5JpbQSYX3UVkWVOy1kR+Pj0BrdL6OEElw71vQEPuVQ3fIkcPJuA6cPO8WGEiWsJb5mmNTMZks3J37dj+Ox6kcADQnXsXbd4NKIv4mvZnFQrdFgAuZ/bDWXrRY8CTgcWUQBpC4eloaQU+MDpxZT/j+Pcd1mSLEuGJbH3SrV5djs3Kd2CXJrl8a/ryYuVlgFFYTDQYg45WOFsK/uctnIFDZ3Mr4j6xVPwEgTALmekFbzz0rchFuYtdikUsb1u7D3gREcKbStS8RHHE/n/UkMBD6iVOiLc3U+zmfc6brBeireAtIl7ag10MAo8eOhHxhNP543KkvLkIrQitG/a9ZJTFwY/Gl1+HTXJSVBsrZ1J9+4XOobMJ/e1bRR0egwsv9vHoQNwGOr7pLDzfTJhkEd9pI6hvqJ9ZfamuU556n50yCRTJFPeKX8kFbfhaMPcF50f84WSgC7IJ2ZEgZ0Zje5ql7xShwLH7HSX/MKES2xa0bM6vj 9Aoj2hvQ R8ua6y+KaTejwQPqkLB4Z2FqSFLu0zjAf/fSpE+7IvXOdEoUckp1eBCJObNkg1myJwVSfRYwySDGHyn8MTmE6EY3h9nmUIMQ1HY57/NVoKLUuMCS2nX7s3v7OYNyNYemV5KHLM8Uf23D/guLfJIs8Cx/1YeEfV2Jxej4Y/aKvk8XRzDf6B+9IVT6UyBQZIsRhnXwaxebIWZNadCL2ZluvZfU/SjmAM3iUx9d59yvE0ozm0Hg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: David Howells > Sent: 13 September 2023 17:57 >=20 > Move the iterator functions to a header file so that other operations tha= t > need to scan over an iterator can be added. For instance, the rbd driver > could use this to scan a buffer to see if it is all zeros and libceph cou= ld > use this to generate a crc. These all look a bit big for being more generally inlined. I know you want to avoid the indirect call in the normal cases, but maybe it would be ok for other uses? =09=09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)