Speaking of read_pages(), doesn't the AOP_TRUNCATED_PAGE case cause a dangling page which can't get cleaned up because it is not on the lru (and the file has presumably already been truncated)? (also, let's not worry about pretending we propogate errors) -- SUSE Labs, Novell Inc.