From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4716EC433E0 for ; Tue, 2 Mar 2021 07:09:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5EA8664DEF for ; Tue, 2 Mar 2021 07:09:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EA8664DEF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AC0F98D00E4; Tue, 2 Mar 2021 02:09:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A71618D0063; Tue, 2 Mar 2021 02:09:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 987558D00E4; Tue, 2 Mar 2021 02:09:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 824898D0063 for ; Tue, 2 Mar 2021 02:09:36 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 466551264 for ; Tue, 2 Mar 2021 07:09:36 +0000 (UTC) X-FDA: 77874058752.19.510EB05 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf26.hostedemail.com (Postfix) with ESMTP id 201F44080F4B for ; Tue, 2 Mar 2021 07:09:35 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4DqStN5Y6wz9ty3x; Tue, 2 Mar 2021 08:09:32 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id ZDu3KoTvWhhv; Tue, 2 Mar 2021 08:09:32 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4DqStN44CRz9ty3w; Tue, 2 Mar 2021 08:09:32 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 7576B8B7AC; Tue, 2 Mar 2021 08:09:33 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id V6-wUwb-6uGj; Tue, 2 Mar 2021 08:09:33 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id BFF088B75F; Tue, 2 Mar 2021 08:09:32 +0100 (CET) Subject: Re: [PATCH V2] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE To: Anshuman Khandual , linux-mm@kvack.org Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Christoph Hellwig References: <1614661987-23881-1-git-send-email-anshuman.khandual@arm.com> From: Christophe Leroy Message-ID: <4452b859-9e72-974c-95b3-9c70c54472d1@csgroup.eu> Date: Tue, 2 Mar 2021 08:09:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr X-Stat-Signature: brnuu1pbhzo63nem95mg45k7y7rfy9bw X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 201F44080F4B Received-SPF: none (csgroup.eu>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=pegase1.c-s.fr; client-ip=93.17.236.30 X-HE-DKIM-Result: none/none X-HE-Tag: 1614668975-401027 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 02/03/2021 =C3=A0 07:37, Anshuman Khandual a =C3=A9crit=C2=A0: >=20 >=20 > On 3/2/21 11:13 AM, Christophe Leroy wrote: >> >> >> Le 02/03/2021 =C3=A0 06:13, Anshuman Khandual a =C3=A9crit=C2=A0: >>> HUGETLB_PAGE_SIZE_VARIABLE need not be defined for each individual >>> platform subscribing it. Instead just make it generic. >>> >>> Cc: Michael Ellerman >>> Cc: Benjamin Herrenschmidt >>> Cc: Paul Mackerras >>> Cc: Andrew Morton >>> Cc: Christoph Hellwig >>> Cc: linux-ia64@vger.kernel.org >>> Cc: linuxppc-dev@lists.ozlabs.org >>> Cc: linux-mm@kvack.org >>> Cc: linux-kernel@vger.kernel.org >>> Suggested-by: Christoph Hellwig >>> Signed-off-by: Anshuman Khandual >>> --- >>> This change was originally suggested in an earilier discussion. This >>> applies on v5.12-rc1 and has been build tested on all applicable >>> platforms i.e ia64 and powerpc. >>> >>> https://patchwork.kernel.org/project/linux-mm/patch/1613024531-19040-= 3-git-send-email-anshuman.khandual@arm.com/ >>> >>> Changes in V2: >>> >>> - Added a description for HUGETLB_PAGE_SIZE_VARIABLE >> >> You are doing more than adding a description: you are making it user s= electable. Is that what you want ? >=20 > No, this was unintended. Will drop that description. >=20 The description in the help section is OK. It is only the text after the "bool" that makes it selectable. bool "Allows dynamic pageblock_order"