From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Matt Mackall <mpm@selenic.com>
Cc: Linux Kernel Mailing List <Linux-Kernel@Vger.Kernel.ORG>,
Linux Memory Management <linux-mm@kvack.org>
Subject: [rfc][patch] radix-tree: small data structure
Date: Mon, 24 Apr 2006 01:43:37 +1000 [thread overview]
Message-ID: <444BA0A9.3080901@yahoo.com.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
With the previous patch, the radix_tree_node budget on my 64-bit
desktop is cut from 20MB to 10MB. This patch should cut it again
by nearly a factor of 4 (haven't verified, but 98ish % of files
are under 64K).
I wonder if this would be of any interest for those who enable
CONFIG_BASE_SMALL?
--
SUSE Labs, Novell Inc.
[-- Attachment #2: radix-tree-tag_get-fix.patch --]
[-- Type: text/plain, Size: 761 bytes --]
Index: rtth/radix-tree.c
===================================================================
--- rtth.orig/radix-tree.c 2006-04-22 18:40:38.000000000 +1000
+++ rtth/radix-tree.c 2006-04-23 04:46:15.000000000 +1000
@@ -458,9 +458,8 @@ EXPORT_SYMBOL(radix_tree_tag_clear);
*
* Return values:
*
- * 0: tag not present
+ * 0: tag not set or not present
* 1: tag present, set
- * -1: tag present, unset
*/
int radix_tree_tag_get(struct radix_tree_root *root,
unsigned long index, unsigned int tag)
@@ -494,7 +493,7 @@ int radix_tree_tag_get(struct radix_tree
int ret = tag_get(slot, tag, offset);
BUG_ON(ret && saw_unset_tag);
- return ret ? 1 : -1;
+ return ret;
}
slot = slot->slots[offset];
shift -= RADIX_TREE_MAP_SHIFT;
next reply other threads:[~2006-04-23 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-23 15:43 Nick Piggin [this message]
2006-04-23 15:46 ` Nick Piggin
2006-04-23 21:12 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444BA0A9.3080901@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=Linux-Kernel@Vger.Kernel.ORG \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox