From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE3CC3ABCC for ; Tue, 13 May 2025 13:05:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BBCB6B008C; Tue, 13 May 2025 09:05:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16E376B0092; Tue, 13 May 2025 09:05:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F27C76B00CC; Tue, 13 May 2025 09:05:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D23E16B008C for ; Tue, 13 May 2025 09:05:28 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8B14A120AC6 for ; Tue, 13 May 2025 13:05:30 +0000 (UTC) X-FDA: 83437906020.03.DBC3ECC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf30.hostedemail.com (Postfix) with ESMTP id 0E8AC80016 for ; Tue, 13 May 2025 13:05:27 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kdd3OXEr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kTnCzx2N; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="KDOh7/F0"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=WeCsdAM8; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747141528; a=rsa-sha256; cv=none; b=nMhHlPGi9EvsYy4OGiMnU9/wDQYPMqBpyT488tZZD++wKXlvtA941dkUohq3MDvWiiiyfq cwE8p61/ijfkRig4gE7G9tBXzz4YjUMJGTnyzbJNkPCJESdi+alMwW2ER04RC5GJIBZLQW qjMF3kxFGchMP05M1KDyF1FyLqfaQHU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kdd3OXEr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kTnCzx2N; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="KDOh7/F0"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=WeCsdAM8; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747141528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iRWUYikOIy/1r7u07D5ZCje1j34KlJyLQzknjjGOicY=; b=ePh5SqYYtPkuljNbHSN9ZD/PSrFYWlpoKLD9Ouh3myEAF2KV0YetgZtQnSAWqD1s1vNTLU 2Atp5sAhQ+j2Fzjp4PRWried81VHkOjhA/NMouAek1eaU3o/dDrC5e7KB43WfSCtX+il/I QcqlZw9DSksczZ0ceYcbEYLpvF7u7dU= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1AF211F792; Tue, 13 May 2025 13:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747141526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRWUYikOIy/1r7u07D5ZCje1j34KlJyLQzknjjGOicY=; b=kdd3OXErue0VlynjlAhmsosCko1ctbMupCP7zksbeMwhVnc9QOlh2VtmkE9Zt3glm2rPsO Ej+vKj4k6yc7Hrz9Cu+mwD6G/ZJx3Ei/6FBxjxtVh73s0Tv/oNn52KfFUrRMWxYmZRWL+h SQdyEoLqYtiCbfvtxQczOkUfH9QL9GU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747141526; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRWUYikOIy/1r7u07D5ZCje1j34KlJyLQzknjjGOicY=; b=kTnCzx2NBr9RUocyWdZITzopFDyYszz7wpbGJRMZatBsbtd64JTGImmN/6vcRvY7xAQ7bW nwfqch0H9bcmqVDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1747141525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRWUYikOIy/1r7u07D5ZCje1j34KlJyLQzknjjGOicY=; b=KDOh7/F0eM08rczbeQl8PDsy52saiIb5A5bQZff/FYhwX5npXyDzt30hIopKMphMu8JPqR 3VKZpmyTvwxz71/dyenSggvy3Tyh/ExbVNlRH8BD1maJasHhZPFew3G43W2PxLLmlnN6sd XqrRRWwHa3wgLLecx+V2J2GBrkVFT4I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1747141525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRWUYikOIy/1r7u07D5ZCje1j34KlJyLQzknjjGOicY=; b=WeCsdAM8aKEoA2ktaw+PoaIs0o764iCzfypdOFIZSen0MuyAFeCs9Jwd20uJDN43bNJQrh CyOLcasLEDPiazAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E6AC1137E8; Tue, 13 May 2025 13:05:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id TqprN5RDI2gjUwAAD6G6ig (envelope-from ); Tue, 13 May 2025 13:05:24 +0000 Message-ID: <44489dcf-2bb1-45f3-a593-ac34da3f9138@suse.cz> Date: Tue, 13 May 2025 15:05:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 6/7] memcg: objcg stock trylock without irq disabling Content-Language: en-US To: Shakeel Butt , Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250513031316.2147548-1-shakeel.butt@linux.dev> <20250513031316.2147548-7-shakeel.butt@linux.dev> From: Vlastimil Babka In-Reply-To: <20250513031316.2147548-7-shakeel.butt@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0E8AC80016 X-Rspam-User: X-Stat-Signature: b3urarkzz6gcebconyr8f4q99mzpzdj3 X-HE-Tag: 1747141527-704683 X-HE-Meta: U2FsdGVkX19urXK2x7KdBSTMArwXz+tXyiCD+29lV/ogpJnGDj5yH7W8C9k6y0T+QmsC10HfSzRfzInPQb0ZFdV93vx9kZVmYQPtPBs5gt0rmjXB94h2DUjdZVf1Lvo5LXwf1FMb7AAwgSpnM7XWuKY7+E4R9lC0dB4IrEuQ0DuryDRA+Ctl6eyAfT5R2VK4RbWVDIA2MRld1b0iCtU3QJU+HTCp5ESyHJ4xhib1DCG4rx76RrUGqSQR+y1GSuZ+zl0gFcSuB0TSX9hDDL6qAkjQqEYkBziBzo84GFNhBuEkmvb3Ti/6PDs9oisu9yaiXQOYlu3zV8HDn1sAsqXMarJdLdMwQ7XkWxD0ROCDidh4PMaNuioEqWjKEfMa4aZ5CgRWTSYSNYpg9uzQ3XynupsLSpBpIErqylfJvkhsyqz6PQGPbXMncg/VTUpgN3/SBLRuvOTxH5JInZYgrr4hBaGGEx9RS8zCYoL3yWdRixesF8PKCrzlfc3NOhH6gvSkCl2bsO5K4MqQnq+KTYiV8RwQwPrmKBeG3jmDIZO6GBwyYClJuCgnoaBqkhY6pBWYppws1cWO8D+lQqvNMcO80wNw9kOEzZ/2tyVOdzfvFIFzfZA1FL0P0Qby8ADEneg9B1fdPwtkiGkvOcAEHSK7DJEECAKDem4C8aoO8Zuchlr7F3DXdVwVYH0zr4JSG/wJXmcbYeFEDOaxGj6NBt0EVpHVTSGFPuYQkA3laR3TenJRjUftn5nNQRxakVriMfdNqoqOSxTvvjkoSDcbKm49kfKx5wsozy+IvN4J6LlOIeCB5gp33s9iPFQRKf2nkDt64rypvoSWRS9j4FlWqtC8IWAK0735+RL+TjoaQTir+IG4t4f5tuHOtPenttbn5WLarEXr+RdbkWtPJnjfm7UYDHdhEqlv3ytku2/qCa66aMxA8cxE59IZvBqO0wnJPfiSnCjQDOSlBo9lhi1F0R+ tCT66sse rvMlIkCYMVVT3P0rYzVT7JhoE5mgp2YL0JvQtGElrDVq6OlTHPvy15l55JrV33YBXr+iAuduwkKmtFubnsLZvi8UXeABrJy0OFmPJt1mARqImmiSgl/rkSnZSuNfHSmg5+8+fvMpaa8pr3hMAXONCoB9Gkx0nwZDaS9Z18aVjcfwwZFGueLCJYjlYQnvP3jNefBLmexlb9mQmOP98KT+sXJG67qV5VlFCwwUS6ciQVO8LJClPaSCVbAQSGwOOAKbbPEMQoWYoIDLFxjwFXWhU5KY5ysa0/xYP5kuf3EdobiNBYIjvNhzP4aX8CA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/13/25 05:13, Shakeel Butt wrote: > There is no need to disable irqs to use objcg per-cpu stock, so let's > just not do that but consume_obj_stock() and refill_obj_stock() will > need to use trylock instead to keep per-cpu stock safe. One consequence I'd rather say "to avoid deadlock". > of this change is that the charge request from irq context may take > slowpath more often but it should be rare. > > Signed-off-by: Shakeel Butt Acked-by: Vlastimil Babka