From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9798DC3DA7A for ; Thu, 29 Dec 2022 05:31:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B66FB8E0002; Thu, 29 Dec 2022 00:31:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B17658E0001; Thu, 29 Dec 2022 00:31:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DE668E0002; Thu, 29 Dec 2022 00:31:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8DEB98E0001 for ; Thu, 29 Dec 2022 00:31:55 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5A549807D6 for ; Thu, 29 Dec 2022 05:31:55 +0000 (UTC) X-FDA: 80294222190.13.561A2A7 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf15.hostedemail.com (Postfix) with ESMTP id 9CE2BA0007 for ; Thu, 29 Dec 2022 05:31:53 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cO80+3DH; spf=pass (imf15.hostedemail.com: domain of the.latticeheart@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=the.latticeheart@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672291913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Pz+Fh3q8KwMyp1e1BIkdP01StsjsKBE+6Hou8VrHrnQ=; b=UJE4HQRVlusozZDQMobF5M5eTNQpcAG9drPwVzhE6kK4HchO4w3ieTuftOB1TcRZTIymON SE8UNAzojCSHYuUM/31+EqG2KpbSyifr7F4K9SwN7NQA9VWtgW5elyahSwP9MxYqLO+M5L luSJCPl3OXPkxb9oS3H9MAL1HWygTCA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cO80+3DH; spf=pass (imf15.hostedemail.com: domain of the.latticeheart@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=the.latticeheart@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672291913; a=rsa-sha256; cv=none; b=iRxprJGDJUlTS8YY1qMYaGLYbvE8649SMDadeBHS5NMX80AFJe5f9tfE0Cp98bwPgbXWhS +o5SSwarSbeAdNgwUO0ce6iQlM7oHRvMFozY5K1cC7E7+MKKrGcXGcry8kZefVc6vdZ5zx BT42hw2G99kb+DGA/FN9ruzQRiyFgTM= Received: by mail-pl1-f170.google.com with SMTP id n4so18010937plp.1 for ; Wed, 28 Dec 2022 21:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Pz+Fh3q8KwMyp1e1BIkdP01StsjsKBE+6Hou8VrHrnQ=; b=cO80+3DHnBv0fLGI/7jxhAqYmWyh9+aGwDLW3G5XSuURYE2wKkDYbJRyCpGD/MjMZ7 poFx49z8O5PmSKiQHx8lQ1ap8UqtSJvVXllRlWaQU7EuJKBlWV2kACyLM6IvaVXDyoyB tOlFlgWI6mWe2ayUdunivT0YrvBd3a0/Nr0dGmA8ZXWKZtpoApIsC0fEA5h/7ElOT4B/ oCcK8BPBJ125jL4nlCsp1iU4FiGTmDGtc13en1o0PUqycpvpp4JrXcPvxwcGqqzQiZ2E dXxhk6PZFh4r7T2ToyJphFENGEwPy/OW/+n77rRyOQKGa7kntyGpxvOL6y/628xLQb1j Pp5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pz+Fh3q8KwMyp1e1BIkdP01StsjsKBE+6Hou8VrHrnQ=; b=K+w2w9RyCDrciGipak6dq46Mu3EQPOkNj9/zvnJCsqaHXtlVkB0KQUKAfXe5y9ZnHT THWJecjR0ZgBXStLxZHMlfP9X5P3VnMzvddDvEakpsarGjHhqaVKPBmvGuC/adB9l60m KMguNsAFxzW5qqK6XQaIa8SrP4gRczF4YGcD6mmPW3e+AhOQ6Ye5hh1rzFPNtwZ0t1GZ rC0H2CrcKH3/b7g0XXob0BUMqiVzffgNkpUTUaO7dAMbOIjeorT0l+iCYcPT3D6apqkE GFhN2kELFwawIj48HdxqzKk/U3rTf/f6YznJqCyEWrQyIeQ1Bo/KUeSiKKA2nVfoYCNc B15g== X-Gm-Message-State: AFqh2kp6Zn+Z0ZNJhwOCJv9SsVCcBwreHWzCBM5C+tI/rUzUjRDGEKXR aOmI+5s5kwazjva8ujLLgZY= X-Google-Smtp-Source: AMrXdXvUgv240P0eNGdtmxMkPvqK1CST5BwBFrYXtdpYPiNftphpWn6usD75TBzHz6e3wbY1RPdolA== X-Received: by 2002:a17:902:f60b:b0:189:e924:e279 with SMTP id n11-20020a170902f60b00b00189e924e279mr31310934plg.49.1672291912391; Wed, 28 Dec 2022 21:31:52 -0800 (PST) Received: from [192.168.10.103] (ab137057.f.west.v6connect.net. [183.76.137.57]) by smtp.gmail.com with ESMTPSA id n2-20020a170902e54200b001887e30b9ddsm11844641plf.257.2022.12.28.21.31.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Dec 2022 21:31:51 -0800 (PST) Message-ID: <444735fd-7076-7bd3-dc5e-7135a7f3a95c@gmail.com> Date: Thu, 29 Dec 2022 14:31:48 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 From: Soichiro Ueda Subject: Re: [PATCH] virtio_balloon: high order allocation To: David Hildenbrand , mst@redhat.com, jasowang@redhat.com, akpm@linux-foundation.org Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kalutes@google.com, mhiramat@kernel.org, cwd@google.com References: <20221223093527.12424-1-the.latticeheart@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9CE2BA0007 X-Stat-Signature: frcjyacdjaq73wi7modjccbsjng4fgwm X-HE-Tag: 1672291913-808239 X-HE-Meta: U2FsdGVkX1/4rBKS9ShLnd2px165lFLVtXBNdUzvOR17Tz+7C2j01k8gJHPGjactvOZ2Y6onxpCvdUvTtF9GVQfNKn6zcQPG7ziYqLBPRmvEnKw6Xj1DbwuwQOpU5jSNkPH1FciMyKH3DTyx671mfThUi/OFM2sk5CNhDM3jH+FkKybj83mVVhzSLnhM5gFvKLVB37pzwavADFFTrX+98OqFL/Tp1E0yACQbrHFkEoAVrzz3GXLCsIKxsTccl9P6iBqWFP3TQOtTjsS18sk+XM9vQVgTNZqr0D2tbHAHD5HQzKU355mMmvRenkMj4X4nHDt1BKEBjBPgq9h96gW+i7CnyMbQDr5gCnraz+a4kTLfFz8RkkXAsW0AJEyusgdFoc9hXN1DTKzBAafhgA2IGDldm8oZB+jMuxBdlQ07VLvqUQQKMzTu94H1cExKANju0DbWm6c20/mQDewRs/qypzZEBhp99BCGkI9JvGeADGjL3+kcCCbXWZk6qOZJWHRPh5Mv82KB00/p+JhqcPjxjDoMnjzx6vqRVhYTUs0WXzlvUQphp3Y17VvUHemcTHiHdnR752gmDQeHIIJwf3bJhwi92Z2c0kM8W75G50KUeKCguP+J2DBCdVQTS6cGOdDTNZkhx8vOe5O0Y0+bkgcSTvymE2k18b2GR4ww+f6o8YObc621Z8787BocW+7CdSJw6pa07TYjGwMYdUZBhqifI9pS4s23avkpq6GrAQfGYn5C2J5VUCcm8IRg/GokQJxttfggPZtamwoXrkMtTxiwi37lJeRblCsr/MNJwzpgwVjroiZxroexM1bvM9Nqe9mF231Om9IBygGYmSgkqTJI1H8N4FWcTKMKPqzmQ+y8T7JoH9KoZFURnqSBjjA56rsFeSj//TPY2Et4SfcdNNMJ5Tue1gdbqRp5q4IZLfzjYYvDgPMo5R6t6vcjvt3wg16oh2aAdWnsxAGHSCOWJoB rG01v3DQ XKifSLse2lkhYNsi6UL4XfawHvSgcgSzxOIYZvZeQLAT0WbxsWyVDgzZA7PAstlQNQM5Ss5b/1xumDfkkmd/SOejVbyuGfb3WM/rKOYyQJBnlKRyh8KRuEu5puP9fwbsghwJbl/StgdsIwvGsbjPIsnv9+oxN71B2qqnDVIvIrwrxhFw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000681, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi David. > How does this affect page migration / balloon compaction etc? I guess this patch doesn't affect balloon compaction. When allocating pages using alloc_pages(), it skips compaction by masking out __GFP_RECLAIM if the order is larger than 0. As for page migration, in the current implementation it migrate a 0-order page to another 0-order page. With this patch, it may migrate a high-order page to another same-order page. But I noticed that the migrated high-order page is handled as 0-order page in virtballoon_migratepage(). >     balloon_page_insert(vb_dev_info, newpage); We should put the newpage into a page list of the corresponding order, like this.     balloon_page_enqueue(vb_dev_info, newpage, order); I'll fix it in the v2 patch. Thank you,