From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADDD8E77188 for ; Fri, 20 Dec 2024 18:29:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C9ED6B0083; Fri, 20 Dec 2024 13:29:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47B926B0088; Fri, 20 Dec 2024 13:29:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F3556B008C; Fri, 20 Dec 2024 13:29:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0E5A36B0083 for ; Fri, 20 Dec 2024 13:29:28 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BD46D80A92 for ; Fri, 20 Dec 2024 18:29:27 +0000 (UTC) X-FDA: 82916174208.12.C0F99B7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 1FBB34000A for ; Fri, 20 Dec 2024 18:29:09 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nv3nag2O; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734719333; a=rsa-sha256; cv=none; b=wF4j28I6lxYxvA8GT9WTesn7MMZ0iX53/vq8sj4rytGcrYO0ptBxyOyN0/H6QiO2bERM6/ 6/zKDQl7yLLN1PBkOeVg0e2KRpa0wlmXgT7raJk56CU56PejQHlQcRpvPg8T1hGaKEVnoW 8FPJ0IiN9gPbr7+k61+oPz/bbuezi/s= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nv3nag2O; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734719333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ShuO3TfEMw80wDehD7G0N/FfiqkQn0QjW6tjkfqEvXA=; b=jQTgNijelnOXFBavK780dY/e3XGlT1jgWjhXBNUt68YfY8CwZATKudA5nPh5Em4yRmSbuR 0dKXT6auuExE/vwLPaln8dEi4g4sKdrK5soly1tw+1hcXlDw7T6N8wVM+e9dDwMGmoaVGW aMWSr/nRbd4mXkCkRrjeMyKjtoUt/zg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734719364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ShuO3TfEMw80wDehD7G0N/FfiqkQn0QjW6tjkfqEvXA=; b=Nv3nag2ONqN9wr5gUrNzI4yz5bzuF/TgGFoBIG887ioWrLG7qj+yddc6C5jC5p2HXZ57dA K+qPXUhv35PCPl5bFJBiAissgHxCXyRfiUqOTS2hFniCeZvGp/G760yIg8emwxY4UUCssa JS6nMTCR3oQqFn4/ZpOfvwxXkLGKrYQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-5jy30235PsyH1AJTYF1lTg-1; Fri, 20 Dec 2024 13:29:23 -0500 X-MC-Unique: 5jy30235PsyH1AJTYF1lTg-1 X-Mimecast-MFC-AGG-ID: 5jy30235PsyH1AJTYF1lTg Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-385f0829430so1441815f8f.1 for ; Fri, 20 Dec 2024 10:29:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734719362; x=1735324162; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ShuO3TfEMw80wDehD7G0N/FfiqkQn0QjW6tjkfqEvXA=; b=a+OrzcR5NtHbSS1lxEHLuR4ugKYxQc0ZPPe3k0ChSkW0M4vw9YR4k/vU0aIis3AJAK +om08YIgVQs5Kgr8RtYabX5Ye1Qg1idk6/qHjb2NukH4B1TyYQajQ1TPuWb0VUIvAmX1 hzZFfN0dzOAQIMKTmgcgO/87TiYe4Q9umP0L74dq0yp97HdTnl8p0qGd2GYNbH+MoFn/ ICD8NHKeJtz8LzbXQCNnuEfsaPPxGpKksSxhdQm/nAgF85Zdwb0MXupzb4XJxID9VC3O zzuNGDIZ3Canfi844CrWMAMK+EuoVOuU2aoihHG2fz2YYGfnHfxwSUW+2NsTOuEfnLIn LnFw== X-Forwarded-Encrypted: i=1; AJvYcCXb6QvlLLjRKUgNf8fp3ueI+qTfOAn4TyX9nFQ90TCSYGTz4a4yKI8EhmCalIdJbwLFjqbfrQZg4g==@kvack.org X-Gm-Message-State: AOJu0Yw4iY1BHt3Ntu5rEJMCgX6idIdEU2X3GrRdb7u0OZWQcfKuLAoY 3eyMBr+EYC1/nqN5v9WKUNtxuyq4II7iniWaqQ3VYElSeoI5WaQfydyjvNbkfNmc0w/H2q7XkIg /8B86ESS1reM4o4gZQP6W/qkd8hB/i1aQPuWYAZHFM4/miXOe X-Gm-Gg: ASbGncv2pK1GVEfYYHwSs/wG0NkFNE8R25XMXQdxwSMsrMTqFol85ojTLaZr48nX1D1 /5huLmKicT14FzRKVdDIMiq3ftXkQOIAgkMrS9nwy8a8L48AiGu8hnpHAnE+78iTrLDVUIy0SKx xv1pUMY5riL9Fj2TUZbZ22CuOuAIF+76hVK+AY86LVsv5oybYFq1lG9aj25e+R+rHWflASkr7/i IIjSzmRPiyd7iL8hsDURyDL0qUzRAUsFn0Qp22+N6AjknOiVdvZpVzEFoWdhayUsGw6y0AoWPsB 7/UZP8bMeyFaaxxTV6qgBaA+c6hUFGfdoqXF7IgYHgEznQnUIWITIVzzRn9tHleWlLLUFwttxhq vZTgGBNCT X-Received: by 2002:a05:6000:18a9:b0:386:3835:9fff with SMTP id ffacd0b85a97d-38a22406d43mr4852346f8f.59.1734719362330; Fri, 20 Dec 2024 10:29:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4GC48OmfJNltY6Ek7vleCwhpqJySNAWqKHGuZFUvMe2tCVDpmaDR4IIQ/DXZtWNsmnqadZA== X-Received: by 2002:a05:6000:18a9:b0:386:3835:9fff with SMTP id ffacd0b85a97d-38a22406d43mr4852317f8f.59.1734719361985; Fri, 20 Dec 2024 10:29:21 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b441bbsm85576885e9.40.2024.12.20.10.29.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 10:29:20 -0800 (PST) Message-ID: <4446a9c9-613b-4303-9a06-686fb10af363@redhat.com> Date: Fri, 20 Dec 2024 19:29:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 10/25] mm/mm_init: Move p2pdma page refcount initialisation to p2pdma To: Alistair Popple Cc: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org, lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com References: <359a1cf2-c5b0-4682-ba3c-980d77c4cfdb@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wU8kCeWZCxMB4h2cOhhZ7PJv1_wTjBKkGQ8s-ec0RsA_1734719362 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: kkw714xmtftbszhfy65jx49o3hez6hoc X-Rspam-User: X-Rspamd-Queue-Id: 1FBB34000A X-Rspamd-Server: rspam08 X-HE-Tag: 1734719349-352848 X-HE-Meta: U2FsdGVkX19cotYSv60vqV/LZULnb3O6JAWaKJxVOzm99cXu6EMJ5HrB+bCBSxrqy1AjWwWIx9x/RUx3X9csePjXSukPiodRNFNN6r6PLKwHhxYoL2PvgeCvb2fHbilfMStOSzbBJVKKK0YowLD4bKHpbMjEnFaq+zjsYgkdgax9qPMtyqCEffru88nm0na61xLIb6m7xH+l/arAst8/56omq7Q9sxNXliuaj5qlkwiFiq/qMUNRnWRzOqB7GQRn4oYt/My8yvE8OHKtLpQ8/1GLGx/iu7/JFX/bcNw5CcGIzp8jRpmceWAk5X2p4tPq5Qkl33CMNn5PwpIzuko78f3Fufb/gLt3/MSXUrEK99YQq+Ys/YgdUSH1+/eEO2vwpfSQjKivYhR26gdVx6fDe6n3G3gjde0Y/y6sIsGnGIW8n0zX2YfIZWqq2J1lLwcPpW8N68bzEmb5lk3BaunWryXHaHgwwGr5S9n1/y2+jd1PlFDlDjUdb5aGKeS14fALOdEi6O2G23bZBMiz7RrtIml0TLydByOk6OrIFWLL2R3Ud1R1A45gkVzBmFOGKfJKRY9EhkAiNMSw4fp2SGtfcGfZ+xYXCY8WK8nr/VND3D83cTstzxwOjPWpSduyqwq3RFCaz4MXaOXeWiGt5TAsLW5Tbbil7kCPAGpFh9FXf1++yCOCGxO7f9b5fFIT6gMq7IyBy9bzp9jvSUA2J3BFNM69Zb+QYxohgS6mr4OaG0Oi66zaq9oqgzk3HV4TfslYM30QpfKQHNwjXIdcK+5HehxhctfKGtM+0ib0FIr4jCtFct60QiS20Kn2Nb3pNQ4YFf8RMBrfxyjXDk4QP1pZtIueVQW1N/TqAUWOVf18/otsNoZHimgqXp3JBf+5pjkqymfCjIt9xDw5tlRtl57HZU0Syd2MgNK64ox1uA4kejG0GdUDu6t3LpWUZDlJkRRJIONwDM4Xa75Aa0X8zRp LBwea9ga fzoLg/2BgaHCK2xGq15HFiN7PfbdBhGOrfKIIVKNiFEzEmITaKm35/kZiBNV0n6dFZmqbdS4hX/bVsjdU//tLRJQhVGfO+w/428Rt4LHoLz4oMCTe9rTZ719giO6Mu2qK+e3vcHKaqCuyfonjJ8i1aKcFay6RjZK/zKhD03Mc4JkN7o+SvVHy1s8k9B8OKp/RovkAnh6zxPfpxaIF2xxnfYfccXZlhYFOGqEjFbg5VhWoJOhZYOqH13G8hIWXL2V3VgRqUBXELGcc2HJN758VJ0f+d7AYQX1ErDXomwoe+jHNRivlVeAmT6uLtIKPF0RFMccvw8p9jXQTOynRLGP3RTYrZBbfq+Xp8qnYMlkqVmruOJgy9oQVg6BSvO0LiNGuOHR3G8FLvG1e0ohheXTWPxeaFCi8rfRfpaxOhAm1K4KS1UfhZBk1zwMS1LDnLYKQLorFrItN/xN7N7vNnCxtH91riykasP6Q6R3vq7nb+BJP6IWQjbjDu/3wps+Z/mEtMbCU9Q6S5sd4cBY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.110143, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> >> But that's a bit weird: we call __init_single_page()->init_page_count() to >> initialize it to 1, to then set it back to 0. >> >> >> Maybe we can just pass to __init_single_page() the refcount we want to have >> directly? Can be a patch on top of course. > > Once the dust settles on this series we won't need the pgmap->type check at > all because all ZONE_DEVICE pages will get an initial count of 0. I have some > follow up clean-ups for after this series is applied (particularly with regards > to pgmap refcounts), so if it's ok I'd rather do this as a follow-up. Sure. For ordinary memory hotplug I'll also convert it to start with refcount=0 soonish, so there we're also simply pass 0 to __init_single_page. -- Cheers, David / dhildenb