From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537D1CEDDA0 for ; Wed, 9 Oct 2024 14:28:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D92346B00A4; Wed, 9 Oct 2024 10:28:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1AA56B00CD; Wed, 9 Oct 2024 10:28:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B46216B00CF; Wed, 9 Oct 2024 10:28:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 926456B00A4 for ; Wed, 9 Oct 2024 10:28:51 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id ACBDEC15FD for ; Wed, 9 Oct 2024 14:28:48 +0000 (UTC) X-FDA: 82654295262.27.9B087A2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id D4CFB180006 for ; Wed, 9 Oct 2024 14:28:48 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OatVbVnS; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728483948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=92PukKtsNXhLV0QdE0IVPzsI6bS5AIPl7j7dtiXRit8=; b=12QRegoowdVjg40Wh5pWcniUElGJ9Ua8mJegXr1fBOa8vAD9TSAkhe36CWOvCRM2RJTYeO nxqnfsiZVU2TGSticCI3g8lNwxzMNwEo1boEnY+gGVvhZYxepv7znnpOyOsxTWsyxbcJPd NIuvEkg+eiWZnzff3rjE7P7LP0ncspA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OatVbVnS; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728483948; a=rsa-sha256; cv=none; b=EX+DAz/eAK+EU3BQhkgCxUl/0y2ubWFnlrOTsGvXEB5Aw1WMoCE1F3ySLHJExo0BCGeXIe P3kOFn3SIaFfHz1k7hi1R9+CR4eab71VkASJHvcETeboB3zf0mtkZ4p3LEJtB9dcrbH3Le sGcOt+kNkqVLk5x/M/bIsSQJqoMDEAE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728484128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=92PukKtsNXhLV0QdE0IVPzsI6bS5AIPl7j7dtiXRit8=; b=OatVbVnSpZqX2sTYk/miPd+NSIi6ys9s8GZos/eQXWOBFmqzU86+ig7UKUohel5jCCBpvF iiBgQVwQ8oRd268qOUvXSQKvJSNWlvDBM1mf1rA8dp7Iayva2XG9StsTFsNMeysVL7HP/t scJJN/ZutpxEdMIogNBmZ2X0q1tA1CU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-gYNFabKbOgGIv7zedwsk1Q-1; Wed, 09 Oct 2024 10:28:47 -0400 X-MC-Unique: gYNFabKbOgGIv7zedwsk1Q-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d39bf2277so395190f8f.2 for ; Wed, 09 Oct 2024 07:28:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728484126; x=1729088926; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=92PukKtsNXhLV0QdE0IVPzsI6bS5AIPl7j7dtiXRit8=; b=KuMh2lm0R/ByKAD4ZAqpN/Z99d3ekHdvFQtDKepul1CDPxfLU3dzHUAr3wwq/CbFY3 tjswmUfeM8gi5OXzTsjaB1vLIO6uKpMEEYqNmTZcqWouCECn0NLBjy9hdOJcE7BBZR0b qGnAgnf4+weZph/ZZ9G9NogaCfVrep0YLakzPVDK9MnbfFf/Nno50z4kcteAi8A3wNvQ d19jIY8PNe/OXvQU/vgqbS+2ONTA/zSN3TyzIxFAci0iF8URz/Fpo5CJg4Qc8A/FuFk+ nSHkUeV1ZQq45qcMnlvVuPbbz+pWiUZhRC8Osxn5B+zzJtxeWuIBSVkwey128OzkZn/g dSFg== X-Forwarded-Encrypted: i=1; AJvYcCWgSNT8FYr4X2youALDOK24L6Y2NY7t4qvq1eOZSqraJgV5B82upLDN1WWOLEd78+dP3izQJwe79w==@kvack.org X-Gm-Message-State: AOJu0YzWWPHnhH4VZwN93LlXa6KxbZ+4cSY4baIfbSqjpkiTDsE0PDoE toZYzzKUcaioIq2SaaVjoYXehyyJH831lgcpekhLBHpXiRC5f9e0D9vs55MeZWU+82bcEjmFV+O ukpihlkpP+0PtcWuj7xHPFJbBqugGX2bWSVijmM6PWBDvucvq X-Received: by 2002:a5d:4991:0:b0:37c:cc67:8b1f with SMTP id ffacd0b85a97d-37d3aab7873mr1677575f8f.48.1728484125806; Wed, 09 Oct 2024 07:28:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHwiWGu8+pD5cCcHIV8zAhaul3YGxGIItwMhrbnjO+C7x+oYQu800RnBypEAyEV6pvy6V96NQ== X-Received: by 2002:a5d:4991:0:b0:37c:cc67:8b1f with SMTP id ffacd0b85a97d-37d3aab7873mr1677553f8f.48.1728484125387; Wed, 09 Oct 2024 07:28:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:c400:44b7:7781:f506:d321? (p200300cbc73ac40044b77781f506d321.dip0.t-ipconnect.de. [2003:cb:c73a:c400:44b7:7781:f506:d321]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d42eafad2sm1339503f8f.0.2024.10.09.07.28.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Oct 2024 07:28:45 -0700 (PDT) Message-ID: <443f9571-37dd-47eb-b8f3-91b4e779bb9e@redhat.com> Date: Wed, 9 Oct 2024 16:28:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: set hugepage to false when anon mthp allocation To: Ryan Roberts , Kefeng Wang , Andrew Morton Cc: willy@infradead.org, Barry Song , Hugh Dickins , linux-mm@kvack.org References: <20240910140625.175700-1-wangkefeng.wang@huawei.com> <9b4fa269-8e1f-4f14-a737-b6b0697d83b5@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D4CFB180006 X-Stat-Signature: dwbr1zpme8yerfc7y1ca3fgepnpnmife X-Rspam-User: X-HE-Tag: 1728484128-281823 X-HE-Meta: U2FsdGVkX1+0tbFrvzxUtFxcpx4gkLsVShb7TdxdlxnmaB+QlfMWVRz465roiUmRDFINqGke9byAq5DW2p0iBtS4/7uqmzIDrZbO3ks4Hk8ZAa1tXRdZuyXV6Gismc7etsReSwE7jZVQfIfwdknXo3oIR4ysN8yj5yEtRXAJd68oFfkfL9TwlnG5Z69It8pBX4/dg2pEq/reAL/jFlFTZpvL7rayvZY7dTvVseQe4r4QR4/ZhBRJtb/kUL+hT0bn5xWoAYcNBxeZVaV9rbVdczfImehsZp5ksC2HG51ZMynVbW43NTnp3Qoa5BrQfDuowL0f1DZMmozLbO2xoFLLfSUlLh+dU7xWOib0EXcEcP5yNUaLr7FYSrrMkXT6iSJLIyqU6/e6YNbOBF7oU3F0bFISeqF+ec2PjYL/faCZZWfyCcLvcqmWabJrixxf2VqT1EbcdIEo1q8rurnooGJFgQ1Kxx57r9rRfIOS9SHHSVJ578g4IcKS+P/CVg5CYtPiDE4JlpuvM2SJsCELjzCbn7s4kzBnh376HRneX7VTL0d8YQpeAkRPcGZvvOiqFh/LUM8sTYYzMEpDV/ahk7ekAyGa4kfhMrd5SCALFiwGLbUHpFNIeqvcQhfIO0E3b/yAshTN2/HtzjqJ4CQCaMlf3kuQLZaacrmIbjs9KLv6F8IfFCLO51NY4+Tg60/e1E1OM82/vDyonaQpus9ugRROdR712lwSftP7YPRbBSKUhssWswrjSPaFKcjjAkrpO3/IzlYv1fy0G/JJ/jKBuupQCyzzE6S8f48qnTxVxYvzvkeRV6TOfTfy/XoXzGE/WeywBHdv3aPO5GpdeJXP/k5GPbNzGDl5Lg17Sr1srJKiQQHukoGL4BXMrXnjdVE5vomi9VQ5ck3ELtLRp90iVD8hFK6X8WPqNDfCtq4UFtfzfTDBjWMx5dyfXKZ59x7cnUVRe+nlxlFx1gT6QcafcS9 p4oNMfrx OqHA+J4zMbKQ/wIl9DmwP/90YHqiqfymrcyVn2tOiOES0aWtNfUd1N36yqAYO8lAedtgfQvNQNF4jjVPH+sgKqv+IBGPFp+7WUsw+U9XbpA3lqWfi0mFdLJ/0JBOvy51dN8GXKDoxjDp0d0mYqyXUvtffHLROyZ9XRx29oMp2lsk2vI1YUx88rrleM6Y5QeOrj8M8y49HB5Rn1oDOjOFnPGt2N+kkVNRG+71rZKVCi0WKjHaKmCPkJvPMmHXKaMnWb3SoCxGQZdB8jG8LJ36jYrJepmtZ07UCxqIsunjSEjwkKxszkFxRsJRbYBmulqOWBUdmKpVk+svLSI7QaT85sk4nf0wO2ZhTdoUPHzQiYbS+H+fkdrMTpYH0GUAoJmJznonp5/yqHdNWdXbj4yN3UHuczvOPDwOeIDig X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.10.24 12:44, Ryan Roberts wrote: > On 09/10/2024 10:15, Kefeng Wang wrote: >> >> On 2024/9/13 18:36, Kefeng Wang wrote: >>> Hi All, >>> >>> On 2024/9/10 22:18, Kefeng Wang wrote: >>>> >>>> >>>> On 2024/9/10 22:06, Kefeng Wang wrote: >>>>> When the hugepage parameter is true in vma_alloc_folio(), it indicates >>>>> that we only try allocation on preferred node if possible for PMD_ORDER, >>>> >>>> Should remove "for PMD_ORDER", I mean that it was used for PMD_ORDER, but for >>>> other high-order, it will reduce the success rate of allocation if without >>>> ddc1a5cbc05d. >>>> >>>> >>>>> but it could lead to lots of failures for large folio allocation, >>>>> luckily the hugepage parameter was deprecated since commit ddc1a5cbc05d >>>>> ("mempolicy: alloc_pages_mpol() for NUMA policy without vma"), so no >>>>> effect on runtime behavior. >>>>> >>>>> Signed-off-by: Kefeng Wang >>>>> --- >>>>> >>>>> Found the issue when backport mthp to inner kernel without ddc1a5cbc05d, >>>>> but for mainline, there is no issue, no clue why hugepage parameter was >>>>> retained, maybe just kill the parameter for mainline? >>> >>> >>> Any comments, fix in alloc_anon_folio() or remove hugepage parameter in >>> vma_alloc_folio(), thanks. >> >> * vma_alloc_folio - Allocate a folio for a VMA. >> @hugepage: Unused (was: For hugepages try only preferred node if possible). >> >> Since hugepage won't be used in vma_alloc_folio(), maybe just delete this >> parameter? > > Sorry for the radio silence. Given the param is no longer used, I think it would > be cleaner to just remove it. Agreed, no dead code. > > It was set to true here on purpose though; the aim was to follow the pattern set > by PMD-sized THP, which also sets it to true. And the aargument was that the > benefit of having a huge page would be outstripped by having to access it on a > remote node. > > Now that the parameter is deprecated, do you know if the policy is still > enforced by other means? Right, it might indicate a bug. So figuring out why there are no users left would be interesting. Maybe it was all on purpose. -- Cheers, David / dhildenb