From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE905C021A4 for ; Mon, 24 Feb 2025 18:21:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 507A428000D; Mon, 24 Feb 2025 13:21:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B75A28000A; Mon, 24 Feb 2025 13:21:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32FFF28000D; Mon, 24 Feb 2025 13:21:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 14B5328000A for ; Mon, 24 Feb 2025 13:21:47 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B7818161B31 for ; Mon, 24 Feb 2025 18:21:46 +0000 (UTC) X-FDA: 83155656612.04.7A218C7 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by imf07.hostedemail.com (Postfix) with ESMTP id 5E78B40012 for ; Mon, 24 Feb 2025 18:21:43 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GkOls+Ln; spf=pass (imf07.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740421304; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gZbznQ8iMtUzqtBIf+BHuQgeisgtpzrGMTiDH1NoVUw=; b=GTUC0siAnfGu09faUAHZdgCF8xHx1lGwJ0sObCys+rQUyJ8+a7Ysp0bCzFWYciSzq/lBhZ NPzKcOTk66bqUHHO4iTzta+SLNZBfocL/aZ+Ry1AwH5h73LagM0kQpdnBzDRYsXluyXFmK VbX+dUD07USImXtminTYG15VWqoByig= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GkOls+Ln; spf=pass (imf07.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740421304; a=rsa-sha256; cv=none; b=pV82iv7cLo/pylobCOEFC6VO3/BSfPIrd6lL6pf04iduwXWYlv6xwPY+sgosmVgS0tML7H ysPxBvBe/KH5bpdxFm+hcq/Q3MLDHIQc3NWcCfM5XFYTorivIGRTxXtNlBE8fuDO7dYIcW 4+ZEy0OGC7oVF3ghFIdWN9rEjmtqSlU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740421303; x=1771957303; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=10a3pM1AYmlxD+Z+pBe8Hm9/Sao0/x+QwYFONyDg3o4=; b=GkOls+LnBlsKapzyCTP+70ywV6bzY9UuVsUBlKCX8/+R3viAnQc2pKj5 WvCDXDihOgomO2UaGJLTn7nryOG0gmaG/mfPBqIELNLPdTPMckilWx5KC gzju5b0so032MlnEiG5MsbCBs2snYI6cl77bgH1FYOcmpaF+1fO/V77UK wU1e0JmPjfwO+Lb12MKaConb2CNnuwBnDcrW7RQGk4V9+WdTuu1plnWFO tML5WcYCguWJlM/LUpEybU1K03t8BBKGq/XLWEYCbkt7S8rcKYjygRKlr PXHjWGD5YTtQbfUfBShDtj8rTVpFtYSlM0KseI6mKnG4JEjz8DFX4cBrY Q==; X-CSE-ConnectionGUID: C1Qb3QvsSkuVlPpwr/Qmqg== X-CSE-MsgGUID: VFYZ1OaYTTGYDl2MKHxR0A== X-IronPort-AV: E=McAfee;i="6700,10204,11355"; a="58738354" X-IronPort-AV: E=Sophos;i="6.13,312,1732608000"; d="scan'208";a="58738354" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 10:21:41 -0800 X-CSE-ConnectionGUID: nH/dmqPkRqeMY5P4pZu3sA== X-CSE-MsgGUID: 5RHlkFn7S5mj32IzNhfDdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="117050107" Received: from cmdeoliv-mobl4.amr.corp.intel.com (HELO [10.125.111.40]) ([10.125.111.40]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2025 10:21:40 -0800 Message-ID: <443992d7-f694-4e46-b120-545350a5d598@intel.com> Date: Mon, 24 Feb 2025 10:21:47 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/7] mseal, system mappings: kernel config and header change To: jeffxu@chromium.org, akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@Oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net Cc: linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com References: <20250224174513.3600914-1-jeffxu@google.com> <20250224174513.3600914-2-jeffxu@google.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250224174513.3600914-2-jeffxu@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5E78B40012 X-Stat-Signature: j9ugmwgmsudcghzf1etryoasjjfns8ek X-HE-Tag: 1740421303-148533 X-HE-Meta: U2FsdGVkX1/f6NnI5uy1kWmsgkZn+2Iq7WQd5jc9IaqUMD320loYY6CdT2M30dmUiB0woHGeyb2r7uQkYV3BQW081V9pdDVtoEOe6l/ir2se2dZfLREOQudBRRNJTChzbnl2CKJAKHCQWEXQ+iX4CcBLo3p4FKs8MM5ngcXUmDG52AwnYmEA/pOagmOIFUPIRrUNYL2eDz4pC/Z3VOYa3bYyATvTB84pEhFJdidZslEeXxrJGU5+mw6YbDYU/FUl4FxK6BziVb2T0tAYijdVEPugmqyIdcKjT/bGtrtkSVe7iCK+u10yWpk2sXRQSaw0mz8UdZ3Svjuw8mOaKIO+3V7ZyxmTCp8lt4q6tcqfTU+dNaUqv8h29x1SJxmQyR7R/IIbMUaVEFktJfvz12bjerlMG7swp9VAn45eRBWsdZxAisyxLmvPWrw3+UDX0YTymDaTikhRHqOOEh4IjKpMzUmpPyfQyMFByHbvTsNTU0Ul++naWGyoYLHSdRXodCq66RNnDAVzMaAYfQ2pyHRh7F0HHiWiKRyKLwTcOHB1e7T0+CX67w1cCId6fSdfe4mUT90djwZ6LVaFakZpGdGzMiwwMj3gULunCOQA4vQLkL4A+HB2e4PLYHfBGhyXvg1jw2Fny36UUtnAz/uEM2OaHJdr8m62Bq5pLLWqP5b2HexLHFlTOCNnf1vCTEAVwQz4lEmUAaZkaIXPwljBoFbY2wTpkfNZRYqo8bbjIKTkrQRLQWayHJVLbzFPEIPq+6lHzAGs9lFzf2UIrJrG0OT6wGx3I4RtZfI/9gxbfzmuqMPPYU/afwFcD3he03mmn5G4jJPlRV1AAX8kIwGg+NzKpJkl/gpFbI2GiuTa9uLTSoeScnx+fpk2VgYh/MDEFH+GUfMVV9P3yR4XCNegTHT1eXu2oX8B7+FF4oBMt1U/lL8mIrQepLD/5vk23xJiSS8TWXyw79kgVvTXOdu+9d+ izyV18HZ 0HcaZl57YqeBCb7xxPNA7ez876KGKKNWiNBcLrkWKDddFKUJfVuKEM62/yGGcyPepfenHPMksJxAAzrD187+qEO3a6LrLOTQBp0ezuo6ODKUUHT/UyvSHeeigCEu/AeVEhZAJ11HQMGfzQG/Q5VPd6xOjuPr+MW4F+Qf1/PzC/a/kxbwny/Z6cWCxXtgYFqp2xeiLx9xrrqpeGlQnFBWJJHjjVLgRzOyktw5CzSg3vY+Qq6fnt2YEqwiQQQJkU46mTRKZ8OJL1ZMW2nOu0NKSQpdvDsQOxxC+0b8WjlnJoSRhr44= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/24/25 09:45, jeffxu@chromium.org wrote: > +/* > + * mseal of userspace process's system mappings. > + */ > +#ifdef CONFIG_MSEAL_SYSTEM_MAPPINGS > +#define MSEAL_SYSTEM_MAPPINGS_VM_FLAG VM_SEALED > +#else > +#define MSEAL_SYSTEM_MAPPINGS_VM_FLAG VM_NONE > +#endif This ends up looking pretty wonky in practice: > + vm_flags = VM_READ|VM_MAYREAD|VM_IO|VM_DONTDUMP|VM_PFNMAP; > + vm_flags |= MSEAL_SYSTEM_MAPPINGS_VM_FLAG; because MSEAL_SYSTEM_MAPPINGS_VM_FLAG is so much different from the other ones. Would it really hurt to have #ifdef CONFIG_64BIT /* VM is sealed, in vm_flags */ #define VM_SEALED _BITUL(63) +#else +#define VM_SEALED VM_NONE #endif ? Then all the users could just do: vm_flags = VM_READ|VM_MAYREAD|VM_IO|VM_DONTDUMP|VM_PFNMAP| VM_SEALED That seems to be a the common way of doing things. Take a look at: # define VM_GROWSUP VM_NONE ... # define VM_MTE VM_NONE # define VM_MTE_ALLOWED VM_NONE ... # define VM_UFFD_MINOR VM_NONE ... #define VM_DROPPABLE VM_NONE ... and more