From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1953C433F5 for ; Sat, 8 Jan 2022 15:58:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F7966B0072; Sat, 8 Jan 2022 10:58:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A6EF6B0073; Sat, 8 Jan 2022 10:58:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36E0B6B0074; Sat, 8 Jan 2022 10:58:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id 278116B0072 for ; Sat, 8 Jan 2022 10:58:50 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D315E98781 for ; Sat, 8 Jan 2022 15:58:49 +0000 (UTC) X-FDA: 79007577978.20.9E72896 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 44A94180006 for ; Sat, 8 Jan 2022 15:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641657528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vU57yWko8FS2IXRvev408Ys04n75VGGdrg6NxAdaDtE=; b=W8BQz1KeSC4wpVVtTTr1I8qV3nb0tsSthMMW1SXweo6E5g/+c6oA/C6N8Gw2WUnsNMMe3U G8vXQkCtMOAlzlYwfXbs2/zDi+WoznVDUhDsbnqcwOsHiF/CNtwDWM9dMgefUYEoySR6yr 3LPTQ/qdWsdLIjeu8lXHyGys5gv6PeI= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-584-IdbgEb4cOjuNW8l7cK2DpQ-1; Sat, 08 Jan 2022 10:58:45 -0500 X-MC-Unique: IdbgEb4cOjuNW8l7cK2DpQ-1 Received: by mail-ed1-f72.google.com with SMTP id s7-20020a056402520700b003f841380832so6965760edd.5 for ; Sat, 08 Jan 2022 07:58:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vU57yWko8FS2IXRvev408Ys04n75VGGdrg6NxAdaDtE=; b=3umZ7WD9fpn6PPtmmiXFCspTBumDqg4+XyKQhHXNW1gLOemmVtRg4Giu1lC53r8ns/ zMz8rBhWowOyyqxcOqIQHsTCnz7qrMmNsqO1Y1VJosdSVAAJMNqI8dF0EecOS35Kz1Y4 tO23qsS8+fxacqxQglByrDrsv3/sxMhMiZ4vRnD5YdCREpVM5VVTxM6u1/TF5q9wLk+s +vjHIIfBbgGoQgL2W3QRUDQplwozy0Lg97fGoAifOclCEmH0ZPrZuy4ON6Xvdkxwep0R 8+tSnPVVN8Oto8CKhL9QTLAKviORinYH7NIBPT1a8Wn3Le5Mzvhws8SjctmbTiLMpanQ +OZA== X-Gm-Message-State: AOAM5337b83NGQrBh8p39jqtSMqRaMH1Yfm6TfcceaErQUvVdOy7sFQB JYvJIfF9SNhO7eooXEzTyqB7U1RNjv3R3z3X9uNEdrcKiuaLJGbf0wO4j9SYBw+KXaQNQx0CsfL 7jC2YixZA/rY= X-Received: by 2002:a17:907:7b88:: with SMTP id ne8mr52690248ejc.39.1641657524237; Sat, 08 Jan 2022 07:58:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJwxsDi88gWoz/yFn06znH+GlQCed5mHhzzbuFm0oPCmY5DmkRskm4o2cKqyiJpOlrxdATjS+A== X-Received: by 2002:a17:907:7b88:: with SMTP id ne8mr52690232ejc.39.1641657523992; Sat, 08 Jan 2022 07:58:43 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id x17sm857217edv.69.2022.01.08.07.58.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Jan 2022 07:58:43 -0800 (PST) Message-ID: <442f838d-5143-e272-9679-5bfaa9ac7b6a@redhat.com> Date: Sat, 8 Jan 2022 16:58:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] power: supply: Provide stubs for charge_behaviour helpers To: =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= , Sebastian Reichel Cc: kbuild-all@lists.01.org, Linux Memory Management List , Thomas Koch , =?UTF-8?Q?Nicol=c3=b2_Piazzalunga?= , linux-pm@vger.kernel.org, kernel test robot References: <487dd7a3-8f29-de9a-2612-65fe895e676f@redhat.com> <20220108153158.189489-1-linux@weissschuh.net> From: Hans de Goede In-Reply-To: <20220108153158.189489-1-linux@weissschuh.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 X-Rspamd-Queue-Id: 44A94180006 X-Stat-Signature: ixxda85kzzhuu35f16bn1r5k9gecx57d Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W8BQz1Ke; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf16.hostedemail.com: domain of hdegoede@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=hdegoede@redhat.com X-Rspamd-Server: rspam11 X-HE-Tag: 1641657529-873524 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 1/8/22 16:31, Thomas Wei=C3=9Fschuh wrote: > When CONFIG_SYSFS is not enabled provide stubs for the helper functions > to not break their callers. >=20 > Fixes: 539b9c94ac83 ("power: supply: add helpers for charge_behaviour s= ysfs") > Reported-by: kernel test robot > Signed-off-by: Thomas Wei=C3=9Fschuh Thank you for your patch, I've applied this patch to my review-hans=20 branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x8= 6.git/log/?h=3Dreview-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > include/linux/power_supply.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.= h > index d92de670d6a7..e218041cc000 100644 > --- a/include/linux/power_supply.h > +++ b/include/linux/power_supply.h > @@ -723,6 +723,21 @@ ssize_t power_supply_charge_behaviour_show(struct = device *dev, > char *buf); > =20 > int power_supply_charge_behaviour_parse(unsigned int available_behavio= urs, const char *buf); > +#else > +static inline > +ssize_t power_supply_charge_behaviour_show(struct device *dev, > + unsigned int available_behaviours, > + enum power_supply_charge_behaviour behaviour, > + char *buf) > +{ > + return -EOPNOTSUPP; > +} > + > +static inline int power_supply_charge_behaviour_parse(unsigned int ava= ilable_behaviours, > + const char *buf) > +{ > + return -EOPNOTSUPP; > +} > #endif > =20 > #endif /* __LINUX_POWER_SUPPLY_H__ */ >=20 > base-commit: b8170452cd5121b11a5726e3ea8dbdfc2d74e771 >=20