From: Usama Arif <usamaarif642@gmail.com>
To: Suren Baghdasaryan <surenb@google.com>, akpm@linux-foundation.org
Cc: kent.overstreet@linux.dev, vbabka@suse.cz, hannes@cmpxchg.org,
shakeel.butt@linux.dev, 00107082@163.com,
pasha.tatashin@soleen.com, souravpanda@google.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] alloc_tag: avoid warnings when freeing non-compound "tail" pages
Date: Tue, 16 Sep 2025 21:47:58 +0100 [thread overview]
Message-ID: <4429cad8-5363-4bd0-8b7a-36396d322464@gmail.com> (raw)
In-Reply-To: <20250915212756.3998938-4-surenb@google.com>
On 15/09/2025 22:27, Suren Baghdasaryan wrote:
> When freeing "tail" pages of a non-compount high-order page, we properly
> subtract the allocation tag counters, however later when these pages are
> released, alloc_tag_sub() will issue warnings because tags for these pages
> are NULL.
> This issue was originally anticipated by Vlastimil in his review [1] and
> then recently reported by David.
> Prevent warnings by marking the tags empty.
>
> [1] https://lore.kernel.org/all/6db0f0c8-81cb-4d04-9560-ba73d63db4b8@suse.cz/
>
> Suggested-by: David Wang <00107082@163.com>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
> ---
> mm/page_alloc.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Acked-by: Usama Arif <usamaarif642@gmail.com>
prev parent reply other threads:[~2025-09-16 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 21:27 [PATCH v2 0/3] Minor fixes for memory allocation profiling Suren Baghdasaryan
2025-09-15 21:27 ` [PATCH v2 1/3] alloc_tag: use release_pages() in the cleanup path Suren Baghdasaryan
2025-09-15 21:27 ` [PATCH v2 2/3] alloc_tag: prevent enabling memory profiling if it was shut down Suren Baghdasaryan
2025-09-15 21:27 ` [PATCH v2 3/3] alloc_tag: avoid warnings when freeing non-compound "tail" pages Suren Baghdasaryan
2025-09-16 20:47 ` Usama Arif [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4429cad8-5363-4bd0-8b7a-36396d322464@gmail.com \
--to=usamaarif642@gmail.com \
--cc=00107082@163.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=shakeel.butt@linux.dev \
--cc=souravpanda@google.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox