From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11ACFC433ED for ; Thu, 29 Apr 2021 08:41:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5F129613F0 for ; Thu, 29 Apr 2021 08:41:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F129613F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 83A086B0070; Thu, 29 Apr 2021 04:41:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C2626B0071; Thu, 29 Apr 2021 04:41:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 615726B0072; Thu, 29 Apr 2021 04:41:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 3FC8F6B0070 for ; Thu, 29 Apr 2021 04:41:52 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EFFD43641 for ; Thu, 29 Apr 2021 08:41:51 +0000 (UTC) X-FDA: 78084761622.25.EFCCF28 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 255FD6000131 for ; Thu, 29 Apr 2021 08:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619685710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nhLq7LUYLoOj4b9P22BfA2y71v1kgsQwevldanfEtCY=; b=M5ZbxAs/a7wycvuVqP172Thr0r6778Ee+ftBDqPHa/fuBmKCs4lQrjNWCtImWqDVRNG332 5zHYVM+c0KwKLL3ePbaX/oAHR/DLZ3gPCVlclujf+oSGqFTXYgQKQwaxzDrAw0yb6t8HU4 DO7r2Hkj6qn0dKubgnny2M6PgTg+8hs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-518-pgMPVsLoOwWuQOuEz2kDFQ-1; Thu, 29 Apr 2021 04:41:47 -0400 X-MC-Unique: pgMPVsLoOwWuQOuEz2kDFQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B34C9F933; Thu, 29 Apr 2021 08:41:45 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-20.rdu2.redhat.com [10.10.112.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 928387012B; Thu, 29 Apr 2021 08:41:38 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <161918446704.3145707.14418606303992174310.stgit@warthog.procyon.org.uk> <161918455721.3145707.4063925145568978308.stgit@warthog.procyon.org.uk> To: Geert Uytterhoeven Cc: dhowells@redhat.com, Linux FS Devel , Marc Dionne , Linux MM , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, "open list:NFS, SUNRPC, AND..." , linux-cifs@vger.kernel.org, ceph-devel , V9FS Developers , Trond Myklebust , Anna Schumaker , Steve French , Dominique Martinet , Jeff Layton , David Wysochanski , "Matthew Wilcox (Oracle)" , Alexander Viro , Linux Kernel Mailing List Subject: Re: [PATCH v7 07/31] netfs: Make a netfs helper module MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <442392.1619685697.1@warthog.procyon.org.uk> Date: Thu, 29 Apr 2021 09:41:37 +0100 Message-ID: <442393.1619685697@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 255FD6000131 X-Stat-Signature: s84jfuioid9ae3ttjbws8wfmpd9ybj95 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619685706-614008 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Geert Uytterhoeven wrote: > I see later patches make AFS and FSCACHE select NETFS_SUPPORT. If this > is just a library of functions, to be selected by its users, then please > make the symbol invisible. Ideally, yes, it would be an invisible symbol enabled by select from the network filesystems that use it - but doing that means that you can't choose whether to build it in or build it as a module. David