From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <441B8F6E.7010802@yahoo.com.au> Date: Sat, 18 Mar 2006 15:41:18 +1100 From: Nick Piggin MIME-Version: 1.0 Subject: Re: [PATCH][RFC] mm: swsusp shrink_all_memory tweaks References: <200603101704.AA00798@bbb-jz5c7z9hn9y.digitalinfra.co.jp> <200603171717.23288.kernel@kolivas.org> <200603171831.46811.rjw@sisk.pl> <200603181514.27455.kernel@kolivas.org> In-Reply-To: <200603181514.27455.kernel@kolivas.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Con Kolivas Cc: "Rafael J. Wysocki" , ck@vds.kolivas.org, Andreas Mohr , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pavel Machek , Stefan Seyfried List-ID: Con Kolivas wrote: > @@ -1567,7 +1546,7 @@ loop_again: > zone->temp_priority = DEF_PRIORITY; > } > > - for (priority = DEF_PRIORITY; priority >= 0; priority--) { > + for_each_priority_reverse(priority) { What's this for? The for loop is simple and easy to read, after the change, you have to look somewhere else to see what it does. > Index: linux-2.6.16-rc6-mm1/include/linux/swap.h > =================================================================== > --- linux-2.6.16-rc6-mm1.orig/include/linux/swap.h 2006-03-18 13:29:38.000000000 +1100 > +++ linux-2.6.16-rc6-mm1/include/linux/swap.h 2006-03-18 14:50:11.000000000 +1100 > @@ -66,6 +66,51 @@ typedef struct { > unsigned long val; > } swp_entry_t; > > +struct scan_control { Why did you put this here? scan_control really can't go outside vmscan.c, it is meant only to ease the passing of lots of parameters, and not as a consistent interface. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org