From: "Jan Beulich" <JBeulich@novell.com>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: david@gibson.dropbear.id.au,
Kenneth W Chen <kenneth.w.chen@intel.com>,
linux-mm@kvack.org, Andreas Kleen <ak@suse.de>,
agl@us.ibm.com, discuss@x86-64.org
Subject: [discuss] Re: BUG in x86_64 hugepage support
Date: Wed, 15 Mar 2006 09:50:17 +0100 [thread overview]
Message-ID: <4417E359.76F0.0078.0@novell.com> (raw)
In-Reply-To: <20060315073046.GA5620@us.ibm.com>
>diff -urpN 2.6.16-rc6-mm1/mm/hugetlb.c 2.6.16-rc6-mm1-dev/mm/hugetlb.c
>--- 2.6.16-rc6-mm1/mm/hugetlb.c 2006-03-14 22:49:44.000000000 -0800
>+++ 2.6.16-rc6-mm1-dev/mm/hugetlb.c 2006-03-14 22:51:31.000000000 -0800
>@@ -740,6 +740,7 @@ void hugetlb_change_protection(struct vm
> continue;
> if (!pte_none(*ptep)) {
> pte = huge_ptep_get_and_clear(mm, address, ptep);
>+ pgprot_val(newprot) |= _PAGE_PSE;
> pte = pte_modify(pte, newprot);
> set_huge_pte_at(mm, address, ptep, pte);
> lazy_mmu_prot_update(pte);
This is architecture independent code - you shouldn't be using _PAGE_PSE here. Probably
x86-64 (and then likely also i386) should define their own set_huge_pte_at(), and use that#
to or in the needed flag?
Jan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-03-15 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-15 1:20 Nishanth Aravamudan
2006-03-15 4:03 ` Chen, Kenneth W
2006-03-15 4:35 ` Nishanth Aravamudan
2006-03-15 7:08 ` Chen, Kenneth W
2006-03-15 7:30 ` Nishanth Aravamudan
2006-03-15 8:50 ` Jan Beulich [this message]
2006-03-15 10:03 ` [discuss] " Chen, Kenneth W
2006-03-15 15:14 ` Nishanth Aravamudan
2006-03-15 15:56 ` Nishanth Aravamudan
2006-03-15 15:13 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4417E359.76F0.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=agl@us.ibm.com \
--cc=ak@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=discuss@x86-64.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-mm@kvack.org \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox