From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
linux-mm@kvack.org, paulus@samba.org, davem@davemloft.net
Subject: Re: vDSO vs. mm : problems with ppc vdso
Date: Wed, 01 Mar 2006 13:38:49 +1100 [thread overview]
Message-ID: <44050939.4060303@yahoo.com.au> (raw)
In-Reply-To: <1141180019.4157.12.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> On Wed, 2006-03-01 at 13:24 +1100, Nick Piggin wrote:
>>mapcount should be reset, to avoid the bug in page_remove_rmap.
>
>
> Can you be more explicit ?
>
reset_page_mapcount() -- if you don't already know that mapcount is
the right value.
It might not be unreasonable to say "bah my arch initialises it to
0, and I didn'tcare for it to be accounted in nr_mapped anyway",
however not using the mapcount accessors means you might break in
future if they change.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-03-01 2:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-28 5:39 Benjamin Herrenschmidt
2006-02-28 5:54 ` Andrew Morton
2006-02-28 6:08 ` Benjamin Herrenschmidt
2006-02-28 6:20 ` Andrew Morton
2006-02-28 6:30 ` Benjamin Herrenschmidt
2006-02-28 6:47 ` Andrew Morton
2006-02-28 7:36 ` Benjamin Herrenschmidt
2006-02-28 12:13 ` Hugh Dickins
2006-02-28 10:24 ` Nick Piggin
2006-02-28 12:32 ` Hugh Dickins
2006-02-28 17:55 ` Benjamin Herrenschmidt
2006-03-01 2:24 ` Nick Piggin
2006-03-01 2:26 ` Benjamin Herrenschmidt
2006-03-01 2:38 ` Nick Piggin [this message]
2006-02-28 6:27 ` [PATCH] Add mm->task_size and fix powerpc vdso Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44050939.4060303@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox